test/crypto: fix stats test
authorRuifeng Wang <ruifeng.wang@arm.com>
Mon, 31 Aug 2020 08:51:43 +0000 (16:51 +0800)
committerAkhil Goyal <akhil.goyal@nxp.com>
Wed, 14 Oct 2020 19:34:04 +0000 (21:34 +0200)
ut_setup / ut_teardown are invoked for each test case by test framework.
The call inside test_stats is unnecessary and even incorrect.
This caused double free of objects such as crypto operation structure.
Trapped the issue when RTE_LIBRTE_MEMPOOL_DEBUG was enabled.
Fix issue by removing ut_setup / ut_teardown from test case implementation.

Fixes: 202d375c60bc ("app/test: add cryptodev unit and performance tests")
Cc: stable@dpdk.org
Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
Tested-by: Adam Dybkowski <adamx.dybkowski@intel.com>
app/test/test_cryptodev.c

index 704aa7c..d702cb9 100644 (file)
@@ -9326,9 +9326,7 @@ test_stats(void)
                "rte_cryptodev_stats_get invalid Param failed");
 
        /* Test expected values */
-       ut_setup();
        test_AES_CBC_HMAC_SHA1_encrypt_digest();
-       ut_teardown();
        TEST_ASSERT_SUCCESS(rte_cryptodev_stats_get(ts_params->valid_devs[0],
                        &stats),
                "rte_cryptodev_stats_get failed");