net/enic: check in error path
authorJohn Daley <johndale@cisco.com>
Wed, 14 Oct 2020 20:25:22 +0000 (13:25 -0700)
committerFerruh Yigit <ferruh.yigit@intel.com>
Fri, 16 Oct 2020 17:48:18 +0000 (19:48 +0200)
Coverity issue: 363046
Fixes: bb66d562aefc ("net/enic: share flow actions with same signature")

Signed-off-by: John Daley <johndale@cisco.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
drivers/net/enic/enic_fm_flow.c

index 96ec360..9cea942 100644 (file)
@@ -2232,7 +2232,11 @@ enic_action_handle_get(struct enic_flowman *fm, struct fm_action *action_in,
 error_with_action_handle:
        args[0] = FM_ACTION_FREE;
        args[1] = ah->handle;
-       flowman_cmd(fm, args, 2);
+       ret = flowman_cmd(fm, args, 2);
+       if (ret != 0)
+               rte_flow_error_set(error, -ret,
+                                  RTE_FLOW_ERROR_TYPE_UNSPECIFIED,
+                                  NULL, "enic: devcmd(action-free)");
 error_with_ah:
        free(ah);
        return ret;