app/testpmd: fix key for RSS flow rule
authorAlvin Zhang <alvinx.zhang@intel.com>
Thu, 21 Jan 2021 09:41:54 +0000 (17:41 +0800)
committerFerruh Yigit <ferruh.yigit@intel.com>
Fri, 29 Jan 2021 17:16:08 +0000 (18:16 +0100)
Since the patch '1848b117' has initialized the variable 'key' in
'struct rte_flow_action_rss' with 'NULL', the PMD cannot get the
RSS key now. Details as bellow:

testpmd> flow create 0 ingress pattern eth / ipv4 / end actions
         rss types ipv4-other end key
         1234567890123456789012345678901234567890FFFFFFFFFFFF123
         4567890123456789012345678901234567890FFFFFFFFFFFF
         queues end / end
Flow rule #1 created
testpmd> show port 0 rss-hash key
RSS functions:
         all ipv4-other ip
RSS key:
         4439796BB54C5023B675EA5B124F9F30B8A2C03DDFDC4D02A08C9B3
         34AF64A4C05C6FA343958D8557D99583AE138C92E81150366

This patch sets offset and size of the 'key' variable as the first
parameter of the token 'key'. Later, the address of the RSS key will
be copied to 'key' variable.

Fixes: 1848b117cca1 ("app/testpmd: fix RSS key for flow API RSS rule")
Cc: stable@dpdk.org
Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
Tested-by: Jun W Zhou <junx.w.zhou@intel.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
app/test-pmd/cmdline_flow.c

index 0618611..067e120 100644 (file)
@@ -3541,7 +3541,10 @@ static const struct token token_list[] = {
                .name = "key",
                .help = "RSS hash key",
                .next = NEXT(action_rss, NEXT_ENTRY(HEX)),
-               .args = ARGS(ARGS_ENTRY_ARB(0, 0),
+               .args = ARGS(ARGS_ENTRY_ARB
+                            (offsetof(struct action_rss_data, conf) +
+                             offsetof(struct rte_flow_action_rss, key),
+                             sizeof(((struct rte_flow_action_rss *)0)->key)),
                             ARGS_ENTRY_ARB
                             (offsetof(struct action_rss_data, conf) +
                              offsetof(struct rte_flow_action_rss, key_len),