raw/ifpga: check probing error
authorRosen Xu <rosen.xu@intel.com>
Tue, 23 Oct 2018 01:50:49 +0000 (09:50 +0800)
committerFerruh Yigit <ferruh.yigit@intel.com>
Fri, 26 Oct 2018 20:14:06 +0000 (22:14 +0200)
Fixes not checking rte_eal_hotplug_add() return value issue.

Coverity issue: 323508
Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver")
Cc: stable@dpdk.org
Signed-off-by: Rosen Xu <rosen.xu@intel.com>
Acked-by: Shreyansh Jain <shreyansh.jain@nxp.com>
drivers/raw/ifpga_rawdev/ifpga_rawdev.c

index 3fed057..32e318f 100644 (file)
@@ -542,6 +542,7 @@ ifpga_cfg_probe(struct rte_vdev_device *dev)
        int port;
        char *name = NULL;
        char dev_name[RTE_RAWDEV_NAME_MAX_LEN];
+       int ret = -1;
 
        devargs = dev->device.devargs;
 
@@ -583,7 +584,7 @@ ifpga_cfg_probe(struct rte_vdev_device *dev)
        snprintf(dev_name, RTE_RAWDEV_NAME_MAX_LEN, "%d|%s",
        port, name);
 
-       rte_eal_hotplug_add(RTE_STR(IFPGA_BUS_NAME),
+       ret = rte_eal_hotplug_add(RTE_STR(IFPGA_BUS_NAME),
                        dev_name, devargs->args);
 end:
        if (kvlist)
@@ -591,7 +592,7 @@ end:
        if (name)
                free(name);
 
-       return 0;
+       return ret;
 }
 
 static int