]> git.droids-corp.org - dpdk.git/commitdiff
app/testpmd: fix RSS types display
authorHuisong Li <lihuisong@huawei.com>
Fri, 8 Jul 2022 01:41:59 +0000 (09:41 +0800)
committerFerruh Yigit <ferruh.yigit@xilinx.com>
Fri, 8 Jul 2022 10:28:38 +0000 (12:28 +0200)
Now testpmd fails to display types when query RSS rule. The failure is
because the '\n' character is missing at the end of the function
'rss_config_display()'.
Actually, all places calling 'xxx_types_display()' need to '\n'. So this
patch moves '\n' to the inside of these function.

Bugzilla ID: 1048
Fixes: 534988c490f1 ("app/testpmd: unify RSS types display")
Fixes: 44a37f3cffe0 ("app/testpmd: compact RSS types output")
Signed-off-by: Huisong Li <lihuisong@huawei.com>
Tested-by: Weiyuan Li <weiyuanx.li@intel.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@xilinx.com>
app/test-pmd/config.c

index 608bec9796fe45867c7c87ac9bc92dd3af83f1a4..a2939867c4363b45004a5dd8ed64b7b9dbca19cd 100644 (file)
@@ -761,6 +761,7 @@ rss_offload_types_display(uint64_t offload_types, uint16_t char_num_per_line)
                        total_len += str_len;
                }
        }
+       printf("\n");
 }
 
 void
@@ -870,7 +871,6 @@ port_infos_display(portid_t port_id)
                printf("Supported RSS offload flow types:\n");
                rss_offload_types_display(dev_info.flow_type_rss_offloads,
                                TESTPMD_RSS_TYPES_CHAR_NUM_PER_LINE);
-               printf("\n");
        }
 
        printf("Minimum size of RX buffer: %u\n", dev_info.min_rx_bufsize);
@@ -1648,6 +1648,7 @@ rss_types_display(uint64_t rss_types, uint16_t char_num_per_line)
                        total_len += str_len;
                }
        }
+       printf("\n");
 }
 
 static void
@@ -3924,7 +3925,6 @@ port_rss_hash_conf_show(portid_t port_id, int show_rss_key)
        }
        printf("RSS functions:\n");
        rss_types_display(rss_hf, TESTPMD_RSS_TYPES_CHAR_NUM_PER_LINE);
-       printf("\n");
        if (!show_rss_key)
                return;
        printf("RSS key:\n");