cfgfile: replace strcat with strlcat

Replace strcat with strlcat to avoid buffer overflow.

Fixes: a6a47ac9c2 ("cfgfile: rework load function")
Cc: stable@dpdk.org
Signed-off-by: Chaitanya Babu Talluri <tallurix.chaitanya.babu@intel.com>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

diff --git a/lib/librte_cfgfile/rte_cfgfile.c b/lib/librte_cfgfile/rte_cfgfile.c
index 6110dba..f8e7627 100644 (file)
--- a/lib/librte_cfgfile/rte_cfgfile.c
+++ b/lib/librte_cfgfile/rte_cfgfile.c
@@ -224,10 +224,11 @@ rte_cfgfile_load_with_params(const char *filename, int flags,
                        _strip(split[1], strlen(split[1]));
                        char *end = memchr(split[1], '\\', strlen(split[1]));
 
+                       size_t split_len = strlen(split[1]) + 1;
                        while (end != NULL) {
                                if (*(end+1) == params->comment_character) {
                                        *end = '\0';
-                                       strcat(split[1], end+1);
+                                       strlcat(split[1], end+1, split_len);
                                } else
                                        end++;
                                end = memchr(end, '\\', strlen(end));