eal: deduplicate lcore initialization
authorRavi Kerur <rkerur@gmail.com>
Sat, 25 Jul 2015 19:36:27 +0000 (12:36 -0700)
committerThomas Monjalon <thomas.monjalon@6wind.com>
Sun, 26 Jul 2015 22:56:08 +0000 (00:56 +0200)
Implement cpu_detected() for BSD.
Move common function in eal_lcore.c to eal_common_lcore.c file.

Signed-off-by: Ravi Kerur <rkerur@gmail.com>
lib/librte_eal/bsdapp/eal/Makefile
lib/librte_eal/bsdapp/eal/eal_lcore.c
lib/librte_eal/common/eal_common_lcore.c [new file with mode: 0644]
lib/librte_eal/common/eal_private.h
lib/librte_eal/linuxapp/eal/Makefile
lib/librte_eal/linuxapp/eal/eal_lcore.c

index 01e5972..24733ae 100644 (file)
@@ -60,6 +60,7 @@ SRCS-$(CONFIG_RTE_LIBRTE_EAL_BSDAPP) += eal_interrupts.c
 SRCS-$(CONFIG_RTE_LIBRTE_EAL_BSDAPP) += eal_alarm.c
 
 # from common dir
+SRCS-$(CONFIG_RTE_LIBRTE_EAL_BSDAPP) += eal_common_lcore.c
 SRCS-$(CONFIG_RTE_LIBRTE_EAL_BSDAPP) += eal_common_memzone.c
 SRCS-$(CONFIG_RTE_LIBRTE_EAL_BSDAPP) += eal_common_log.c
 SRCS-$(CONFIG_RTE_LIBRTE_EAL_BSDAPP) += eal_common_launch.c
index 162fb4f..b47eb1b 100644 (file)
 #include "eal_thread.h"
 
 /* No topology information available on FreeBSD including NUMA info */
-#define cpu_core_id(X) 0
-#define cpu_socket_id(X) 0
+unsigned
+eal_cpu_core_id(__rte_unused unsigned lcore_id)
+{
+       return 0;
+}
 
 static int
-get_ncpus(void)
+eal_get_ncpus(void)
 {
        int mib[2] = {CTL_HW, HW_NCPU};
        int ncpu;
@@ -59,63 +62,18 @@ get_ncpus(void)
        return ncpu;
 }
 
-/*
- * fill the cpu_info structure with as much info as we can get.
- * code is similar to linux version, but sadly available info is less.
- */
-int
-rte_eal_cpu_init(void)
+unsigned
+eal_cpu_socket_id(__rte_unused unsigned cpu_id)
 {
-       /* pointer to global configuration */
-       struct rte_config *config = rte_eal_get_configuration();
-       unsigned lcore_id;
-       unsigned count = 0;
-
-       const unsigned ncpus = get_ncpus();
-       /*
-        * Parse the maximum set of logical cores, detect the subset of running
-        * ones and enable them by default.
-        */
-       for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) {
-               /* init cpuset for per lcore config */
-               CPU_ZERO(&lcore_config[lcore_id].cpuset);
-
-               lcore_config[lcore_id].detected = (lcore_id < ncpus);
-               if (lcore_config[lcore_id].detected == 0) {
-                       config->lcore_role[lcore_id] = ROLE_OFF;
-                       continue;
-               }
-
-               /* By default, lcore 1:1 map to cpu id */
-               CPU_SET(lcore_id, &lcore_config[lcore_id].cpuset);
-
-               /* By default, each detected core is enabled */
-               config->lcore_role[lcore_id] = ROLE_RTE;
-               lcore_config[lcore_id].core_id = cpu_core_id(lcore_id);
-               lcore_config[lcore_id].socket_id = cpu_socket_id(lcore_id);
-               if (lcore_config[lcore_id].socket_id >= RTE_MAX_NUMA_NODES)
-#ifdef RTE_EAL_ALLOW_INV_SOCKET_ID
-                       lcore_config[lcore_id].socket_id = 0;
-#else
-                       rte_panic("Socket ID (%u) is greater than "
-                               "RTE_MAX_NUMA_NODES (%d)\n",
-                               lcore_config[lcore_id].socket_id, RTE_MAX_NUMA_NODES);
-#endif
-               RTE_LOG(DEBUG, EAL, "Detected lcore %u\n",
-                               lcore_id);
-               count++;
-       }
-       /* Set the count of enabled logical cores of the EAL configuration */
-       config->lcore_count = count;
-       RTE_LOG(DEBUG, EAL, "Support maximum %u logical core(s) by configuration.\n",
-               RTE_MAX_LCORE);
-       RTE_LOG(DEBUG, EAL, "Detected %u lcore(s)\n", config->lcore_count);
-
        return 0;
 }
 
-unsigned
-eal_cpu_socket_id(__rte_unused unsigned cpu_id)
+/* Check if a cpu is present by the presence of the
+ * cpu information for it.
+ */
+int
+eal_cpu_detected(unsigned lcore_id)
 {
-       return cpu_socket_id(cpu_id);
+       const unsigned ncpus = eal_get_ncpus();
+       return (lcore_id < ncpus);
 }
diff --git a/lib/librte_eal/common/eal_common_lcore.c b/lib/librte_eal/common/eal_common_lcore.c
new file mode 100644 (file)
index 0000000..845140b
--- /dev/null
@@ -0,0 +1,107 @@
+/*-
+ *   BSD LICENSE
+ *
+ *   Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
+ *   All rights reserved.
+ *
+ *   Redistribution and use in source and binary forms, with or without
+ *   modification, are permitted provided that the following conditions
+ *   are met:
+ *
+ *     * Redistributions of source code must retain the above copyright
+ *       notice, this list of conditions and the following disclaimer.
+ *     * Redistributions in binary form must reproduce the above copyright
+ *       notice, this list of conditions and the following disclaimer in
+ *       the documentation and/or other materials provided with the
+ *       distribution.
+ *     * Neither the name of Intel Corporation nor the names of its
+ *       contributors may be used to endorse or promote products derived
+ *       from this software without specific prior written permission.
+ *
+ *   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ *   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ *   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ *   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ *   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ *   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ *   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ *   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ *   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ *   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ *   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include <unistd.h>
+#include <limits.h>
+#include <string.h>
+#include <dirent.h>
+
+#include <rte_log.h>
+#include <rte_eal.h>
+#include <rte_lcore.h>
+#include <rte_common.h>
+#include <rte_debug.h>
+
+#include "eal_private.h"
+#include "eal_thread.h"
+
+/*
+ * Parse /sys/devices/system/cpu to get the number of physical and logical
+ * processors on the machine. The function will fill the cpu_info
+ * structure.
+ */
+int
+rte_eal_cpu_init(void)
+{
+       /* pointer to global configuration */
+       struct rte_config *config = rte_eal_get_configuration();
+       unsigned lcore_id;
+       unsigned count = 0;
+
+       /*
+        * Parse the maximum set of logical cores, detect the subset of running
+        * ones and enable them by default.
+        */
+       for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) {
+               /* init cpuset for per lcore config */
+               CPU_ZERO(&lcore_config[lcore_id].cpuset);
+
+               /* in 1:1 mapping, record related cpu detected state */
+               lcore_config[lcore_id].detected = eal_cpu_detected(lcore_id);
+               if (lcore_config[lcore_id].detected == 0) {
+                       config->lcore_role[lcore_id] = ROLE_OFF;
+                       continue;
+               }
+
+               /* By default, lcore 1:1 map to cpu id */
+               CPU_SET(lcore_id, &lcore_config[lcore_id].cpuset);
+
+               /* By default, each detected core is enabled */
+               config->lcore_role[lcore_id] = ROLE_RTE;
+               lcore_config[lcore_id].core_id = eal_cpu_core_id(lcore_id);
+               lcore_config[lcore_id].socket_id = eal_cpu_socket_id(lcore_id);
+               if (lcore_config[lcore_id].socket_id >= RTE_MAX_NUMA_NODES)
+#ifdef RTE_EAL_ALLOW_INV_SOCKET_ID
+                       lcore_config[lcore_id].socket_id = 0;
+#else
+                       rte_panic("Socket ID (%u) is greater than "
+                               "RTE_MAX_NUMA_NODES (%d)\n",
+                               lcore_config[lcore_id].socket_id,
+                               RTE_MAX_NUMA_NODES);
+#endif
+
+               RTE_LOG(DEBUG, EAL, "Detected lcore %u as "
+                               "core %u on socket %u\n",
+                               lcore_id, lcore_config[lcore_id].core_id,
+                               lcore_config[lcore_id].socket_id);
+               count++;
+       }
+       /* Set the count of enabled logical cores of the EAL configuration */
+       config->lcore_count = count;
+       RTE_LOG(DEBUG, EAL,
+               "Support maximum %u logical core(s) by configuration.\n",
+               RTE_MAX_LCORE);
+       RTE_LOG(DEBUG, EAL, "Detected %u lcore(s)\n", config->lcore_count);
+
+       return 0;
+}
index 73363f6..8505b05 100644 (file)
@@ -300,4 +300,18 @@ int rte_eal_dev_init(void);
  */
 int rte_eal_check_module(const char *module_name);
 
+/**
+ * Get cpu core_id.
+ *
+ * This function is private to the EAL.
+ */
+unsigned eal_cpu_core_id(unsigned lcore_id);
+
+/**
+ * Check if cpu is present.
+ *
+ * This function is private to the EAL.
+ */
+int eal_cpu_detected(unsigned lcore_id);
+
 #endif /* _EAL_PRIVATE_H_ */
index 0726ce1..f4f8cdf 100644 (file)
@@ -70,6 +70,7 @@ SRCS-$(CONFIG_RTE_LIBRTE_EAL_LINUXAPP) += eal_ivshmem.c
 endif
 
 # from common dir
+SRCS-$(CONFIG_RTE_LIBRTE_EAL_LINUXAPP) += eal_common_lcore.c
 SRCS-$(CONFIG_RTE_LIBRTE_EAL_LINUXAPP) += eal_common_memzone.c
 SRCS-$(CONFIG_RTE_LIBRTE_EAL_LINUXAPP) += eal_common_log.c
 SRCS-$(CONFIG_RTE_LIBRTE_EAL_LINUXAPP) += eal_common_launch.c
@@ -102,6 +103,7 @@ CFLAGS_eal_pci_vfio.o := -D_GNU_SOURCE
 CFLAGS_eal_common_whitelist.o := -D_GNU_SOURCE
 CFLAGS_eal_common_options.o := -D_GNU_SOURCE
 CFLAGS_eal_common_thread.o := -D_GNU_SOURCE
+CFLAGS_eal_common_lcore.o := -D_GNU_SOURCE
 
 # workaround for a gcc bug with noreturn attribute
 # http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12603
index 560039b..de5b426 100644 (file)
@@ -52,8 +52,8 @@
 #define NUMA_NODE_PATH "/sys/devices/system/node"
 
 /* Check if a cpu is present by the presence of the cpu information for it */
-static int
-cpu_detected(unsigned lcore_id)
+int
+eal_cpu_detected(unsigned lcore_id)
 {
        char path[PATH_MAX];
        int len = snprintf(path, sizeof(path), SYS_CPU_DIR
@@ -90,8 +90,8 @@ eal_cpu_socket_id(unsigned lcore_id)
 }
 
 /* Get the cpu core id value from the /sys/.../cpuX core_id value */
-static unsigned
-cpu_core_id(unsigned lcore_id)
+unsigned
+eal_cpu_core_id(unsigned lcore_id)
 {
        char path[PATH_MAX];
        unsigned long id;
@@ -108,61 +108,3 @@ err:
                        "for lcore %u - assuming core 0\n", SYS_CPU_DIR, lcore_id);
        return 0;
 }
-
-/*
- * Parse /sys/devices/system/cpu to get the number of physical and logical
- * processors on the machine. The function will fill the cpu_info
- * structure.
- */
-int
-rte_eal_cpu_init(void)
-{
-       /* pointer to global configuration */
-       struct rte_config *config = rte_eal_get_configuration();
-       unsigned lcore_id;
-       unsigned count = 0;
-
-       /*
-        * Parse the maximum set of logical cores, detect the subset of running
-        * ones and enable them by default.
-        */
-       for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) {
-               /* init cpuset for per lcore config */
-               CPU_ZERO(&lcore_config[lcore_id].cpuset);
-
-               /* in 1:1 mapping, record related cpu detected state */
-               lcore_config[lcore_id].detected = cpu_detected(lcore_id);
-               if (lcore_config[lcore_id].detected == 0) {
-                       config->lcore_role[lcore_id] = ROLE_OFF;
-                       continue;
-               }
-
-               /* By default, lcore 1:1 map to cpu id */
-               CPU_SET(lcore_id, &lcore_config[lcore_id].cpuset);
-
-               /* By default, each detected core is enabled */
-               config->lcore_role[lcore_id] = ROLE_RTE;
-               lcore_config[lcore_id].core_id = cpu_core_id(lcore_id);
-               lcore_config[lcore_id].socket_id = eal_cpu_socket_id(lcore_id);
-               if (lcore_config[lcore_id].socket_id >= RTE_MAX_NUMA_NODES)
-#ifdef RTE_EAL_ALLOW_INV_SOCKET_ID
-                       lcore_config[lcore_id].socket_id = 0;
-#else
-                       rte_panic("Socket ID (%u) is greater than "
-                               "RTE_MAX_NUMA_NODES (%d)\n",
-                               lcore_config[lcore_id].socket_id, RTE_MAX_NUMA_NODES);
-#endif
-               RTE_LOG(DEBUG, EAL, "Detected lcore %u as core %u on socket %u\n",
-                               lcore_id,
-                               lcore_config[lcore_id].core_id,
-                               lcore_config[lcore_id].socket_id);
-               count ++;
-       }
-       /* Set the count of enabled logical cores of the EAL configuration */
-       config->lcore_count = count;
-       RTE_LOG(DEBUG, EAL, "Support maximum %u logical core(s) by configuration.\n",
-               RTE_MAX_LCORE);
-       RTE_LOG(DEBUG, EAL, "Detected %u lcore(s)\n", config->lcore_count);
-
-       return 0;
-}