net/sfc: support parameter to choose performance profile

Supported options are auto (based on NIC firmware variant and
installed licences), throughput, low-latency.

Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
Reviewed-by: Andrew Lee <alee@solarflare.com>
Reviewed-by: Robert Stonehouse <rstonehouse@solarflare.com>

diff --git a/doc/guides/nics/sfc_efx.rst b/doc/guides/nics/sfc_efx.rst
index 2cca287760f6aa807edf4ca82e15f45af24603d4..36d0974107a31b5f307cf7ae19e4b24748fa21c6 100644 (file)
--- a/doc/guides/nics/sfc_efx.rst
+++ b/doc/guides/nics/sfc_efx.rst
@@ -152,6 +152,13 @@ whitelist option like "-w 02:00.0,arg1=value1,...".
 Case-insensitive 1/y/yes/on or 0/n/no/off may be used to specify
 boolean parameters value.
 
+- ``perf_profile`` [auto|throughput|low-latency] (default **throughput**)
+
+  Choose hardware tunning to be optimized for either throughput or
+  low-latency.
+  **auto** allows NIC firmware to make a choice based on
+  installed licences and firmware variant configured using **sfboot**.
+
 - ``debug_init`` [bool] (default **n**)
 
   Enable extra logging during device intialization and startup.

diff --git a/drivers/net/sfc/sfc.h b/drivers/net/sfc/sfc.h
index 568a40e952136cefee503d3b6d227d46b0f5e6df..7e61d0c4803b8f384ed9a4a2acfae9a9b4704b98 100644 (file)
--- a/drivers/net/sfc/sfc.h
+++ b/drivers/net/sfc/sfc.h
@@ -155,6 +155,7 @@ struct sfc_adapter {
 
        unsigned int                    txq_max_entries;
 
+       uint32_t                        evq_flags;
        unsigned int                    evq_count;
        struct sfc_evq_info             *evq_info;
 

diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c
index bb79c9cc921bc374bc7705dd61aa504747141079..77f22f8d37d370b60e5bae247a82bc4b4327fdf6 100644 (file)
--- a/drivers/net/sfc/sfc_ethdev.c
+++ b/drivers/net/sfc/sfc_ethdev.c
@@ -463,5 +463,6 @@ static struct eth_driver sfc_efx_pmd = {
 RTE_PMD_REGISTER_PCI(net_sfc_efx, sfc_efx_pmd.pci_drv);
 RTE_PMD_REGISTER_PCI_TABLE(net_sfc_efx, pci_id_sfc_efx_map);
 RTE_PMD_REGISTER_PARAM_STRING(net_sfc_efx,
+       SFC_KVARG_PERF_PROFILE "=" SFC_KVARG_VALUES_PERF_PROFILE " "
        SFC_KVARG_MCDI_LOGGING "=" SFC_KVARG_VALUES_BOOL " "
        SFC_KVARG_DEBUG_INIT "=" SFC_KVARG_VALUES_BOOL);

diff --git a/drivers/net/sfc/sfc_ev.c b/drivers/net/sfc/sfc_ev.c
index af3c7b28139d3e2a018a5c3c4c2d0a80a4c3cbf9..de428452cb6422e9066b6ef7173779b1759bc8ca 100644 (file)
--- a/drivers/net/sfc/sfc_ev.c
+++ b/drivers/net/sfc/sfc_ev.c
@@ -40,6 +40,7 @@
 #include "sfc_ev.h"
 #include "sfc_rx.h"
 #include "sfc_tx.h"
+#include "sfc_kvargs.h"
 
 
 /* Initial delay when waiting for event queue init complete event */
@@ -405,9 +406,7 @@ sfc_ev_qstart(struct sfc_adapter *sa, unsigned int sw_index)
 
        /* Create the common code event queue */
        rc = efx_ev_qcreate(sa->nic, sw_index, esmp, evq_info->entries,
-                           0 /* unused on EF10 */, 0,
-                           EFX_EVQ_FLAGS_TYPE_THROUGHPUT |
-                           EFX_EVQ_FLAGS_NOTIFY_DISABLED,
+                           0 /* unused on EF10 */, 0, evq_info->flags,
                            &evq->common);
        if (rc != 0)
                goto fail_ev_qcreate;
@@ -640,6 +639,25 @@ sfc_ev_qinit_info(struct sfc_adapter *sa, unsigned int sw_index)
        SFC_ASSERT(rte_is_power_of_2(max_entries));
 
        evq_info->max_entries = max_entries;
+       evq_info->flags = sa->evq_flags | EFX_EVQ_FLAGS_NOTIFY_DISABLED;
+
+       return 0;
+}
+
+static int
+sfc_kvarg_perf_profile_handler(__rte_unused const char *key,
+                              const char *value_str, void *opaque)
+{
+       uint64_t *value = opaque;
+
+       if (strcasecmp(value_str, SFC_KVARG_PERF_PROFILE_THROUGHPUT) == 0)
+               *value = EFX_EVQ_FLAGS_TYPE_THROUGHPUT;
+       else if (strcasecmp(value_str, SFC_KVARG_PERF_PROFILE_LOW_LATENCY) == 0)
+               *value = EFX_EVQ_FLAGS_TYPE_LOW_LATENCY;
+       else if (strcasecmp(value_str, SFC_KVARG_PERF_PROFILE_AUTO) == 0)
+               *value = EFX_EVQ_FLAGS_TYPE_AUTO;
+       else
+               return -EINVAL;
 
        return 0;
 }
@@ -660,6 +678,16 @@ sfc_ev_init(struct sfc_adapter *sa)
 
        sfc_log_init(sa, "entry");
 
+       sa->evq_flags = EFX_EVQ_FLAGS_TYPE_THROUGHPUT;
+       rc = sfc_kvargs_process(sa, SFC_KVARG_PERF_PROFILE,
+                               sfc_kvarg_perf_profile_handler,
+                               &sa->evq_flags);
+       if (rc != 0) {
+               sfc_err(sa, "invalid %s parameter value",
+                       SFC_KVARG_PERF_PROFILE);
+               goto fail_kvarg_perf_profile;
+       }
+
        sa->evq_count = sfc_ev_qcount(sa);
        sa->mgmt_evq_index = 0;
        rte_spinlock_init(&sa->mgmt_evq_lock);
@@ -700,6 +728,8 @@ fail_ev_qinit_info:
 
 fail_evqs_alloc:
        sa->evq_count = 0;
+
+fail_kvarg_perf_profile:
        sfc_log_init(sa, "failed %d", rc);
        return rc;
 }

diff --git a/drivers/net/sfc/sfc_ev.h b/drivers/net/sfc/sfc_ev.h
index 110f3b6eda0512400729255e7b705c74d7258191..346e3ec328371c295e9c497de17016f89bdebae2 100644 (file)
--- a/drivers/net/sfc/sfc_ev.h
+++ b/drivers/net/sfc/sfc_ev.h
@@ -74,6 +74,8 @@ struct sfc_evq_info {
        unsigned int            max_entries;
        /* Real number of EVQ entries, less or equal to max_entries */
        unsigned int            entries;
+       /* Event queue creation flags */
+       uint32_t                flags;
        /* NUMA-aware EVQ data structure used on datapath */
        struct sfc_evq          *evq;
 };

diff --git a/drivers/net/sfc/sfc_kvargs.c b/drivers/net/sfc/sfc_kvargs.c
index 5496b12e48c18c5b31edc453c38ab8ffd6ef7e7f..227a8dbea83778d2e299e76796e473a408b8a3c2 100644 (file)
--- a/drivers/net/sfc/sfc_kvargs.c
+++ b/drivers/net/sfc/sfc_kvargs.c
@@ -44,6 +44,7 @@ sfc_kvargs_parse(struct sfc_adapter *sa)
        const char **params = (const char *[]){
                SFC_KVARG_DEBUG_INIT,
                SFC_KVARG_MCDI_LOGGING,
+               SFC_KVARG_PERF_PROFILE,
                NULL,
        };
 

diff --git a/drivers/net/sfc/sfc_kvargs.h b/drivers/net/sfc/sfc_kvargs.h
index ffce851dd31708a728a0d1074d2b0fdc156166ec..2fea9c7a4c4f72dc3703dc1d00be13f3f766537b 100644 (file)
--- a/drivers/net/sfc/sfc_kvargs.h
+++ b/drivers/net/sfc/sfc_kvargs.h
@@ -42,6 +42,16 @@ extern "C" {
 
 #define SFC_KVARG_MCDI_LOGGING         "mcdi_logging"
 
+#define SFC_KVARG_PERF_PROFILE         "perf_profile"
+
+#define SFC_KVARG_PERF_PROFILE_AUTO            "auto"
+#define SFC_KVARG_PERF_PROFILE_THROUGHPUT      "throughput"
+#define SFC_KVARG_PERF_PROFILE_LOW_LATENCY     "low-latency"
+#define SFC_KVARG_VALUES_PERF_PROFILE \
+       "[" SFC_KVARG_PERF_PROFILE_AUTO "|" \
+           SFC_KVARG_PERF_PROFILE_THROUGHPUT "|" \
+           SFC_KVARG_PERF_PROFILE_LOW_LATENCY "]"
+
 struct sfc_adapter;
 
 int sfc_kvargs_parse(struct sfc_adapter *sa);