dmadev: hide devices array
authorDavid Marchand <david.marchand@redhat.com>
Thu, 21 Oct 2021 12:59:36 +0000 (20:59 +0800)
committerDavid Marchand <david.marchand@redhat.com>
Thu, 21 Oct 2021 20:01:37 +0000 (22:01 +0200)
No need to expose rte_dma_devices out of the dmadev library.
Existing helpers should be enough, and inlines make use of
rte_dma_fp_objs.

Signed-off-by: David Marchand <david.marchand@redhat.com>
Reviewed-by: Chengwen Feng <fengchengwen@huawei.com>
Tested-by: Conor Walsh <conor.walsh@intel.com>
Acked-by: Kevin Laatz <kevin.laatz@intel.com>
app/test/test_dmadev.c
lib/dmadev/rte_dmadev.c
lib/dmadev/rte_dmadev_pmd.h
lib/dmadev/version.map

index 1e327bd..8b58256 100644 (file)
@@ -747,10 +747,11 @@ test_dmadev_instance(int16_t dev_id)
        };
        const int vchan = 0;
 
+       rte_dma_info_get(dev_id, &info);
+
        printf("\n### Test dmadev instance %u [%s]\n",
-                       dev_id, rte_dma_devices[dev_id].data->dev_name);
+                       dev_id, info.dev_name);
 
-       rte_dma_info_get(dev_id, &info);
        if (info.max_vchans < 1)
                ERR_RETURN("Error, no channels available on device id %u\n", dev_id);
 
index 182d32a..d4b32b2 100644 (file)
@@ -18,7 +18,7 @@
 static int16_t dma_devices_max;
 
 struct rte_dma_fp_object *rte_dma_fp_objs;
-struct rte_dma_dev *rte_dma_devices;
+static struct rte_dma_dev *rte_dma_devices;
 static struct {
        /* Hold the dev_max information of the primary process. This field is
         * set by the primary process and is read by the secondary process.
index b97b5bf..5316ad5 100644 (file)
@@ -131,8 +131,6 @@ struct rte_dma_dev {
        uint64_t reserved[2]; /**< Reserved for future fields. */
 } __rte_cache_aligned;
 
-extern struct rte_dma_dev *rte_dma_devices;
-
 /**
  * @internal
  * Allocate a new dmadev slot for an DMA device and return the pointer to that
index ef561ac..89f7a5b 100644 (file)
@@ -30,7 +30,6 @@ EXPERIMENTAL {
 INTERNAL {
        global:
 
-       rte_dma_devices;
        rte_dma_fp_objs;
        rte_dma_pmd_allocate;
        rte_dma_pmd_release;