net/ionic: remove unused field from queue structure
authorAndrew Boyer <aboyer@pensando.io>
Tue, 16 Feb 2021 20:35:30 +0000 (12:35 -0800)
committerFerruh Yigit <ferruh.yigit@intel.com>
Thu, 25 Feb 2021 15:58:56 +0000 (16:58 +0100)
This will conserve resources.

Signed-off-by: Andrew Boyer <aboyer@pensando.io>
drivers/net/ionic/ionic_dev.c
drivers/net/ionic/ionic_dev.h
drivers/net/ionic/ionic_lif.c
drivers/net/ionic/ionic_rxtx.c

index 74ac2e6..97fb8ac 100644 (file)
@@ -383,12 +383,6 @@ ionic_cq_map(struct ionic_cq *cq, void *base, rte_iova_t base_pa)
        cq->base_pa = base_pa;
 }
 
-void
-ionic_cq_bind(struct ionic_cq *cq, struct ionic_queue *q)
-{
-       q->bound_cq = cq;
-}
-
 uint32_t
 ionic_cq_service(struct ionic_cq *cq, uint32_t work_to_do,
                 ionic_cq_cb cb, void *cb_arg)
index c51c2a9..a777695 100644 (file)
@@ -137,7 +137,6 @@ struct ionic_dev {
 struct ionic_queue {
        struct ionic_dev *idev;
        struct ionic_lif *lif;
-       struct ionic_cq *bound_cq;
        uint32_t index;
        uint32_t type;
        uint32_t hw_index;
@@ -221,7 +220,6 @@ struct ionic_doorbell __iomem *ionic_db_map(struct ionic_lif *lif,
 
 int ionic_cq_init(struct ionic_cq *cq, uint16_t num_descs);
 void ionic_cq_map(struct ionic_cq *cq, void *base, rte_iova_t base_pa);
-void ionic_cq_bind(struct ionic_cq *cq, struct ionic_queue *q);
 typedef bool (*ionic_cq_cb)(struct ionic_cq *cq, uint32_t cq_desc_index,
                void *cb_arg);
 uint32_t ionic_cq_service(struct ionic_cq *cq, uint32_t work_to_do,
index 52bc0b1..1ca6e05 100644 (file)
@@ -695,7 +695,6 @@ ionic_qcq_alloc(struct ionic_lif *lif, uint8_t type,
 
        ionic_q_map(&new->q, q_base, q_base_pa);
        ionic_cq_map(&new->cq, cq_base, cq_base_pa);
-       ionic_cq_bind(&new->cq, &new->q);
 
        *qcq = new;
 
index d736e24..d615e5c 100644 (file)
@@ -741,14 +741,15 @@ ionic_dev_rx_queue_setup(struct rte_eth_dev *eth_dev,
 }
 
 static __rte_always_inline void
-ionic_rx_clean(struct ionic_queue *q,
+ionic_rx_clean(struct ionic_qcq *rxq,
                uint32_t q_desc_index, uint32_t cq_desc_index,
                void *service_cb_arg)
 {
-       struct ionic_rxq_comp *cq_desc_base = q->bound_cq->base;
+       struct ionic_queue *q = &rxq->q;
+       struct ionic_cq *cq = &rxq->cq;
+       struct ionic_rxq_comp *cq_desc_base = cq->base;
        struct ionic_rxq_comp *cq_desc = &cq_desc_base[cq_desc_index];
        struct rte_mbuf *rxm, *rxm_seg;
-       struct ionic_qcq *rxq = IONIC_Q_TO_QCQ(q);
        uint32_t max_frame_size =
                rxq->lif->eth_dev->data->dev_conf.rxmode.max_rx_pkt_len;
        uint64_t pkt_flags = 0;
@@ -1061,7 +1062,7 @@ ionic_rxq_service(struct ionic_qcq *rxq, uint32_t work_to_do,
                                /* q desc info */
                                rte_prefetch0(&q->info[q->tail_idx]);
 
-                       ionic_rx_clean(q, curr_q_tail_idx, curr_cq_tail_idx,
+                       ionic_rx_clean(rxq, curr_q_tail_idx, curr_cq_tail_idx,
                                service_cb_arg);
 
                } while (more);