]> git.droids-corp.org - dpdk.git/commitdiff
net/hns3: fix MAC enable failure rollback
authorHuisong Li <lihuisong@huawei.com>
Thu, 29 Apr 2021 09:03:59 +0000 (17:03 +0800)
committerFerruh Yigit <ferruh.yigit@intel.com>
Tue, 4 May 2021 14:12:04 +0000 (16:12 +0200)
If driver fails to enable MAC, it does not need to rollback the MAC
configuration. This patch fixes it.

Fixes: bdaf190f8235 ("net/hns3: support link speed autoneg for PF")
Signed-off-by: Huisong Li <lihuisong@huawei.com>
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
drivers/net/hns3/hns3_ethdev.c

index b6655549e9ff2dee26d30d494475cc6d49c4639f..c554d2adfc4b039752a3c828e3086d3d3120a857 100644 (file)
@@ -5608,12 +5608,14 @@ hns3_do_start(struct hns3_adapter *hns, bool reset_queue)
 
        ret = hns3_apply_link_speed(hw);
        if (ret)
-               goto err_config_mac_mode;
+               goto err_set_link_speed;
 
        return 0;
 
-err_config_mac_mode:
+err_set_link_speed:
        (void)hns3_cfg_mac_mode(hw, false);
+
+err_config_mac_mode:
        hns3_dev_release_mbufs(hns);
        /*
         * Here is exception handling, hns3_reset_all_tqps will have the