net/qede/base: handle the error condition properly
authorRasesh Mody <rasesh.mody@cavium.com>
Tue, 19 Sep 2017 01:51:27 +0000 (18:51 -0700)
committerFerruh Yigit <ferruh.yigit@intel.com>
Fri, 6 Oct 2017 00:49:49 +0000 (02:49 +0200)
If for some reason the send message from VF to PF times out, don't bail out
right away without taking proper cleanup action. The goto statement calls
ecore_vf_pf_req_end() which will unlock the mutex previously held.

Signed-off-by: Rasesh Mody <rasesh.mody@cavium.com>
drivers/net/qede/base/ecore_vf.c

index 97ed0b7..e84f97a 100644 (file)
@@ -237,10 +237,8 @@ static enum _ecore_status_t ecore_vf_pf_acquire(struct ecore_hwfn *p_hwfn)
                /* send acquire request */
                rc = ecore_send_msg2pf(p_hwfn,
                                       &resp->hdr.status, sizeof(*resp));
-
-               /* PF timeout */
-               if (rc)
-                       return rc;
+               if (rc != ECORE_SUCCESS)
+                       goto exit;
 
                /* copy acquire response from buffer to p_hwfn */
                OSAL_MEMCPY(&p_iov->acquire_resp,