eal: create runtime dir even when shared data is not used

When multi-process is not wanted and DPDK is run with the "no-shconf"
flag, the telemetry library still needs a runtime directory to place the
unix socket for telemetry connections. Therefore, rather than not
creating the directory when this flag is set, we can change the code to
attempt the creation anyway, but not error out if it fails. If it
succeeds, then telemetry will be available, but if it fails, the rest of
DPDK will run without telemetry. This ensures that the "in-memory" flag
will allow DPDK to run even if the whole filesystem is read-only, for
example.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Reviewed-by: Morten Brørup <mb@smartsharesystems.com>
Reviewed-by: David Marchand <david.marchand@redhat.com>

diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c
index f4d1676754948cf95bc680deebbeded6249d40be..6cee5ae369db8af7f7c363acca58bfd7ed0a45c5 100644 (file)
--- a/lib/eal/freebsd/eal.c
+++ b/lib/eal/freebsd/eal.c
@@ -575,12 +575,14 @@ eal_parse_args(int argc, char **argv)
                }
        }
 
-       /* create runtime data directory */
-       if (internal_conf->no_shconf == 0 &&
-                       eal_create_runtime_dir() < 0) {
-               RTE_LOG(ERR, EAL, "Cannot create runtime directory\n");
-               ret = -1;
-               goto out;
+       /* create runtime data directory. In no_shconf mode, skip any errors */
+       if (eal_create_runtime_dir() < 0) {
+               if (internal_conf->no_shconf == 0) {
+                       RTE_LOG(ERR, EAL, "Cannot create runtime directory\n");
+                       ret = -1;
+                       goto out;
+               } else
+                       RTE_LOG(WARNING, EAL, "No DPDK runtime directory created\n");
        }
 
        if (eal_adjust_config(internal_conf) != 0) {

diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c
index ba19fc6347eb1bdc37ba402f7d8d2feb27f3c5b4..3577eaeaa4f47794ede24ab552e04364b48eb88d 100644 (file)
--- a/lib/eal/linux/eal.c
+++ b/lib/eal/linux/eal.c
@@ -838,12 +838,14 @@ eal_parse_args(int argc, char **argv)
                }
        }
 
-       /* create runtime data directory */
-       if (internal_conf->no_shconf == 0 &&
-                       eal_create_runtime_dir() < 0) {
-               RTE_LOG(ERR, EAL, "Cannot create runtime directory\n");
-               ret = -1;
-               goto out;
+       /* create runtime data directory. In no_shconf mode, skip any errors */
+       if (eal_create_runtime_dir() < 0) {
+               if (internal_conf->no_shconf == 0) {
+                       RTE_LOG(ERR, EAL, "Cannot create runtime directory\n");
+                       ret = -1;
+                       goto out;
+               } else
+                       RTE_LOG(WARNING, EAL, "No DPDK runtime directory created\n");
        }
 
        if (eal_adjust_config(internal_conf) != 0) {