net/hns3: fix configuring illegal VLAN PVID
authorMin Hu (Connor) <humin29@huawei.com>
Tue, 17 Mar 2020 09:12:05 +0000 (17:12 +0800)
committerFerruh Yigit <ferruh.yigit@intel.com>
Tue, 21 Apr 2020 11:57:04 +0000 (13:57 +0200)
The VLAN pvid ranges from 0 to 4095. The hns3 PMD driver does not
support this situation that the VLAN pvid is larger than Maximum VLAN
ID(4095).

Fixes: 411d23b9eafb ("net/hns3: support VLAN")
Cc: stable@dpdk.org
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
Signed-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>
drivers/net/hns3/hns3_ethdev.c

index fe6b21f..a715354 100644 (file)
@@ -873,6 +873,12 @@ hns3_vlan_pvid_set(struct rte_eth_dev *dev, uint16_t pvid, int on)
        struct hns3_hw *hw = &hns->hw;
        int ret;
 
+       if (pvid > RTE_ETHER_MAX_VLAN_ID) {
+               hns3_err(hw, "Invalid vlan_id = %u > %d", pvid,
+                        RTE_ETHER_MAX_VLAN_ID);
+               return -EINVAL;
+       }
+
        rte_spinlock_lock(&hw->lock);
        ret = hns3_vlan_pvid_configure(hns, pvid, on);
        rte_spinlock_unlock(&hw->lock);