app/test: enhance power manager unit tests

Unit Testcases are added for power_acpi_cpu_freq,
power_kvm_vm_test to improve coverage

Signed-off-by: Jananee Parthasarathy <jananeex.m.parthasarathy@intel.com>
Acked-by: David Hunt <david.hunt@intel.com>

diff --git a/test/test/test_power_acpi_cpufreq.c b/test/test/test_power_acpi_cpufreq.c
index 3bfd033..8da2dcc 100644 (file)
--- a/test/test/test_power_acpi_cpufreq.c
+++ b/test/test/test_power_acpi_cpufreq.c
@@ -27,7 +27,7 @@ test_power_acpi_cpufreq(void)
 #define TEST_POWER_FREQS_NUM_MAX ((unsigned)RTE_MAX_LCORE_FREQS)
 
 #define TEST_POWER_SYSFILE_CUR_FREQ \
-       "/sys/devices/system/cpu/cpu%u/cpufreq/scaling_cur_freq"
+       "/sys/devices/system/cpu/cpu%u/cpufreq/cpuinfo_cur_freq"
 
 static uint32_t total_freq_num;
 static uint32_t freqs[TEST_POWER_FREQS_NUM_MAX];

diff --git a/test/test/test_power_kvm_vm.c b/test/test/test_power_kvm_vm.c
index 91b31c4..2ac7491 100644 (file)
--- a/test/test/test_power_kvm_vm.c
+++ b/test/test/test_power_kvm_vm.c
@@ -25,12 +25,17 @@ test_power_kvm_vm(void)
 #define TEST_POWER_VM_LCORE_ID            0U
 #define TEST_POWER_VM_LCORE_OUT_OF_BOUNDS (RTE_MAX_LCORE+1)
 #define TEST_POWER_VM_LCORE_INVALID       1U
+#define TEMP_POWER_MANAGER_FILE_PATH  "/tmp/testpm"
+
+int guest_channel_host_connect(const char *path, unsigned int lcore_id);
 
 static int
 test_power_kvm_vm(void)
 {
        int ret;
        enum power_management_env env;
+       char fPath[PATH_MAX];
+       FILE *fPtr = NULL;
 
        ret = rte_power_set_env(PM_ENV_KVM_VM);
        if (ret != 0) {
@@ -95,12 +100,31 @@ test_power_kvm_vm(void)
        /* Test initialisation of a valid lcore */
        ret = rte_power_init(TEST_POWER_VM_LCORE_ID);
        if (ret < 0) {
-               printf("Cannot initialise power management for lcore %u, this "
-                               "may occur if environment is not configured "
-                               "correctly(KVM VM) or operating in another valid "
-                               "Power management environment\n", TEST_POWER_VM_LCORE_ID);
-               rte_power_unset_env();
-               return -1;
+               printf("rte_power_init failed as expected in host\n");
+               /* This test would be successful when run on VM,
+                * in order to run in Host itself, temporary file path
+                * is created and same is used for further communication
+                */
+
+               snprintf(fPath, PATH_MAX, "%s.%u",
+                       TEMP_POWER_MANAGER_FILE_PATH, TEST_POWER_VM_LCORE_ID);
+               fPtr = fopen(fPath, "w");
+               if (fPtr == NULL) {
+                       printf(" Unable to create file\n");
+                       rte_power_unset_env();
+                       return -1;
+               }
+               ret = guest_channel_host_connect(TEMP_POWER_MANAGER_FILE_PATH,
+                       TEST_POWER_VM_LCORE_ID);
+               if (ret == 0)
+                       printf("guest_channel_host_connect successful\n");
+               else {
+                       printf("guest_channel_host_connect failed\n");
+                       rte_power_unset_env();
+                       fclose(fPtr);
+                       remove(fPath);
+                       return -1;
+               }
        }
 
        /* Test initialisation of previously initialised lcore */
@@ -175,6 +199,22 @@ test_power_kvm_vm(void)
                goto fail_all;
        }
 
+       /* Test KVM_VM Enable Turbo of valid core */
+       ret = rte_power_freq_enable_turbo(TEST_POWER_VM_LCORE_ID);
+       if (ret == -1) {
+               printf("rte_power_freq_enable_turbo failed on valid lcore"
+                       "%u\n", TEST_POWER_VM_LCORE_ID);
+               goto fail_all;
+       }
+
+       /* Test KVM_VM Disable Turbo of valid core */
+       ret = rte_power_freq_disable_turbo(TEST_POWER_VM_LCORE_ID);
+       if (ret == -1) {
+               printf("rte_power_freq_disable_turbo failed on valid lcore"
+               "%u\n", TEST_POWER_VM_LCORE_ID);
+               goto fail_all;
+       }
+
        /* Test frequency up of valid lcore */
        ret = rte_power_freq_up(TEST_POWER_VM_LCORE_ID);
        if (ret != 1) {
@@ -274,10 +314,18 @@ test_power_kvm_vm(void)
                return -1;
        }
        rte_power_unset_env();
+       if (fPtr != NULL) {
+               fclose(fPtr);
+               remove(fPath);
+       }
        return 0;
 fail_all:
        rte_power_exit(TEST_POWER_VM_LCORE_ID);
        rte_power_unset_env();
+       if (fPtr != NULL) {
+               fclose(fPtr);
+               remove(fPath);
+       }
        return -1;
 }
 #endif