eal: set affinity for control threads
authorOlivier Matz <olivier.matz@6wind.com>
Tue, 24 Apr 2018 14:46:50 +0000 (16:46 +0200)
committerThomas Monjalon <thomas@monjalon.net>
Tue, 24 Apr 2018 22:51:31 +0000 (00:51 +0200)
The management threads must not bother the dataplane or service cores.
Set the affinity of these threads accordingly.

Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
Reviewed-by: Anatoly Burakov <anatoly.burakov@intel.com>
lib/librte_eal/common/eal_common_thread.c
lib/librte_eal/common/include/rte_lcore.h

index 94d2a6e..4e75cb8 100644 (file)
@@ -16,6 +16,7 @@
 #include <rte_memory.h>
 #include <rte_log.h>
 
+#include "eal_private.h"
 #include "eal_thread.h"
 
 RTE_DECLARE_PER_LCORE(unsigned , _socket_id);
@@ -169,7 +170,9 @@ rte_ctrl_thread_create(pthread_t *thread, const char *name,
                .start_routine = start_routine,
                .arg = arg,
        };
-       int ret;
+       unsigned int lcore_id;
+       rte_cpuset_t cpuset;
+       int cpu_found, ret;
 
        pthread_barrier_init(&params.configured, NULL, 2);
 
@@ -183,6 +186,23 @@ rte_ctrl_thread_create(pthread_t *thread, const char *name,
                        goto fail;
        }
 
+       cpu_found = 0;
+       CPU_ZERO(&cpuset);
+       for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) {
+               if (eal_cpu_detected(lcore_id) &&
+                               rte_lcore_has_role(lcore_id, ROLE_OFF)) {
+                       CPU_SET(lcore_id, &cpuset);
+                       cpu_found = 1;
+               }
+       }
+       /* if no detected cpu is off, use master core */
+       if (!cpu_found)
+               CPU_SET(rte_get_master_lcore(), &cpuset);
+
+       ret = pthread_setaffinity_np(*thread, sizeof(cpuset), &cpuset);
+       if (ret < 0)
+               goto fail;
+
        pthread_barrier_wait(&params.configured);
 
        return 0;
index eb39c2a..334a062 100644 (file)
@@ -279,7 +279,9 @@ int rte_thread_setname(pthread_t id, const char *name);
 /**
  * Create a control thread.
  *
- * Wrapper to pthread_create() and pthread_setname_np().
+ * Wrapper to pthread_create(), pthread_setname_np() and
+ * pthread_setaffinity_np(). The dataplane and service lcores are
+ * excluded from the affinity of the new thread.
  *
  * @param thread
  *   Filled with the thread id of the new created thread.