]> git.droids-corp.org - dpdk.git/commitdiff
vhost: differentiate IOTLB logs
authorMaxime Coquelin <maxime.coquelin@redhat.com>
Wed, 26 Jan 2022 09:55:09 +0000 (10:55 +0100)
committerChenbo Xia <chenbo.xia@intel.com>
Thu, 27 Jan 2022 08:45:55 +0000 (09:45 +0100)
Same logging messages were used for both IOTLB cache
insertion failure and IOTLB pending insertion failure.

This patch differentiate them to ease logs analysis.

Suggested-by: David Marchand <david.marchand@redhat.com>
Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>
Reviewed-by: David Marchand <david.marchand@redhat.com>
lib/vhost/iotlb.c

index afa86d7c2bb46ab40ed95704aaa4c714e0753482..b24202a7eba3ac92340ac2543d7f38451a6e4d82 100644 (file)
@@ -70,7 +70,8 @@ vhost_user_iotlb_pending_insert(struct virtio_net *dev, struct vhost_virtqueue *
 
        ret = rte_mempool_get(vq->iotlb_pool, (void **)&node);
        if (ret) {
-               VHOST_LOG_CONFIG(DEBUG, "(%s) IOTLB pool %s empty, clear entries\n",
+               VHOST_LOG_CONFIG(DEBUG,
+                               "(%s) IOTLB pool %s empty, clear entries for pending insertion\n",
                                dev->ifname, vq->iotlb_pool->name);
                if (!TAILQ_EMPTY(&vq->iotlb_pending_list))
                        vhost_user_iotlb_pending_remove_all(vq);
@@ -78,7 +79,8 @@ vhost_user_iotlb_pending_insert(struct virtio_net *dev, struct vhost_virtqueue *
                        vhost_user_iotlb_cache_random_evict(vq);
                ret = rte_mempool_get(vq->iotlb_pool, (void **)&node);
                if (ret) {
-                       VHOST_LOG_CONFIG(ERR, "(%s) IOTLB pool %s still empty, failure\n",
+                       VHOST_LOG_CONFIG(ERR,
+                                       "(%s) IOTLB pool %s still empty, pending insertion failure\n",
                                        dev->ifname, vq->iotlb_pool->name);
                        return;
                }
@@ -167,7 +169,8 @@ vhost_user_iotlb_cache_insert(struct virtio_net *dev, struct vhost_virtqueue *vq
 
        ret = rte_mempool_get(vq->iotlb_pool, (void **)&new_node);
        if (ret) {
-               VHOST_LOG_CONFIG(DEBUG, "(%s) IOTLB pool %s empty, clear entries\n",
+               VHOST_LOG_CONFIG(DEBUG,
+                               "(%s) IOTLB pool %s empty, clear entries for cache insertion\n",
                                dev->ifname, vq->iotlb_pool->name);
                if (!TAILQ_EMPTY(&vq->iotlb_list))
                        vhost_user_iotlb_cache_random_evict(vq);
@@ -175,7 +178,8 @@ vhost_user_iotlb_cache_insert(struct virtio_net *dev, struct vhost_virtqueue *vq
                        vhost_user_iotlb_pending_remove_all(vq);
                ret = rte_mempool_get(vq->iotlb_pool, (void **)&new_node);
                if (ret) {
-                       VHOST_LOG_CONFIG(ERR, "(%s) IOTLB pool %s still empty, failure\n",
+                       VHOST_LOG_CONFIG(ERR,
+                                       "(%s) IOTLB pool %s still empty, cache insertion failed\n",
                                        dev->ifname, vq->iotlb_pool->name);
                        return;
                }