vfio: expand non-viable group error message
authorKevin Traynor <ktraynor@redhat.com>
Fri, 26 Apr 2019 16:22:30 +0000 (17:22 +0100)
committerThomas Monjalon <thomas@monjalon.net>
Fri, 3 May 2019 20:42:30 +0000 (22:42 +0200)
"VFIO group is not viable" error message is correct
but not very user friendly for something which can
usually be easily rectified.

Add some additional text to give more of a hint.

Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
Reviewed-by: Rami Rosen <ramirose@gmail.com>
lib/librte_eal/linux/eal/eal_vfio.c

index 19e70bb..6892a2c 100644 (file)
@@ -685,7 +685,9 @@ rte_vfio_setup_device(const char *sysfs_base, const char *dev_addr,
                rte_vfio_clear_group(vfio_group_fd);
                return -1;
        } else if (!(group_status.flags & VFIO_GROUP_FLAGS_VIABLE)) {
-               RTE_LOG(ERR, EAL, "  %s VFIO group is not viable!\n", dev_addr);
+               RTE_LOG(ERR, EAL, "  %s VFIO group is not viable! "
+                               "Not all devices in IOMMU group bound to VFIO or unbound\n",
+                               dev_addr);
                close(vfio_group_fd);
                rte_vfio_clear_group(vfio_group_fd);
                return -1;