devtools: fix config check when building tags
authorBruce Richardson <bruce.richardson@intel.com>
Wed, 13 Mar 2019 15:09:58 +0000 (15:09 +0000)
committerThomas Monjalon <thomas@monjalon.net>
Tue, 26 Mar 2019 23:56:34 +0000 (00:56 +0100)
The check for a valid configuration in build-tags.sh relied on the output
of "make showconfig" rather than checking directly for a config file of
that name. This broke when as part of the rename of the linuxapp/bsdapp
configs to just linux/freebsd, as we stopped advertising the old names
even if they worked. Changing the code to just look for the config
file by name fixes this issue while shortening the code too.

Fixes: 218c4e68c1d9 ("mk: use linux and freebsd in config names")
Fixes: aafaea3d3b70 ("devtools: add tags and cscope index generation")

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Tested-by: Ferruh Yigit <ferruh.yigit@intel.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
devtools/build-tags.sh

index 753e4c2..d395da4 100755 (executable)
@@ -129,14 +129,7 @@ ppc_64_sources()
 
 check_valid_target()
 {
-       cfgfound=false
-       allconfigs=$(make showconfigs)
-       for cfg in $allconfigs ; do
-               if [ "$cfg" = "$1" ] ; then
-                       cfgfound=true
-               fi
-       done
-       if ! $cfgfound ; then
+       if [ ! -f "config/defconfig_$1" ] ; then
                echo "Invalid config: $1"
                print_usage
                exit 0