net/bonding: fix link speed update in broadcast mode
authorIgor Romanov <igor.romanov@oktetlabs.ru>
Tue, 10 Sep 2019 08:25:41 +0000 (09:25 +0100)
committerFerruh Yigit <ferruh.yigit@intel.com>
Mon, 7 Oct 2019 13:00:54 +0000 (15:00 +0200)
Fix the issue that the link speed of the bond device was set to the
link speed of the first active slave in broadcast mode.

Set the link speed of the bond device to the minimum value across
all of the slaves in that case.

Fixes: deba8a2f8b0b ("net/bonding: fix link properties management")
Cc: stable@dpdk.org
Signed-off-by: Igor Romanov <igor.romanov@oktetlabs.ru>
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
Acked-by: Chas Williams <chas3@att.com>
drivers/net/bonding/rte_eth_bond_pmd.c

index 5ff9fcb..4c517e6 100644 (file)
@@ -2395,8 +2395,8 @@ bond_ethdev_link_update(struct rte_eth_dev *ethdev, int wait_to_complete)
                 * packet loss will occur on this slave if transmission at rates
                 * greater than this are attempted
                 */
-               for (idx = 1; idx < bond_ctx->active_slave_count; idx++) {
-                       link_update(bond_ctx->active_slaves[0], &slave_link);
+               for (idx = 0; idx < bond_ctx->active_slave_count; idx++) {
+                       link_update(bond_ctx->active_slaves[idx], &slave_link);
 
                        if (slave_link.link_speed <
                                        ethdev->data->dev_link.link_speed)