event/dpaa2: fix dereference before null check

Coverity flags that 'portal' variable is used before
it's checked for NULL. This patch fixes this issue.

Coverity issue: 323516
Fixes: 4ab57b042e7c ("event/dpaa2: affine portal at runtime during I/O")
Cc: stable@dpdk.org
Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
Acked-by: Nipun Gupta <nipun.gupta@nxp.com>

diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/drivers/event/dpaa2/dpaa2_eventdev.c
index 3ae4441..f7383ca 100644 (file)
--- a/drivers/event/dpaa2/dpaa2_eventdev.c
+++ b/drivers/event/dpaa2/dpaa2_eventdev.c
@@ -569,14 +569,14 @@ dpaa2_eventdev_port_release(void *port)
 
        EVENTDEV_INIT_FUNC_TRACE();
 
+       if (portal == NULL)
+               return;
+
        /* TODO: Cleanup is required when ports are in linked state. */
        if (portal->is_port_linked)
                DPAA2_EVENTDEV_WARN("Event port must be unlinked before release");
 
-       if (portal)
-               rte_free(portal);
-
-       portal = NULL;
+       rte_free(portal);
 }
 
 static int