net/cxgbe/base: initialize variable before reading EEPROM
authorEmmanuel Roullit <emmanuel.roullit@gmail.com>
Tue, 24 Jan 2017 20:48:57 +0000 (21:48 +0100)
committerFerruh Yigit <ferruh.yigit@intel.com>
Mon, 30 Jan 2017 21:18:26 +0000 (22:18 +0100)
data value could have been garbage if VPD access timed out for VPD read
request could not been issued.

Found with clang static analysis:
drivers/net/cxgbe/base/t4_hw.c:1577:22:
warning: The left operand of '&' is a garbage value
        } while ((stats_reg & 0x1) && --max_poll);
                  ~~~~~~~~~ ^

Fixes: fe0bd9ee5da3 ("net/cxgbe: support EEPROM access")
Cc: stable@dpdk.org
Signed-off-by: Emmanuel Roullit <emmanuel.roullit@gmail.com>
drivers/net/cxgbe/base/t4_hw.c

index 7e79adf..c089b06 100644 (file)
@@ -1532,7 +1532,7 @@ int t4_seeprom_write(struct adapter *adapter, u32 addr, u32 data)
 {
        unsigned int base = adapter->params.pci.vpd_cap_addr;
        int ret;
-       u32 stats_reg;
+       u32 stats_reg = 0;
        int max_poll;
 
        /* VPD Accesses must alway be 4-byte aligned!