net/dpaa2: fix bad check for not-null
authorHemant Agrawal <hemant.agrawal@nxp.com>
Fri, 11 Jan 2019 12:24:16 +0000 (12:24 +0000)
committerFerruh Yigit <ferruh.yigit@intel.com>
Mon, 14 Jan 2019 16:44:29 +0000 (17:44 +0100)
The check !dpaa2->cscn is not correct to check non-null value.

Fixes: 5d9a1e4d23fe ("net/dpaa2: enhance queue memory cleanup")
Cc: stable@dpdk.org
Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
drivers/net/dpaa2/dpaa2_ethdev.c

index fa71807..8d4ea1b 100644 (file)
@@ -311,8 +311,7 @@ dpaa2_free_rx_tx_queues(struct rte_eth_dev *dev)
                /* cleanup tx queue cscn */
                for (i = 0; i < priv->nb_tx_queues; i++) {
                        dpaa2_q = (struct dpaa2_queue *)priv->tx_vq[i];
-                       if (!dpaa2_q->cscn)
-                               rte_free(dpaa2_q->cscn);
+                       rte_free(dpaa2_q->cscn);
                }
                /*free memory for all queues (RX+TX) */
                rte_free(priv->rx_vq[0]);