]> git.droids-corp.org - dpdk.git/commitdiff
eal/linux: fix uninitialized data valgrind warning
authorStephen Hemminger <stephen@networkplumber.org>
Wed, 27 Nov 2019 22:32:32 +0000 (14:32 -0800)
committerDavid Marchand <david.marchand@redhat.com>
Wed, 4 Dec 2019 09:05:05 +0000 (10:05 +0100)
Valgrind reports that eal interrupt thread is calling epoll_ctl
with uninitialized data.
This is a false positive, because the kernel is not going to care about
the unused bits in the union but trivial to fix by initializing it.

Fixes: af75078fece3 ("first public release")
Cc: stable@dpdk.org
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: David Marchand <david.marchand@redhat.com>
lib/librte_eal/linux/eal/eal_interrupts.c

index 1955324d3045945954a47d86ecd7111bff10a3be..2cd537ba44927de8c9fd4803961154e7de1003c5 100644 (file)
@@ -1045,7 +1045,7 @@ eal_intr_handle_interrupts(int pfd, unsigned totalfds)
 static __attribute__((noreturn)) void *
 eal_intr_thread_main(__rte_unused void *arg)
 {
-       struct epoll_event ev;
+       struct epoll_event ev = { };
 
        /* host thread, never break out */
        for (;;) {