]> git.droids-corp.org - dpdk.git/commitdiff
net/mlx5: fix shared RSS destroy
authorRongwei Liu <rongweil@nvidia.com>
Wed, 2 Mar 2022 11:19:38 +0000 (13:19 +0200)
committerRaslan Darawsheh <rasland@nvidia.com>
Mon, 7 Mar 2022 10:43:07 +0000 (11:43 +0100)
When both shared and non-shared RSS actions are present in single
flow rule shared RSS index is unset by mistake.

For example:
1. flow indirect_action 0 create action_id 3 ingress action RSS ...
2. set sample_actions 0 mark id 43690 / queue index 0 / end
3. flow create 0 ingress group 107 pattern eth / sample ratio 2
   index 0  / indirect 3 / end

PMD translates the indirect action to a shared RSS description at first.
In the split prefix flow, RSS->shared_RSS is unset when translating
sample queue action, the subfix flow will treat the RSS as non-shared.

Fixes: 8e61555657b2 ("net/mlx5: fix shared RSS and mark actions combination")
Cc: stable@dpdk.org
Signed-off-by: Rongwei Liu <rongweil@nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
drivers/net/mlx5/mlx5_flow_dv.c

index 7a7591144a516ca1aa559ea261abb4c71a2813c9..ebd0a427f36d4deeddc08a397b3724cd188a0a8f 100644 (file)
@@ -11206,6 +11206,7 @@ flow_dv_hrxq_prepare(struct rte_eth_dev *dev,
                     uint32_t *hrxq_idx)
 {
        struct mlx5_flow_handle *dh = dev_flow->handle;
+       uint32_t shared_rss = rss_desc->shared_rss;
        struct mlx5_hrxq *hrxq;
 
        MLX5_ASSERT(rss_desc->queue_num);
@@ -11217,6 +11218,7 @@ flow_dv_hrxq_prepare(struct rte_eth_dev *dev,
                rss_desc->queue_num = 1;
        hrxq = mlx5_hrxq_get(dev, rss_desc);
        *hrxq_idx = hrxq ? hrxq->idx : 0;
+       rss_desc->shared_rss = shared_rss;
        return hrxq;
 }