]> git.droids-corp.org - dpdk.git/commitdiff
net/ipn3ke: fix xstats get return if xstats is null
authorChengwen Feng <fengchengwen@huawei.com>
Fri, 13 May 2022 02:53:52 +0000 (10:53 +0800)
committerAndrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Fri, 20 May 2022 14:45:44 +0000 (16:45 +0200)
Many user (e.g. telemetry) invokes rte_eth_xstats_get(port_id, NULL, 0)
to retrieve the required number of elements, but currently ipn3ke PMD
returns zero when xstats is null.

Dedicated check for xstats vs null is not required, since ethdev layer
guarantees that it may be null only if number of entries n is 0 (which
is definitely smaller than total xstats count).

Fixes: 5a6d883878db ("net/ipn3ke: implement statistics")
Cc: stable@dpdk.org
Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
Acked-by: Morten Brørup <mb@smartsharesystems.com>
Reviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
drivers/net/ipn3ke/ipn3ke_representor.c

index c9dde1d82ed40d120477cd1faaed2fe197fefbe5..abbecfdf2e2a866c6d7a679b5b798667f7df2a5e 100644 (file)
@@ -2218,9 +2218,6 @@ ipn3ke_rpst_xstats_get
        struct ipn3ke_rpst_hw_port_stats hw_stats;
        struct rte_eth_stats stats;
 
-       if (!xstats)
-               return 0;
-
        if (!ethdev) {
                IPN3KE_AFU_PMD_ERR("ethernet device to get statistics is NULL");
                return -EINVAL;