net/iavf: fix RSS hash update
authorWenjun Wu <wenjun1.wu@intel.com>
Mon, 15 Mar 2021 00:59:53 +0000 (08:59 +0800)
committerQi Zhang <qi.z.zhang@intel.com>
Wed, 24 Mar 2021 11:56:54 +0000 (12:56 +0100)
This patch change judgment statements to disable RSS for vf
when users need to disable RSS or RSS hash function configured
is not supported.

Fixes: 95f2f0e9fc2a ("net/iavf: improve default RSS")
Cc: stable@dpdk.org
Signed-off-by: Wenjun Wu <wenjun1.wu@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
drivers/net/iavf/iavf_ethdev.c

index 4d37722..8610efb 100644 (file)
@@ -1250,8 +1250,17 @@ iavf_dev_rss_hash_update(struct rte_eth_dev *dev,
        if (ret)
                return ret;
 
-       if (rss_conf->rss_hf == 0)
+       if (rss_conf->rss_hf == 0) {
+               vf->rss_hf = 0;
+               ret = iavf_set_hena(adapter, 0);
+
+               /* It is a workaround, temporarily allow error to be returned
+                * due to possible lack of PF handling for hena = 0.
+                */
+               if (ret)
+                       PMD_DRV_LOG(WARNING, "fail to clean existing RSS, lack PF support");
                return 0;
+       }
 
        if (vf->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_ADV_RSS_PF) {
                /* Clear existing RSS. */