power: fix frequency list buffer validation
authorKevin Traynor <ktraynor@redhat.com>
Wed, 6 Feb 2019 12:19:06 +0000 (12:19 +0000)
committerThomas Monjalon <thomas@monjalon.net>
Fri, 29 Mar 2019 13:58:27 +0000 (14:58 +0100)
The frequency list buffer was already validated in
power_acpi_cpufreq_freqs(), so the newly added check was redundant.
To keep consistency with power_pstate_cpufreq_freqs(), remove the
original check and update the log message.

Fixes: 2e6ccdb4e088 ("power: fix frequency list to handle null buffer")
Cc: stable@dpdk.org
Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
lib/librte_power/power_acpi_cpufreq.c

index 45412f0..534efe8 100644 (file)
@@ -440,8 +440,8 @@ power_acpi_cpufreq_freqs(unsigned int lcore_id, uint32_t *freqs, uint32_t num)
 {
        struct rte_power_info *pi;
 
-       if (lcore_id >= RTE_MAX_LCORE || !freqs) {
-               RTE_LOG(ERR, POWER, "Invalid input parameter\n");
+       if (lcore_id >= RTE_MAX_LCORE) {
+               RTE_LOG(ERR, POWER, "Invalid lcore ID\n");
                return 0;
        }