app/compress-perf: fix improper use of negative value
authorTomasz Jozwiak <tomaszx.jozwiak@intel.com>
Mon, 20 May 2019 13:26:03 +0000 (15:26 +0200)
committerAkhil Goyal <akhil.goyal@nxp.com>
Fri, 5 Jul 2019 12:52:25 +0000 (14:52 +0200)
test_data->input_data_sz is passed to a parameter that
cannot be negative.

Coverity issue: 328504
Fixes: b68a82425da4 ("app/compress-perf: add performance measurement")
Cc: stable@dpdk.org
Signed-off-by: Tomasz Jozwiak <tomaszx.jozwiak@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
app/test-compress-perf/main.c

index c2a45d1..5a579ea 100644 (file)
@@ -244,7 +244,8 @@ comp_perf_dump_input_data(struct comp_test_data *test_data)
        if (test_data->input_data_sz == 0)
                test_data->input_data_sz = actual_file_sz;
 
-       if (fseek(f, 0, SEEK_SET) != 0) {
+       if (test_data->input_data_sz <= 0 || actual_file_sz <= 0 ||
+                       fseek(f, 0, SEEK_SET) != 0) {
                RTE_LOG(ERR, USER1, "Size of input could not be calculated\n");
                goto end;
        }