mem: fix division by zero in no-NUMA mode
authorAnatoly Burakov <anatoly.burakov@intel.com>
Mon, 26 Nov 2018 10:57:03 +0000 (10:57 +0000)
committerThomas Monjalon <thomas@monjalon.net>
Mon, 26 Nov 2018 14:35:46 +0000 (15:35 +0100)
When RTE_EAL_NUMA_AWARE_HUGEPAGES is set to "n", not all memtypes
will be valid, because we skip some due to not supporting other
NUMA nodes, leading to a division by zero error down the line
because the necessary memtype fields weren't populated.

Fix it by limiting number of memtypes to number of memtypes we
have actually created.

Fixes: 1dd342d0fdc4 ("mem: improve segment list preallocation")
Cc: stable@dpdk.org
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
Tested-by: David Hunt <david.hunt@intel.com>
lib/librte_eal/linuxapp/eal/eal_memory.c

index 6f94621..32feb41 100644 (file)
@@ -2230,6 +2230,8 @@ memseg_primary_init(void)
                                socket_id, hugepage_sz);
                }
        }
+       /* number of memtypes could have been lower due to no NUMA support */
+       n_memtypes = cur_type;
 
        /* set up limits for types */
        max_mem = (uint64_t)RTE_MAX_MEM_MB << 20;