eal/windows: fix data race when creating threads

eal_thread_loop() uses lcore_config[i].thread_id,
which is stored upon the return from CreateThread().
Per documentation, eal_thread_loop() can start
before CreateThread() returns and the ID is stored.

Create lcore worker threads suspended and then subsequently resume to
allow &lcore_config[i].thread_id be stored before eal_thread_loop
execution.

Fixes: 53ffd9f080fc ("eal/windows: add minimum viable code")
Cc: stable@dpdk.org
Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>

diff --git a/lib/eal/windows/eal_thread.c b/lib/eal/windows/eal_thread.c
index 54fa93fa62157282035b662549927fdfbf19300b..ff84cb42afd31f74bdd536d4a46ce235bd01fb15 100644 (file)
--- a/lib/eal/windows/eal_thread.c
+++ b/lib/eal/windows/eal_thread.c
@@ -150,13 +150,18 @@ eal_thread_create(pthread_t *thread)
 
        th = CreateThread(NULL, 0,
                (LPTHREAD_START_ROUTINE)(ULONG_PTR)eal_thread_loop,
-                                               NULL, 0, (LPDWORD)thread);
+                                               NULL, CREATE_SUSPENDED, (LPDWORD)thread);
        if (!th)
                return -1;
 
        SetPriorityClass(GetCurrentProcess(), NORMAL_PRIORITY_CLASS);
        SetThreadPriority(th, THREAD_PRIORITY_NORMAL);
 
+       if (ResumeThread(th) == (DWORD)-1) {
+               (void)CloseHandle(th);
+               return -1;
+       }
+
        return 0;
 }