net/af_xdp: mark recvfrom return as ignored
authorCiara Loftus <ciara.loftus@intel.com>
Thu, 25 Mar 2021 08:22:09 +0000 (08:22 +0000)
committerFerruh Yigit <ferruh.yigit@intel.com>
Tue, 30 Mar 2021 13:50:04 +0000 (15:50 +0200)
Coverity complains that the return value of recvfrom() in the AF_XDP
datapath is not checked. We don't care about the return value because in
the case of an error we still return 0 from the receive function to
indicate no packets were received. So to make Coverity happy we cast the
return to 'void'.

Coverity issue: 369671
Fixes: 63e8989fe5a4 ("net/af_xdp: use recvfrom instead of poll syscall")

Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
drivers/net/af_xdp/rte_eth_af_xdp.c

index a64fef1..6e44a21 100644 (file)
@@ -274,7 +274,7 @@ af_xdp_rx_zc(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
 
        if (nb_pkts == 0) {
                if (syscall_needed(&rxq->fq, rxq->busy_budget))
-                       recvfrom(xsk_socket__fd(rxq->xsk), NULL, 0,
+                       (void)recvfrom(xsk_socket__fd(rxq->xsk), NULL, 0,
                                MSG_DONTWAIT, NULL, NULL);
 
                return 0;
@@ -346,7 +346,7 @@ af_xdp_rx_cp(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
        if (nb_pkts == 0) {
 #if defined(XDP_USE_NEED_WAKEUP)
                if (xsk_ring_prod__needs_wakeup(fq))
-                       recvfrom(xsk_socket__fd(rxq->xsk), NULL, 0,
+                       (void)recvfrom(xsk_socket__fd(rxq->xsk), NULL, 0,
                                MSG_DONTWAIT, NULL, NULL);
 #endif
                return 0;