net/bnxt: fix configuring LRO
authorKalesh AP <kalesh-anakkur.purayil@broadcom.com>
Fri, 2 Apr 2021 03:25:51 +0000 (08:55 +0530)
committerAjit Khaparde <ajit.khaparde@broadcom.com>
Wed, 7 Apr 2021 02:56:43 +0000 (04:56 +0200)
While configuring LRO, driver should check the return value
of bnxt_hwrm_vnic_tpa_cfg() HWRM command and return error
when the FW command fails.

Fixes: 0958d8b6435d ("net/bnxt: support LRO")
Cc: stable@dpdk.org
Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
drivers/net/bnxt/bnxt_ethdev.c

index 02fe000..20ca57e 100644 (file)
@@ -479,10 +479,11 @@ static int bnxt_setup_one_vnic(struct bnxt *bp, uint16_t vnic_id)
 
        bnxt_hwrm_vnic_plcmode_cfg(bp, vnic);
 
-       if (rx_offloads & DEV_RX_OFFLOAD_TCP_LRO)
-               bnxt_hwrm_vnic_tpa_cfg(bp, vnic, 1);
-       else
-               bnxt_hwrm_vnic_tpa_cfg(bp, vnic, 0);
+       rc = bnxt_hwrm_vnic_tpa_cfg(bp, vnic,
+                                   (rx_offloads & DEV_RX_OFFLOAD_TCP_LRO) ?
+                                   true : false);
+       if (rc)
+               goto err_out;
 
        return 0;
 err_out: