eal: fix memory leak on control thread failure

params is not freed if pthread_create() fails. The fix is
straight-forward.

Fixes: 3d09a6e26d8b ("eal: fix threads block on barrier")
Reported-by: Olivier Matz <olivier.matz@6wind.com>
Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
Reviewed-by: Olivier Matz <olivier.matz@6wind.com>

diff --git a/lib/librte_eal/common/eal_common_thread.c b/lib/librte_eal/common/eal_common_thread.c
index de69452eb8548178b956f3542b6051e36e73309d..a2c05e40faa0a647781b45b01e7dbfae59f42821 100644 (file)
--- a/lib/librte_eal/common/eal_common_thread.c
+++ b/lib/librte_eal/common/eal_common_thread.c
@@ -178,8 +178,10 @@ rte_ctrl_thread_create(pthread_t *thread, const char *name,
        pthread_barrier_init(&params->configured, NULL, 2);
 
        ret = pthread_create(thread, attr, rte_thread_init, (void *)params);
-       if (ret != 0)
+       if (ret != 0) {
+               free(params);
                return ret;
+       }
 
        if (name != NULL) {
                ret = rte_thread_setname(*thread, name);