app/test: fix misplaced braces in strncmp
authorOlivier Matz <olivier.matz@6wind.com>
Wed, 17 Dec 2014 12:55:21 +0000 (13:55 +0100)
committerThomas Monjalon <thomas.monjalon@6wind.com>
Wed, 17 Dec 2014 23:26:08 +0000 (00:26 +0100)
One occurrence call to strncmp had the closing brace in the wrong
place. Changing this form:
if (strncmp(X, Y, sizeof(X) != 0))
which does a comparison of length 1, to
if (strncmp(X, Y, sizeof(X)) != 0)
which does the correct length comparison and then compares the result
to zero in the "if" part.

Seen with clang-3.5:
  "error: size argument in 'strncmp' call is a comparison"

This patch is similar to 261386248 but it looks that one occurrence
was forgotten.

Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
app/test/test_devargs.c

index dcbdd09..3d9f7bc 100644 (file)
@@ -105,7 +105,7 @@ test_devargs(void)
                devargs->pci.addr.devid != 0 ||
                devargs->pci.addr.function != 1)
                goto fail;
-       if (strncmp(devargs->args, "", sizeof(devargs->args) != 0))
+       if (strncmp(devargs->args, "", sizeof(devargs->args)) != 0)
                goto fail;
        free_devargs_list();