vhost: fix missing cache logging NUMA realloc

When the guest allocates virtqueues on a different NUMA node
than the one the Vhost metadata are allocated, both the Vhost
device struct and the virtqueues struct are reallocated.

However, reallocating the log cache on the new NUMA node was
not done. This patch fixes this by reallocating it if it has
been allocated already, which means a live-migration is
on-going.

Fixes: 1818a63147fb ("vhost: move dirty logging cache out of virtqueue")
Cc: stable@dpdk.org
Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>

diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c
index 5fb055ea2e154007f9612daf98e89cd6ef62c171..82adf80fe5e9e4835cb5965d5be0289c96b6f9c2 100644 (file)
--- a/lib/vhost/vhost_user.c
+++ b/lib/vhost/vhost_user.c
@@ -545,6 +545,16 @@ numa_realloc(struct virtio_net *dev, int index)
                        vq->batch_copy_elems = new_batch_copy_elems;
                }
 
+               if (vq->log_cache) {
+                       struct log_cache_entry *log_cache;
+
+                       log_cache = rte_realloc_socket(vq->log_cache,
+                                       sizeof(struct log_cache_entry) * VHOST_LOG_CACHE_NR,
+                                       0, newnode);
+                       if (log_cache)
+                               vq->log_cache = log_cache;
+               }
+
                rte_free(old_vq);
        }