test/lpm: remove unneeded checks in RCU perf tests
authorDharmik Thakkar <dharmik.thakkar@arm.com>
Wed, 4 Nov 2020 18:58:57 +0000 (12:58 -0600)
committerDavid Marchand <david.marchand@redhat.com>
Thu, 5 Nov 2020 15:01:06 +0000 (16:01 +0100)
Remove redundant error checking for reader threads
since they never return error.

Fixes: eff30b59cc2e ("test/lpm: add RCU performance tests")
Cc: stable@dpdk.org
Signed-off-by: Dharmik Thakkar <dharmik.thakkar@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Acked-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
app/test/test_lpm_perf.c

index 873ecf5..c8e70ec 100644 (file)
@@ -556,11 +556,10 @@ test_lpm_rcu_perf_multi_writer(void)
                __atomic_load_n(&gwrite_cycles, __ATOMIC_RELAXED)
                / TOTAL_WRITES);
 
-       /* Wait and check return value from reader threads */
        writer_done = 1;
+       /* Wait until all readers have exited */
        for (i = 2; i < num_cores; i++)
-               if (rte_eal_wait_lcore(enabled_core_ids[i]) < 0)
-                       goto error;
+               rte_eal_wait_lcore(enabled_core_ids[i]);
 
        rte_lpm_free(lpm);
        rte_free(rv);
@@ -605,10 +604,9 @@ test_lpm_rcu_perf_multi_writer(void)
                / TOTAL_WRITES);
 
        writer_done = 1;
-       /* Wait and check return value from reader threads */
+       /* Wait until all readers have exited */
        for (i = 2; i < num_cores; i++)
-               if (rte_eal_wait_lcore(enabled_core_ids[i]) < 0)
-                       goto error;
+               rte_eal_wait_lcore(enabled_core_ids[i]);
 
        rte_lpm_free(lpm);
 
@@ -712,10 +710,9 @@ test_lpm_rcu_perf(void)
                (double)total_cycles / TOTAL_WRITES);
 
        writer_done = 1;
-       /* Wait and check return value from reader threads */
+       /* Wait until all readers have exited */
        for (i = 0; i < num_cores; i++)
-               if (rte_eal_wait_lcore(enabled_core_ids[i]) < 0)
-                       goto error;
+               rte_eal_wait_lcore(enabled_core_ids[i]);
 
        rte_lpm_free(lpm);
        rte_free(rv);
@@ -771,11 +768,9 @@ test_lpm_rcu_perf(void)
                (double)total_cycles / TOTAL_WRITES);
 
        writer_done = 1;
-       /* Wait and check return value from reader threads */
+       /* Wait until all readers have exited */
        for (i = 0; i < num_cores; i++)
-               if (rte_eal_wait_lcore(enabled_core_ids[i]) < 0)
-                       printf("Warning: lcore %u not finished.\n",
-                               enabled_core_ids[i]);
+               rte_eal_wait_lcore(enabled_core_ids[i]);
 
        rte_lpm_free(lpm);