]> git.droids-corp.org - dpdk.git/commitdiff
net/iavf: fix memory leak
authorWenjun Wu <wenjun1.wu@intel.com>
Tue, 10 May 2022 00:54:25 +0000 (08:54 +0800)
committerQi Zhang <qi.z.zhang@intel.com>
Tue, 17 May 2022 00:40:09 +0000 (02:40 +0200)
Set an invalid quanta size from devargs will cause memory leak and this
is reported by coverity.

The patch fix the issue by correcting the error handle.

Coverity issue: 378017
Fixes: b14e8a57b9fe ("net/iavf: support quanta size configuration")
Signed-off-by: Wenjun Wu <wenjun1.wu@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
drivers/net/iavf/iavf_ethdev.c

index d1a2b53675ddf69893ea1a8c176b756b75d73f26..82672841f4182737b8465a153ece47bf4da732c3 100644 (file)
@@ -2188,7 +2188,8 @@ static int iavf_parse_devargs(struct rte_eth_dev *dev)
        if (ad->devargs.quanta_size < 256 || ad->devargs.quanta_size > 4096 ||
            ad->devargs.quanta_size & 0x40) {
                PMD_INIT_LOG(ERR, "invalid quanta size\n");
-               return -EINVAL;
+               ret = -EINVAL;
+               goto bail;
        }
 
 bail: