net/mlx5: convert port id action to indexed

This commit converts port id action to indexed.

Using the uint32_t index instead of pointer saves 4 bytes memory for the
flow handle. For millions flows, it will save several MBytes of memory.

Signed-off-by: Suanming Mou <suanmingm@mellanox.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>

diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index e18e801a3a8bbfc65dd1154e30c177d281775d00..e02361cde3e8b66c8cadba233d458091c631ea30 100644 (file)
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -232,6 +232,17 @@ static struct mlx5_indexed_pool_config mlx5_ipool_cfg[] = {
                .free = rte_free,
                .type = "mlx5_tag_ipool",
        },
+       {
+               .size = sizeof(struct mlx5_flow_dv_port_id_action_resource),
+               .trunk_size = 64,
+               .grow_trunk = 3,
+               .grow_shift = 2,
+               .need_lock = 0,
+               .release_mem_en = 1,
+               .malloc = rte_malloc_socket,
+               .free = rte_free,
+               .type = "mlx5_port_id_ipool",
+       },
 };
 
 

diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h
index 96922585b0d151d999a9a495b34b620b68d488ee..2004479e016c0c08ddaa476bb72c78fdb6c461c1 100644 (file)
--- a/drivers/net/mlx5/mlx5.h
+++ b/drivers/net/mlx5/mlx5.h
@@ -48,6 +48,7 @@ enum mlx5_ipool_index {
        MLX5_IPOOL_DECAP_ENCAP = 0, /* Pool for encap/decap resource. */
        MLX5_IPOOL_PUSH_VLAN, /* Pool for push vlan resource. */
        MLX5_IPOOL_TAG, /* Pool for tag resource. */
+       MLX5_IPOOL_PORT_ID, /* Pool for port id resource. */
        MLX5_IPOOL_MAX,
 };
 
@@ -434,8 +435,7 @@ struct mlx5_ibv_shared {
        uint32_t encaps_decaps; /* Encap/decap action indexed memory list. */
        LIST_HEAD(modify_cmd, mlx5_flow_dv_modify_hdr_resource) modify_cmds;
        struct mlx5_hlist *tag_table;
-       LIST_HEAD(port_id_action_list, mlx5_flow_dv_port_id_action_resource)
-               port_id_action_list; /* List of port ID actions. */
+       uint32_t port_id_action_list; /* List of port ID actions. */
        uint32_t push_vlan_action_list; /* List of push VLAN actions. */
        struct mlx5_flow_counter_mng cmng; /* Counters management structure. */
        struct mlx5_indexed_pool *ipool[MLX5_IPOOL_MAX];

diff --git a/drivers/net/mlx5/mlx5_flow.h b/drivers/net/mlx5/mlx5_flow.h
index 8f9f5e6e23c15d38775b65acf0b40d1cdd439948..da86272323cbe3168ba71a40f69a34b786efbd0d 100644 (file)
--- a/drivers/net/mlx5/mlx5_flow.h
+++ b/drivers/net/mlx5/mlx5_flow.h
@@ -420,7 +420,7 @@ struct mlx5_flow_dv_jump_tbl_resource {
 
 /* Port ID resource structure. */
 struct mlx5_flow_dv_port_id_action_resource {
-       LIST_ENTRY(mlx5_flow_dv_port_id_action_resource) next;
+       ILIST_ENTRY(uint32_t)next;
        /* Pointer to next element. */
        rte_atomic32_t refcnt; /**< Reference counter. */
        void *action;
@@ -489,7 +489,7 @@ struct mlx5_flow_handle_dv {
        /**< Pointer to modify header resource in cache. */
        struct mlx5_flow_dv_jump_tbl_resource *jump;
        /**< Pointer to the jump action resource. */
-       struct mlx5_flow_dv_port_id_action_resource *port_id_action;
+       uint32_t port_id_action;
        /**< Pointer to port ID action resource. */
        struct mlx5_vf_vlan vf_vlan;
        /**< Structure for VF VLAN workaround. */
@@ -549,6 +549,8 @@ struct mlx5_flow_dv_workspace {
        struct mlx5_flow_dv_push_vlan_action_resource *push_vlan_res;
        /**< Pointer to push VLAN action resource in cache. */
        struct mlx5_flow_dv_tag_resource *tag_resource;
+       struct mlx5_flow_dv_port_id_action_resource *port_id_action;
+       /**< Pointer to port ID action resource. */
        /**< pointer to the tag action. */
        struct mlx5_flow_dv_match_params value;
        /**< Holds the value that the packet is compared to. */

diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c
index 5aa624db4a468480fbfc801eb2261eb6b08eda95..43cace4fae642882409e9edc3ad452db0b0cb49a 100644 (file)
--- a/drivers/net/mlx5/mlx5_flow_dv.c
+++ b/drivers/net/mlx5/mlx5_flow_dv.c
@@ -2601,21 +2601,25 @@ flow_dv_port_id_action_resource_register
        struct mlx5_priv *priv = dev->data->dev_private;
        struct mlx5_ibv_shared *sh = priv->sh;
        struct mlx5_flow_dv_port_id_action_resource *cache_resource;
+       uint32_t idx = 0;
 
        /* Lookup a matching resource from cache. */
-       LIST_FOREACH(cache_resource, &sh->port_id_action_list, next) {
+       ILIST_FOREACH(sh->ipool[MLX5_IPOOL_PORT_ID], sh->port_id_action_list,
+                     idx, cache_resource, next) {
                if (resource->port_id == cache_resource->port_id) {
                        DRV_LOG(DEBUG, "port id action resource resource %p: "
                                "refcnt %d++",
                                (void *)cache_resource,
                                rte_atomic32_read(&cache_resource->refcnt));
                        rte_atomic32_inc(&cache_resource->refcnt);
-                       dev_flow->handle->dvh.port_id_action = cache_resource;
+                       dev_flow->handle->dvh.port_id_action = idx;
+                       dev_flow->dv.port_id_action = cache_resource;
                        return 0;
                }
        }
        /* Register new port id action resource. */
-       cache_resource = rte_calloc(__func__, 1, sizeof(*cache_resource), 0);
+       cache_resource = mlx5_ipool_zmalloc(sh->ipool[MLX5_IPOOL_PORT_ID],
+                                      &dev_flow->handle->dvh.port_id_action);
        if (!cache_resource)
                return rte_flow_error_set(error, ENOMEM,
                                          RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL,
@@ -2637,8 +2641,10 @@ flow_dv_port_id_action_resource_register
        }
        rte_atomic32_init(&cache_resource->refcnt);
        rte_atomic32_inc(&cache_resource->refcnt);
-       LIST_INSERT_HEAD(&sh->port_id_action_list, cache_resource, next);
-       dev_flow->handle->dvh.port_id_action = cache_resource;
+       ILIST_INSERT(sh->ipool[MLX5_IPOOL_PORT_ID], &sh->port_id_action_list,
+                    dev_flow->handle->dvh.port_id_action, cache_resource,
+                    next);
+       dev_flow->dv.port_id_action = cache_resource;
        DRV_LOG(DEBUG, "new port id action resource %p: refcnt %d++",
                (void *)cache_resource,
                rte_atomic32_read(&cache_resource->refcnt));
@@ -7425,12 +7431,14 @@ __flow_dv_translate(struct rte_eth_dev *dev,
                        if (flow_dv_translate_action_port_id(dev, action,
                                                             &port_id, error))
                                return -rte_errno;
+                       memset(&port_id_resource, 0, sizeof(port_id_resource));
                        port_id_resource.port_id = port_id;
                        if (flow_dv_port_id_action_resource_register
                            (dev, &port_id_resource, dev_flow, error))
                                return -rte_errno;
+                       MLX5_ASSERT(!handle->dvh.port_id_action);
                        dev_flow->dv.actions[actions_n++] =
-                                       handle->dvh.port_id_action->action;
+                                       dev_flow->dv.port_id_action->action;
                        action_flags |= MLX5_FLOW_ACTION_PORT_ID;
                        break;
                case RTE_FLOW_ACTION_TYPE_FLAG:
@@ -8318,6 +8326,8 @@ flow_dv_modify_hdr_resource_release(struct mlx5_flow_handle *handle)
 /**
  * Release port ID action resource.
  *
+ * @param dev
+ *   Pointer to Ethernet device.
  * @param handle
  *   Pointer to mlx5_flow_handle.
  *
@@ -8325,11 +8335,17 @@ flow_dv_modify_hdr_resource_release(struct mlx5_flow_handle *handle)
  *   1 while a reference on it exists, 0 when freed.
  */
 static int
-flow_dv_port_id_action_resource_release(struct mlx5_flow_handle *handle)
+flow_dv_port_id_action_resource_release(struct rte_eth_dev *dev,
+                                       struct mlx5_flow_handle *handle)
 {
-       struct mlx5_flow_dv_port_id_action_resource *cache_resource =
-                                               handle->dvh.port_id_action;
+       struct mlx5_priv *priv = dev->data->dev_private;
+       struct mlx5_flow_dv_port_id_action_resource *cache_resource;
+       uint32_t idx = handle->dvh.port_id_action;
 
+       cache_resource = mlx5_ipool_get(priv->sh->ipool[MLX5_IPOOL_PORT_ID],
+                                       idx);
+       if (!cache_resource)
+               return 0;
        MLX5_ASSERT(cache_resource->action);
        DRV_LOG(DEBUG, "port ID action resource %p: refcnt %d--",
                (void *)cache_resource,
@@ -8337,8 +8353,10 @@ flow_dv_port_id_action_resource_release(struct mlx5_flow_handle *handle)
        if (rte_atomic32_dec_and_test(&cache_resource->refcnt)) {
                claim_zero(mlx5_glue->destroy_flow_action
                                (cache_resource->action));
-               LIST_REMOVE(cache_resource, next);
-               rte_free(cache_resource);
+               ILIST_REMOVE(priv->sh->ipool[MLX5_IPOOL_PORT_ID],
+                            &priv->sh->port_id_action_list, idx,
+                            cache_resource, next);
+               mlx5_ipool_free(priv->sh->ipool[MLX5_IPOOL_PORT_ID], idx);
                DRV_LOG(DEBUG, "port id action resource %p: removed",
                        (void *)cache_resource);
                return 0;
@@ -8457,7 +8475,8 @@ __flow_dv_destroy(struct rte_eth_dev *dev, struct rte_flow *flow)
                if (dev_handle->dvh.jump)
                        flow_dv_jump_tbl_resource_release(dev, dev_handle);
                if (dev_handle->dvh.port_id_action)
-                       flow_dv_port_id_action_resource_release(dev_handle);
+                       flow_dv_port_id_action_resource_release(dev,
+                                                               dev_handle);
                if (dev_handle->dvh.push_vlan_res)
                        flow_dv_push_vlan_action_resource_release(dev,
                                                                  dev_handle);