]> git.droids-corp.org - dpdk.git/commitdiff
app/testpmd: revert fixed flag for exact link speed
authorFerruh Yigit <ferruh.yigit@intel.com>
Wed, 24 Apr 2019 22:03:09 +0000 (23:03 +0100)
committerThomas Monjalon <thomas@monjalon.net>
Sat, 4 May 2019 20:50:36 +0000 (22:50 +0200)
This reverts commit bdca79053b6aea504d02691d9319fa976062457f.

Not all PMDs support the fixed link speed set, and link speed can be set
even with auto negotiation enabled. Reverting the patch to not break
existing usage.

Fixes: bdca79053b6a ("app/testpmd: set fixed flag for exact link speed")
Cc: stable@dpdk.org
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
app/test-pmd/cmdline.c

index f45ef8a1c7cc70068245c00d8ae9f4faf0828933..c1042dd98214bdb2bac21254688065839e0c3ee2 100644 (file)
@@ -1533,17 +1533,17 @@ parse_and_check_speed_duplex(char *speedstr, char *duplexstr, uint32_t *speed)
                        return -1;
                }
                if (!strcmp(speedstr, "1000")) {
-                       *speed = ETH_LINK_SPEED_1G | ETH_LINK_SPEED_FIXED;
+                       *speed = ETH_LINK_SPEED_1G;
                } else if (!strcmp(speedstr, "10000")) {
-                       *speed = ETH_LINK_SPEED_10G | ETH_LINK_SPEED_FIXED;
+                       *speed = ETH_LINK_SPEED_10G;
                } else if (!strcmp(speedstr, "25000")) {
-                       *speed = ETH_LINK_SPEED_25G | ETH_LINK_SPEED_FIXED;
+                       *speed = ETH_LINK_SPEED_25G;
                } else if (!strcmp(speedstr, "40000")) {
-                       *speed = ETH_LINK_SPEED_40G | ETH_LINK_SPEED_FIXED;
+                       *speed = ETH_LINK_SPEED_40G;
                } else if (!strcmp(speedstr, "50000")) {
-                       *speed = ETH_LINK_SPEED_50G | ETH_LINK_SPEED_FIXED;
+                       *speed = ETH_LINK_SPEED_50G;
                } else if (!strcmp(speedstr, "100000")) {
-                       *speed = ETH_LINK_SPEED_100G | ETH_LINK_SPEED_FIXED;
+                       *speed = ETH_LINK_SPEED_100G;
                } else if (!strcmp(speedstr, "auto")) {
                        *speed = ETH_LINK_SPEED_AUTONEG;
                } else {