test/ring: validate single element enqueue/dequeue
authorFeifei Wang <feifei.wang2@arm.com>
Sun, 20 Sep 2020 11:48:54 +0000 (06:48 -0500)
committerDavid Marchand <david.marchand@redhat.com>
Wed, 23 Sep 2020 09:23:10 +0000 (11:23 +0200)
Validate the return value of single element enqueue/dequeue operation in
the test.

Suggested-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Signed-off-by: Feifei Wang <feifei.wang2@arm.com>
Reviewed-by: Phil Yang <phil.yang@arm.com>
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
app/test/test_ring.c

index c901779..da57032 100644 (file)
@@ -834,8 +834,13 @@ test_ring_basic_ex(void)
                        rte_ring_free_count(rp));
 
                for (j = 0; j < RING_SIZE - 1; j++) {
-                       test_ring_enqueue(rp, cur_src, esize[i], 1,
+                       ret = test_ring_enqueue(rp, cur_src, esize[i], 1,
                                TEST_RING_THREAD_DEF | TEST_RING_ELEM_SINGLE);
+                       if (ret != 0) {
+                               printf("%s: rte_ring_enqueue fails\n",
+                                       __func__);
+                               goto fail_test;
+                       }
                        cur_src = test_ring_inc_ptr(cur_src, esize[i], 1);
                }
 
@@ -846,8 +851,13 @@ test_ring_basic_ex(void)
                }
 
                for (j = 0; j < RING_SIZE - 1; j++) {
-                       test_ring_dequeue(rp, cur_dst, esize[i], 1,
+                       ret = test_ring_dequeue(rp, cur_dst, esize[i], 1,
                                TEST_RING_THREAD_DEF | TEST_RING_ELEM_SINGLE);
+                       if (ret != 0) {
+                               printf("%s: rte_ring_dequeue fails\n",
+                                       __func__);
+                               goto fail_test;
+                       }
                        cur_dst = test_ring_inc_ptr(cur_dst, esize[i], 1);
                }
 
@@ -1001,10 +1011,18 @@ test_ring_with_exact_size(void)
                 * than the standard ring. (16 vs 15 elements)
                 */
                for (j = 0; j < ring_sz - 1; j++) {
-                       test_ring_enqueue(std_r, cur_src, esize[i], 1,
+                       ret = test_ring_enqueue(std_r, cur_src, esize[i], 1,
                                TEST_RING_THREAD_DEF | TEST_RING_ELEM_SINGLE);
-                       test_ring_enqueue(exact_sz_r, cur_src, esize[i], 1,
+                       if (ret != 0) {
+                               printf("%s: error, enqueue failed\n", __func__);
+                               goto test_fail;
+                       }
+                       ret = test_ring_enqueue(exact_sz_r, cur_src, esize[i], 1,
                                TEST_RING_THREAD_DEF | TEST_RING_ELEM_SINGLE);
+                       if (ret != 0) {
+                               printf("%s: error, enqueue failed\n", __func__);
+                               goto test_fail;
+                       }
                        cur_src = test_ring_inc_ptr(cur_src, esize[i], 1);
                }
                ret = test_ring_enqueue(std_r, cur_src, esize[i], 1,