drivers/net: remove redundant MAC addresses freeing
authorThomas Monjalon <thomas@monjalon.net>
Mon, 28 Sep 2020 23:14:32 +0000 (01:14 +0200)
committerFerruh Yigit <ferruh.yigit@intel.com>
Wed, 30 Sep 2020 17:19:14 +0000 (19:19 +0200)
The MAC addresses array is already freed by rte_eth_dev_release_port().
The redundant freeing can be removed from the PMD port closing functions.

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
drivers/net/ark/ark_ethdev.c
drivers/net/hinic/hinic_pmd_ethdev.c
drivers/net/ice/ice_ethdev.c
drivers/net/nfb/nfb_ethdev.c
drivers/net/szedata2/rte_eth_szedata2.c

index 3e96445..e3b1347 100644 (file)
@@ -705,9 +705,6 @@ eth_ark_dev_close(struct rte_eth_dev *dev)
                dev->data->rx_queues[i] = 0;
        }
 
-       rte_free(dev->data->mac_addrs);
-       dev->data->mac_addrs = 0;
-
        return 0;
 }
 
index 6061f61..466c836 100644 (file)
@@ -3257,9 +3257,6 @@ static int hinic_dev_uninit(struct rte_eth_dev *dev)
 
        rte_free(nic_dev->mc_list);
 
-       rte_free(dev->data->mac_addrs);
-       dev->data->mac_addrs = NULL;
-
        return HINIC_OK;
 }
 
index 5f7b58a..d8ce09d 100644 (file)
@@ -2420,9 +2420,6 @@ ice_dev_close(struct rte_eth_dev *dev)
        dev->rx_pkt_burst = NULL;
        dev->tx_pkt_burst = NULL;
 
-       rte_free(dev->data->mac_addrs);
-       dev->data->mac_addrs = NULL;
-
        /* disable uio intr before callback unregister */
        rte_intr_disable(intr_handle);
 
index 7ee7294..a9a8bc8 100644 (file)
@@ -236,9 +236,6 @@ nfb_eth_dev_close(struct rte_eth_dev *dev)
        }
        dev->data->nb_tx_queues = 0;
 
-       rte_free(dev->data->mac_addrs);
-       dev->data->mac_addrs = NULL;
-
        return 0;
 }
 
index 7e9fafd..0eecec1 100644 (file)
@@ -1181,9 +1181,6 @@ eth_dev_close(struct rte_eth_dev *dev)
        }
        dev->data->nb_tx_queues = 0;
 
-       rte_free(dev->data->mac_addrs);
-       dev->data->mac_addrs = NULL;
-
        return 0;
 }