net/vdev_netvsc: fix device detection error check
authorMatan Azrad <matan@mellanox.com>
Mon, 5 Feb 2018 12:48:22 +0000 (12:48 +0000)
committerFerruh Yigit <ferruh.yigit@intel.com>
Mon, 5 Feb 2018 18:56:04 +0000 (19:56 +0100)
The vdev_netvsc driver does periodic detection of PCI devices matched
to the netvsc existed interfaces.

When it finds a match, the PCI address is written to the pipe of the
associated fail-safe PMD instance and a positive value is returned to
the periodic check which is wrongly considered as error.

Change the check to consider only a negative value as error.

Fixes: e7dc5d7becc5 ("net/vdev_netvsc: implement core functionality")

Signed-off-by: Matan Azrad <matan@mellanox.com>
drivers/net/vdev_netvsc/vdev_netvsc.c

index a8a1a7f..cbf4d59 100644 (file)
@@ -388,7 +388,7 @@ vdev_netvsc_alarm(__rte_unused void *arg)
 
        LIST_FOREACH(ctx, &vdev_netvsc_ctx_list, entry) {
                ret = vdev_netvsc_foreach_iface(vdev_netvsc_device_probe, ctx);
-               if (ret)
+               if (ret < 0)
                        break;
        }
        if (!vdev_netvsc_ctx_count)