net/bnxt: fix PCI write check
authorKalesh AP <kalesh-anakkur.purayil@broadcom.com>
Tue, 16 Mar 2021 05:41:25 +0000 (11:11 +0530)
committerAjit Khaparde <ajit.khaparde@broadcom.com>
Fri, 19 Mar 2021 19:29:46 +0000 (20:29 +0100)
CID 363716 (#1 of 1): Unchecked return value (CHECKED_RETURN)
check_return: Calling rte_pci_write_config without checking
return value (as is done elsewhere 46 out of 49 times).

Coverity issue: 363716
Fixes: be14720def9c ("net/bnxt: support FW reset")
Cc: stable@dpdk.org
Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
drivers/net/bnxt/bnxt_ethdev.c

index 57a409c..1997783 100644 (file)
@@ -3861,13 +3861,19 @@ static void bnxt_write_fw_reset_reg(struct bnxt *bp, uint32_t index)
        uint32_t val = info->reset_reg_val[index];
        uint32_t reg = info->reset_reg[index];
        uint32_t type, offset;
+       int ret;
 
        type = BNXT_FW_STATUS_REG_TYPE(reg);
        offset = BNXT_FW_STATUS_REG_OFF(reg);
 
        switch (type) {
        case BNXT_FW_STATUS_REG_TYPE_CFG:
-               rte_pci_write_config(bp->pdev, &val, sizeof(val), offset);
+               ret = rte_pci_write_config(bp->pdev, &val, sizeof(val), offset);
+               if (ret < 0) {
+                       PMD_DRV_LOG(ERR, "Failed to write %#x at PCI offset %#x",
+                                   val, offset);
+                       return;
+               }
                break;
        case BNXT_FW_STATUS_REG_TYPE_GRC:
                offset = bnxt_map_reset_regs(bp, offset);