net/failsafe: fix device freeing

The PMD destroy function was calling the release function, which frees
dev->data->dev_private, and then tries to free PRIV(dev)->intr_handle,
which causes the heap use after free issue.

The free can be moved to before the release function is called.

Fixes: d61138d4f0e ("drivers: remove direct access to interrupt handle")
Cc: stable@dpdk.org
Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
Reviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>

diff --git a/drivers/net/failsafe/failsafe.c b/drivers/net/failsafe/failsafe.c
index 3c754a5f66e0815bc26263774f0ca1a01e8051ad..05cf5338963c34ef07d7a579f33172c490f33de8 100644 (file)
--- a/drivers/net/failsafe/failsafe.c
+++ b/drivers/net/failsafe/failsafe.c
@@ -308,8 +308,8 @@ fs_rte_eth_free(const char *name)
        if (dev == NULL)
                return 0; /* port already released */
        ret = failsafe_eth_dev_close(dev);
-       rte_eth_dev_release_port(dev);
        rte_intr_instance_free(PRIV(dev)->intr_handle);
+       rte_eth_dev_release_port(dev);
        return ret;
 }