vdpa/mlx5: fix TSO offload without checksum
authorXueming Li <xuemingl@nvidia.com>
Sun, 13 Jun 2021 12:51:39 +0000 (20:51 +0800)
committerChenbo Xia <chenbo.xia@intel.com>
Wed, 30 Jun 2021 11:39:23 +0000 (13:39 +0200)
Packet was corrupted when TSO requested without CSUM update.

Enables CSUM automatically if only TSO requested.

Fixes: 2aa8444b0084 ("vdpa/mlx5: support stateless offloads")
Cc: stable@dpdk.org
Signed-off-by: Xueming Li <xuemingl@nvidia.com>
Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>
drivers/vdpa/mlx5/mlx5_vdpa_virtq.c

index 024c5c4..f530646 100644 (file)
@@ -442,6 +442,13 @@ mlx5_vdpa_virtqs_prepare(struct mlx5_vdpa_priv *priv)
                DRV_LOG(ERR, "Failed to configure negotiated features.");
                return -1;
        }
+       if ((priv->features & (1ULL << VIRTIO_NET_F_CSUM)) == 0 &&
+           ((priv->features & (1ULL << VIRTIO_NET_F_HOST_TSO4)) > 0 ||
+            (priv->features & (1ULL << VIRTIO_NET_F_HOST_TSO6)) > 0)) {
+               /* Packet may be corrupted if TSO is enabled without CSUM. */
+               DRV_LOG(INFO, "TSO is enabled without CSUM, force CSUM.");
+               priv->features |= (1ULL << VIRTIO_NET_F_CSUM);
+       }
        if (nr_vring > priv->caps.max_num_virtio_queues * 2) {
                DRV_LOG(ERR, "Do not support more than %d virtqs(%d).",
                        (int)priv->caps.max_num_virtio_queues * 2,