net/qede: limit Rx ring index read for debug
authorDavid Marchand <david.marchand@redhat.com>
Fri, 27 Sep 2019 11:28:49 +0000 (13:28 +0200)
committerFerruh Yigit <ferruh.yigit@intel.com>
Tue, 8 Oct 2019 10:14:31 +0000 (12:14 +0200)
Caught by clang, this idx value is only used for a debug message when
the mbufs allocation fails.
No need to use idx as a temporary storage.

Fixes: 8f2312474529 ("net/qede: fix performance bottleneck in Rx path")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: Rasesh Mody <rmody@marvell.com>
drivers/net/qede/qede_rxtx.c

index dbb74fc..fffccf0 100644 (file)
@@ -46,8 +46,6 @@ static inline int qede_alloc_rx_bulk_mbufs(struct qede_rx_queue *rxq, int count)
        int i, ret = 0;
        uint16_t idx;
 
-       idx = rxq->sw_rx_prod & NUM_RX_BDS(rxq);
-
        if (count > QEDE_MAX_BULK_ALLOC_COUNT)
                count = QEDE_MAX_BULK_ALLOC_COUNT;
 
@@ -56,7 +54,9 @@ static inline int qede_alloc_rx_bulk_mbufs(struct qede_rx_queue *rxq, int count)
                PMD_RX_LOG(ERR, rxq,
                           "Failed to allocate %d rx buffers "
                            "sw_rx_prod %u sw_rx_cons %u mp entries %u free %u",
-                           count, idx, rxq->sw_rx_cons & NUM_RX_BDS(rxq),
+                           count,
+                           rxq->sw_rx_prod & NUM_RX_BDS(rxq),
+                           rxq->sw_rx_cons & NUM_RX_BDS(rxq),
                            rte_mempool_avail_count(rxq->mb_pool),
                            rte_mempool_in_use_count(rxq->mb_pool));
                return -ENOMEM;