dpdk.git
7 years agotest: add a new unit test case status
Jerin Jacob [Sun, 19 Mar 2017 13:37:34 +0000 (19:07 +0530)]
test: add a new unit test case status

Add a new unit test case status called "unsupported".
This is useful in marking a test case "unsupported" if testcase
returns -ENOTSUP at runtime.

Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
7 years agotest: store only the test case name
Jerin Jacob [Sun, 19 Mar 2017 13:37:33 +0000 (19:07 +0530)]
test: store only the test case name

Store only the test case name in unit test case structure.The actor who
renders the test status can add appropriate test status. This enables
adding the new test case status without storing the additional
information in the unit test case structure.

Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Tested-by: Harry van Haaren <harry.van.haaren@intel.com>
Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
7 years agomk: remove invalid phony target
Olivier Matz [Fri, 17 Mar 2017 17:08:53 +0000 (18:08 +0100)]
mk: remove invalid phony target

There was a typo in the .PHONY for the test-build target. If we fix the
typo, the test-build target does not work, because it won't match the
'%' target anymore.

So just remove the .PHONY.

Fixes: 64592d97c1ae ("mk: do not build tests by default")

Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
7 years agomk: fix message when test application is not built
Olivier Matz [Fri, 17 Mar 2017 17:09:14 +0000 (18:09 +0100)]
mk: fix message when test application is not built

To build the tests, we should use "make test-build".

Fixes: 64592d97c1ae ("mk: do not build tests by default")

Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
7 years agomaintainers: resign from eal maintenance
David Marchand [Thu, 16 Mar 2017 10:47:08 +0000 (11:47 +0100)]
maintainers: resign from eal maintenance

I have been a little too busy these past months and could not really
do any real maintainer stuff for dpdk for a while now.

I have no clear idea when I could dedicate more time to dpdk.
So the best thing for the dpdk community would be to move the eal
maintenance to more involved people.

Signed-off-by: David Marchand <david.marchand@6wind.com>
7 years agomk: provide option to set major ABI version
Christian Ehrhardt [Wed, 1 Mar 2017 09:34:12 +0000 (10:34 +0100)]
mk: provide option to set major ABI version

Downstreams might want to provide different DPDK releases at the same
time to support multiple consumers of DPDK linked against older and newer
sonames.

Also due to the interdependencies that DPDK libraries can have applications
might end up with an executable space in which multiple versions of a
library are mapped by ld.so.

Think of LibA that got an ABI bump and LibB that did not get an ABI bump
but is depending on LibA.

    Application
    \-> LibA.old
    \-> LibB.new -> LibA.new

That is a conflict which can be avoided by setting CONFIG_RTE_MAJOR_ABI.
If set CONFIG_RTE_MAJOR_ABI overwrites any LIBABIVER value.
An example might be ``CONFIG_RTE_MAJOR_ABI=16.11`` which will make all
libraries librte<?>.so.16.11 instead of librte<?>.so.<LIBABIVER>.

We need to cut arbitrary long stings after the .so now and this would work
for any ABI version in LIBABIVER:
  $(Q)ln -s -f $< $(patsubst %.$(LIBABIVER),%,$@)
But using the following instead additionally allows to simplify the Make
File for the CONFIG_RTE_NEXT_ABI case.
  $(Q)ln -s -f $< $(shell echo $@ | sed 's/\.so.*/.so/')

Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Reviewed-by: Jan Blunck <jblunck@infradead.org>
Tested-by: Jan Blunck <jblunck@infradead.org>
7 years agolpm6: extend next hop field
Vladyslav Buslov [Tue, 14 Mar 2017 17:17:38 +0000 (19:17 +0200)]
lpm6: extend next hop field

This patch extend next_hop field from 8-bits to 21-bits in LPM library
for IPv6.

Added versioning symbols to functions and updated
library and applications that have a dependency on LPM library.

Signed-off-by: Vladyslav Buslov <vladyslav.buslov@harmonicinc.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
7 years agoapp/testpmd: add default MAC set command
Pascal Mazon [Mon, 13 Mar 2017 10:27:07 +0000 (11:27 +0100)]
app/testpmd: add default MAC set command

Signed-off-by: Pascal Mazon <pascal.mazon@6wind.com>
Acked-by: Jingjing Wu <jingjing.wu@intel.com>
7 years agoigb_uio: support devices with only I/O BAR
Matt Peters [Tue, 14 Mar 2017 16:33:09 +0000 (12:33 -0400)]
igb_uio: support devices with only I/O BAR

Allow the BAR setup to succeed if a device has at least 1 BAR region
defined.  Previously, the device probe would only succeed if at least one
memory BAR existed, but there are devices that have only port I/O BARs.

For example, on Virtual Box a virtio device has only a single I/O BAR
because by default MSI-X is not enabled.  While in qemu/kvm the virtio
device has MSI-X enabled and therefore has both an I/O and Memory BAR.

The following are excerpts from "lspci -nnvvvv -s 00:09.0" on both types of
systems.

Virtual Box:

    Region 0: I/O ports at d260 [size=32]
    Capabilities: [80] #00 [0000]

QEMU/KVM:

    Region 0: I/O ports at c060 [size=32]
    Region 1: Memory at febd1000 (32-bit, non-prefetchable) [size=4K]
    Expansion ROM at feb80000 [disabled] [size=256K]
    Capabilities: [40] MSI-X: Enable+ Count=3 Masked-
            Vector table: BAR=1 offset=00000000
            PBA: BAR=1 offset=00000800

Signed-off-by: Matt Peters <matt.peters@windriver.com>
Signed-off-by: Allain Legacy <allain.legacy@windriver.com>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
7 years agombuf: use pktmbuf helper to create the pool
Hemant Agrawal [Tue, 14 Mar 2017 09:14:40 +0000 (10:14 +0100)]
mbuf: use pktmbuf helper to create the pool

When possible, replace the uses of rte_mempool_create() with
the helper provided in librte_mbuf: rte_pktmbuf_pool_create().

This is the preferred way to create a mbuf pool.

This also updates the documentation.

Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
Acked-by: Olivier Matz <olivier.matz@6wind.com>
7 years agoremove unmaintained TILE-Gx architecture
Thomas Monjalon [Sat, 11 Feb 2017 20:36:12 +0000 (21:36 +0100)]
remove unmaintained TILE-Gx architecture

The TILE-Gx architecture and its driver mpipe are not maintained.
The code is removed to avoid confusion.

A last update has been done in 17.05 before removal.
It can be built with the updated toolchain:
http://www.mellanox.com/repository/solutions/tile-scm/
and libgxio:
http://www.mellanox.com/repository/solutions/tile-scm/libgxio-1.0.tar.xz

Quote from http://dpdk.org/ml/archives/dev/2017-February/057940.html
"
Mellanox agrees to remove TILE-Gx support from DPDK.org, but will continue
to support customers using DPDK.
Customer that needs support should contact Mellanox directly.
"

Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
7 years agoexamples: fix optind reset
Keith Wiles [Tue, 14 Feb 2017 22:09:41 +0000 (16:09 -0600)]
examples: fix optind reset

The variable optind should be reset to one not zero.

From the man page:
"The variable optind is the index of the next element to be processed in
argv.  The system initializes this value to 1.
The caller can reset it to 1 to restart scanning of the same argv, or when
scanning a new argument vector.”

The problem I saw with my application was trying to parse the wrong
option, which can happen as DPDK parses the first part of the command line
and the application parses the second part. If you call getopt() multiple
times in the same execution, the behavior is not maintained when using
zero for optind.

Signed-off-by: Keith Wiles <keith.wiles@intel.com>
7 years agoapp/procinfo: add collectd format and host id
Roman Korynkevych [Wed, 1 Mar 2017 16:27:19 +0000 (16:27 +0000)]
app/procinfo: add collectd format and host id

Extended proc-info application to send DPDK port statistics to
STDOUT in the format expected by collectd exec plugin. Added
HOST ID option to identify the host DPDK process is running on
when multiple instance of DPDK are running in parallel. This is
needed for the barometer project in OPNFV.

Signed-off-by: Roman Korynkevych <romanx.korynkevych@intel.com>
Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com>
Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
7 years agoapp/testpmd: fix typos
Nirmoy Das [Mon, 27 Feb 2017 19:23:55 +0000 (20:23 +0100)]
app/testpmd: fix typos

Signed-off-by: Nirmoy Das <ndas@suse.de>
Acked-by: John McNamara <john.mcnamara@intel.com>
7 years agoethdev: move a queue id check to generic layer
Olivier Matz [Fri, 17 Feb 2017 15:25:33 +0000 (16:25 +0100)]
ethdev: move a queue id check to generic layer

The check of queue_id is done in all drivers implementing
rte_eth_rx_queue_count(). Factorize this check in the generic function.

Note that the nfp driver was doing the check differently, which could
induce crashes if the queue index was too big.

Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
7 years agoethdev: clarify API comments of Rx queue count
Olivier Matz [Fri, 17 Feb 2017 15:25:32 +0000 (16:25 +0100)]
ethdev: clarify API comments of Rx queue count

The API comments are not consistent between each other.

The function rte_eth_rx_queue_count() returns the number of used
descriptors on a receive queue.

Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
7 years agoeal/ppc: support sPAPR IOMMU for vfio-pci
Gowrishankar Muthukrishnan [Mon, 6 Mar 2017 15:04:15 +0000 (20:34 +0530)]
eal/ppc: support sPAPR IOMMU for vfio-pci

Below changes adds pci probing support for vfio-pci devices in power8.

Signed-off-by: Gowrishankar Muthukrishnan <gowrishankar.m@linux.vnet.ibm.com>
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
Acked-by: Chao Zhu <chaozhu@linux.vnet.ibm.com>
7 years agoeal/linux: support running as unprivileged user
Ben Walker [Tue, 31 Jan 2017 17:44:53 +0000 (10:44 -0700)]
eal/linux: support running as unprivileged user

For Linux kernel 4.0 and newer, the ability to obtain
physical page frame numbers for unprivileged users from
/proc/self/pagemap was removed. Instead, when an IOMMU
is present, simply choose our own DMA addresses instead.

Signed-off-by: Ben Walker <benjamin.walker@intel.com>
Acked-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
7 years agodoc: add details on requirements for patch ack and merge
Bruce Richardson [Tue, 21 Feb 2017 12:02:47 +0000 (12:02 +0000)]
doc: add details on requirements for patch ack and merge

Add to the contributors guide the requirements and guidelines for
getting patches acked and merged. It details at what point the review
comments and the ack's need to be received in order to have a given
patch merged into a release.

These guidelines are as agreed by the DPDK technical board at the
meeting held on 2017-02-15.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
7 years agoexamples/quota_watermark: fix requirement for 2M pages
Bruce Richardson [Thu, 23 Feb 2017 16:42:03 +0000 (16:42 +0000)]
examples/quota_watermark: fix requirement for 2M pages

The sample app was forcing the shared memory block for high/low
watermarks to be placed in a memzone on 2M pages. This prevented it
from running on systems with just 1G pages, so remove the flag forcing
2M pages.

Fixes: 1d6c3ee3321a ("examples/quota_watermark: initial import")
Cc: stable@dpdk.org
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
7 years agoexamples/quota_watermark: correct code indentation
Bruce Richardson [Thu, 23 Feb 2017 16:42:02 +0000 (16:42 +0000)]
examples/quota_watermark: correct code indentation

The code indentation in the example app files used spaces rather than
tabs for indentation, and as such did not conform to DPDK conventions.
This left those modifying the code in a bind - to fix things on a line
by line basis so as to avoid checkpatch errors, or to keep things
consistent within the file, and accept checkpatch errors.

Since these files have not had too many changes since the original
import, there is little change history to lose by doing a complete
reformatting of the code, so just update all indentation to standard.
In the process, wrap long lines appropriately, avoiding splitting
error messages.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
7 years agocrypto/null: use ring size function
Bruce Richardson [Thu, 23 Feb 2017 16:42:01 +0000 (16:42 +0000)]
crypto/null: use ring size function

Rather than reading the size directly from the ring structure,
use the dedicated function for that purpose.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Declan Doherty <declan.doherty@intel.com>
7 years agoring: add a function to return the ring size
Bruce Richardson [Thu, 23 Feb 2017 16:42:00 +0000 (16:42 +0000)]
ring: add a function to return the ring size

Applications and other libraries should not be reading inside the
rte_ring structure directly to get the ring size. Instead add a fn
to allow it to be queried.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Olivier Matz <olivier.matz@6wind.com>
7 years agoapp/pdump: fix duplicate macro definition
Bruce Richardson [Thu, 23 Feb 2017 16:41:59 +0000 (16:41 +0000)]
app/pdump: fix duplicate macro definition

RTE_RING_SZ_MASK is redefined here with the original definition in
rte_ring.h. Since rte_ring.h is already included, just remove the
duplicate definition here.

Fixes: caa7028276b8 ("app/pdump: add tool for packet capturing")

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
7 years agoeal: ensure constness of container_of target
Jan Blunck [Tue, 14 Feb 2017 14:36:06 +0000 (15:36 +0100)]
eal: ensure constness of container_of target

This adds a check to ensure that the container_of() macro is not used to
cast away (remove) constness.

Signed-off-by: Jan Blunck <jblunck@infradead.org>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
7 years agoeal: fix container_of macro for const members
Jan Blunck [Tue, 14 Feb 2017 14:36:05 +0000 (15:36 +0100)]
eal: fix container_of macro for const members

This fixes the usage of structure members that are declared const to get
a pointer to the embedding parent structure.

Signed-off-by: Jan Blunck <jblunck@infradead.org>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
7 years agodoc: fix renamed bind tool
Julien Castets [Mon, 6 Mar 2017 16:15:26 +0000 (17:15 +0100)]
doc: fix renamed bind tool

Fixes: a5d7a3f77ddc ("unify tools naming")

Signed-off-by: Julien Castets <jcastets@scaleway.com>
7 years agodevtools: ignore warning on long log string
Allain Legacy [Wed, 1 Mar 2017 17:44:19 +0000 (12:44 -0500)]
devtools: ignore warning on long log string

The checkpatch.pl tool is flagging warnings on long debug log strings.
Since splitting these strings makes it difficult to search for logs it is
preferred to allow these as exceptions to the long line rule.  The addition
of the LONG_LINE_STRINGS to the list of exceptions will allow lines that
end with a string to exceed the maximum line length, but lines that end
with variables or other constructs will still be flagged as errors.  Also,
lines that make use of PRIx64 with string concatenation will still be
flagged if the beginning of the last string fragment begins after the 80
character threshold.

Signed-off-by: Allain Legacy <allain.legacy@windriver.com>
7 years agodoc: use corelist instead of coremask
Keith Wiles [Mon, 27 Feb 2017 19:13:40 +0000 (11:13 -0800)]
doc: use corelist instead of coremask

The coremask option in DPDK is difficult to use and we should be
promoting the use of the corelist (-l) option. The patch
adjusts the docs to use -l EAL option instead of the -c option.

The patch only changes the docs and not the code as the -c option
will continue to exist unless it is removed in the future. The -c
option should be kept to maintain backward compatibility.

Signed-off-by: Keith Wiles <keith.wiles@intel.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
7 years agomk: fix cleaning files
Ferruh Yigit [Wed, 22 Feb 2017 20:54:45 +0000 (20:54 +0000)]
mk: fix cleaning files

Remove remaining .lib.cmd, pmd.c, pmd.o and app.map files.

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
7 years agodoc: add test related rules in make help
Ferruh Yigit [Thu, 16 Feb 2017 14:57:46 +0000 (14:57 +0000)]
doc: add test related rules in make help

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
7 years agomk: rename test related rules
Ferruh Yigit [Thu, 16 Feb 2017 14:57:45 +0000 (14:57 +0000)]
mk: rename test related rules

Make rules renamed to a common syntax, test-x:
fast_test    -> test-fast
ring_test    -> test-ring
mempool_test -> test-mempool
perf_test    -> test-perf

These are to run various sub-set of the unit tests.

Not touched to make rules that are already following the syntax:
test-basic
test-build
test

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
7 years agomk: add new test-basic rule
Ferruh Yigit [Thu, 16 Feb 2017 14:57:44 +0000 (14:57 +0000)]
mk: add new test-basic rule

Since "make test" and "make test-build" does dependency resolving, they
check for all dependent components (lib and drivers) which takes a few
seconds.

This is a good feature during development, but if the target is only
running unit test, that step is unnecessary, it is possible to compile
once and run unit test multiple times, without checking any code update.

For this purpose, a new make rule "make test-basic" added. Which only
runs the unit test, expects that unit test already compiled.

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
7 years agomk: do not build tests by default
Ferruh Yigit [Thu, 16 Feb 2017 14:57:43 +0000 (14:57 +0000)]
mk: do not build tests by default

Don't build tests with default "make" command.

Require explicit command to build tests because not everybody interested
in running unit tests.

Following changes done in make rules:
"make test-build"  <--- Added
"make test"        <--- Updated functionality (build + run basic tests)

Now "make test" builds all tests and runs unit test (test).

Thanks to dependency resolving, it is possible to call "make test"
directly after config, "make test" will compile dependent components
(lib and drivers, but not apps).

And a new "make test-build" make rule added which will build
tests but not run unit test. "make test-build" has same dependency
resolving features with "make test"

To include "test" folder into makesystem, existing ROOTDIRS- variable
is used instead of hardcoding folder name into makefiles, current usage
of ROOTDIRS* variables are:

ROOTDIRS-y <-- root level folders prepared and compiled by default
ROOTDIRS-  <-- root level folders prepared but not compiled by default

The preparation is required for dependency resolving and cleaning.

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
7 years agotest: move unit tests to separate directory
Ferruh Yigit [Thu, 16 Feb 2017 14:57:42 +0000 (14:57 +0000)]
test: move unit tests to separate directory

This is to logically group unit tests into their own folder,
separating them from "app" folder.

Hopefully this will make the unit test in DPDK more visible.

Following binaries moved to "test" folder:
cmdline-test
test-acl
test-pipeline
test            <-- various DPDK unit tests

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
7 years agotile: fix build
Chris Metcalf [Sat, 18 Feb 2017 01:52:29 +0000 (20:52 -0500)]
tile: fix build

Re-enable CONFIG_RTE_LIBRTE_SCHED, since it is needed to build
correctly.

Fix a few warnings when compiling mpipe_tilegx.c.

Remove an empty rte_cpu_feature_table[] array using a bogus type.

Properly set RTE_OBJCOPY_{TARGET,ARCH} in mk/arch/tile/rte.vars.mk.

Signed-off-by: Chris Metcalf <cmetcalf@mellanox.com>
7 years agomk: generalize strict alignment warning handling
Chris Metcalf [Sat, 18 Feb 2017 01:52:28 +0000 (20:52 -0500)]
mk: generalize strict alignment warning handling

Rather than allowing just armv7 to have non-fatal strict alignment
cast warnings, generalize it to both strict alignment architectures,
armv7 and tile.

Signed-off-by: Chris Metcalf <cmetcalf@mellanox.com>
7 years agonet/mpipe: remove requirement for non-upstreamed headers
Chris Metcalf [Sat, 18 Feb 2017 01:52:27 +0000 (20:52 -0500)]
net/mpipe: remove requirement for non-upstreamed headers

These headers are not part of the set that are upstreamed as part
of glibc or the kernel, and we only need a few defines from each.
The hardware is frozen so these values are not going to change
in any case.

Signed-off-by: Chris Metcalf <cmetcalf@mellanox.com>
7 years agoeal/tile: avoid use of non-upstreamed header
Chris Metcalf [Sat, 18 Feb 2017 01:52:26 +0000 (20:52 -0500)]
eal/tile: avoid use of non-upstreamed header

It's trivial to directly invoke a read of the special-purpose
register that holds the clock cycle counter, so just do that.

Signed-off-by: Chris Metcalf <cmetcalf@mellanox.com>
7 years agodoc: add default values of install variables
Thomas Monjalon [Fri, 17 Feb 2017 15:55:40 +0000 (16:55 +0100)]
doc: add default values of install variables

The variables DESTDIR and prefix are used with "make install"
to copy the files in $DESTDIR$prefix.
Their default values will be shown when calling "make help".

Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
7 years agodoc: highlight pointed column in NIC overview table
Thomas Monjalon [Mon, 20 Feb 2017 16:04:14 +0000 (17:04 +0100)]
doc: highlight pointed column in NIC overview table

Every cells of a driver column are painted in yellow.

The trick is to generate some empty content as a big column
above and below the pointed cell.

The position: relative attribute is used for the highlight position
but it makes the border to disappear.

The overflow: hidden attribute is used to mask the generated content
outside of the table.

The class .wy-nav-content has a background which masks the highlighting.
Setting an opacity lower than 1, creates a new stack context and let
the column highlight to be shown.

The background of odd rows was grey and opaque. It is redefined with
a transparent alpha ratio in order to see highlighting on such rows.

Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
7 years agodoc: highlight pointed row in NIC overview table
Thomas Monjalon [Mon, 20 Feb 2017 16:14:01 +0000 (17:14 +0100)]
doc: highlight pointed row in NIC overview table

Every cells of a feature row are painted in yellow.

Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
7 years agodoc: set alignments in NIC overview table
Thomas Monjalon [Mon, 18 Apr 2016 12:28:25 +0000 (14:28 +0200)]
doc: set alignments in NIC overview table

Some CSS alignments were not explicitly set.
The pointer is also set to default for the table.

Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
7 years agodevtools: make checkpatch cleaner for renamed files
David Hunt [Mon, 20 Feb 2017 04:08:33 +0000 (04:08 +0000)]
devtools: make checkpatch cleaner for renamed files

When a file is renamed, a normal diff will include all the code of
the renamed file, and checkpatch will find warnings and errors,
even though it's just a rename.

This change will result in a 'rename' line in the diff, resulting
in a much cleaner checkpatches result.

Signed-off-by: David Hunt <david.hunt@intel.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
7 years agomempool: remove deprecated get and put functions
Olivier Matz [Fri, 17 Feb 2017 12:28:27 +0000 (13:28 +0100)]
mempool: remove deprecated get and put functions

As announced in the deprecation notice, remove the functions for
single/multi producer/consumer enqueue/dequeue.

Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
7 years agomempool: remove deprecated count functions
Olivier Matz [Fri, 17 Feb 2017 12:28:26 +0000 (13:28 +0100)]
mempool: remove deprecated count functions

As announced in the deprecation notice, remove these functions.

Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
7 years agomaintainers: fix script paths
Thomas Monjalon [Tue, 21 Feb 2017 10:18:38 +0000 (11:18 +0100)]
maintainers: fix script paths

The directory scripts does not exist anymore.
The files have been moved but some paths were not updated
in the maintainers list.

Fixes: 9a98f50e890b ("scripts: move to devtools")

Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
7 years agolog: remove old symbols from map
Thomas Monjalon [Thu, 16 Feb 2017 08:46:45 +0000 (09:46 +0100)]
log: remove old symbols from map

When removing log history functions, the map has not been updated.

Fixes: d7e61ad3ae36 ("log: remove deprecated history dump")

Reported-by: Olivier Matz <olivier.matz@6wind.com>
Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
7 years agokni: remove KNI vhost support
Ferruh Yigit [Mon, 20 Feb 2017 14:30:24 +0000 (14:30 +0000)]
kni: remove KNI vhost support

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
7 years agodoc: add removed items section to release notes
Ferruh Yigit [Mon, 20 Feb 2017 14:30:23 +0000 (14:30 +0000)]
doc: add removed items section to release notes

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
7 years agoversion: 17.05-rc0
Thomas Monjalon [Fri, 17 Feb 2017 10:42:01 +0000 (11:42 +0100)]
version: 17.05-rc0

Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
7 years agodoc: add template release notes for 17.05
John McNamara [Wed, 15 Feb 2017 12:38:58 +0000 (12:38 +0000)]
doc: add template release notes for 17.05

Add template release notes for DPDK 17.05 with inline
comments and explanations of the various sections.

Signed-off-by: John McNamara <john.mcnamara@intel.com>
Acked-by: Bruce Richardson <bruce.ricahrdson@intel.com>
7 years agomaintainers: claim responsibility for vhost and virtio
Maxime Coquelin [Fri, 17 Feb 2017 08:31:42 +0000 (09:31 +0100)]
maintainers: claim responsibility for vhost and virtio

Add myself as co-maintainer for vhost/virtio drivers
and vhost-user library.

Suggested-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
7 years agoversion: 17.02.0
Thomas Monjalon [Tue, 14 Feb 2017 21:13:04 +0000 (22:13 +0100)]
version: 17.02.0

Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
7 years agodoc: update release notes for 17.02
John McNamara [Tue, 14 Feb 2017 16:26:04 +0000 (16:26 +0000)]
doc: update release notes for 17.02

Fix grammar, spelling and formatting of DPDK 17.02 release notes.

Signed-off-by: John McNamara <john.mcnamara@intel.com>
7 years agodoc: add description of review tags
Harry van Haaren [Tue, 14 Feb 2017 11:50:15 +0000 (11:50 +0000)]
doc: add description of review tags

This commit details what is meant by the various email
tags that the DPDK community use regularly. The descriptions
state what each tag means, drawing from the kernel's understanding[1],
and the discussion on the DPDK mailing list[2].

Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
[1]
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-and-cc

[2] http://dpdk.org/ml/archives/dev/2017-January/thread.html#56300

7 years agodoc: add thread-safety information about EFD library
Pablo de Lara [Tue, 14 Feb 2017 15:02:53 +0000 (15:02 +0000)]
doc: add thread-safety information about EFD library

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
7 years agodoc: announce API change for cryptodev sessions info
Akhil Goyal [Tue, 14 Feb 2017 12:11:14 +0000 (17:41 +0530)]
doc: announce API change for cryptodev sessions info

A new parameter is planned to be added in 17.05 release in
rte_cryptodev_info.sym - max_nb_sessions_per_qp.

This will allow applications to know the maximum number of session
which can be attached to queue_pairs of device.

Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
Acked-by: Declan Doherty <declan.doherty@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
7 years agodoc: announce ABI change for cryptodev configuration
Fan Zhang [Tue, 14 Feb 2017 10:41:06 +0000 (10:41 +0000)]
doc: announce ABI change for cryptodev configuration

Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
Acked-by: Declan Doherty <declan.doherty@intel.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
7 years agodoc: announce KNI vhost removal
Ferruh Yigit [Thu, 17 Nov 2016 13:27:21 +0000 (13:27 +0000)]
doc: announce KNI vhost removal

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
7 years agodoc: announce API changes for vhost
Yuanhan Liu [Mon, 23 Jan 2017 13:04:42 +0000 (21:04 +0800)]
doc: announce API changes for vhost

I made a vhost ABI/API refactoring at v16.04, meant to avoid such issue
forever. Well, apparently, I lied.

People are looking for more vhost-user options now days, other than
vhost-user net only. For example, SPDK (Storage Performance Development
Kit) are looking for chance of vhost-user SCSI and vhost-user block.

Apparently, they also need a vhost-user backend, while DPDK already
has a (mature enough) backend, they don't want to implement it again
from scratch. They want to leverage the one DPDK provides.

However, the last refactoring hasn't done that right, at least it's
not friendly for extending vhost-user to add more devices support.
For example, different virtio devices has its own feature set, while
APIs like rte_vhost_feature_disable(feature_mask) have no option to
tell the device type. Thus, a more proper API should look like:

    rte_vhost_feature_disable(device_type, feature_mask);

Besides that, few public files and structures should be renamed, to
not let it bind to virtio-net. Specifically, they are:

- virtio_net_device_ops --> vhost_device_ops
- rte_virtio_net.h      --> rte_vhost.h

Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>
7 years agodoc: announce move of ethdev bypass function to ixgbe API
Bernard Iremonger [Thu, 5 Jan 2017 15:25:36 +0000 (15:25 +0000)]
doc: announce move of ethdev bypass function to ixgbe API

In 17.05, nine rte_eth_dev_* functions for bypass control,
and implemented only in ixgbe, will be removed from ethdev,
renamed and moved to the ixgbe PMD-specific API.

Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
7 years agodoc: postpone API change in ethdev
Thomas Monjalon [Mon, 13 Feb 2017 14:26:44 +0000 (15:26 +0100)]
doc: postpone API change in ethdev

The change of _rte_eth_dev_callback_process has not been done in 17.02.
Let's postpone to 17.05.

Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Acked-by: Olivier Matz <olivier.matz@6wind.com>
Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
7 years agodoc: announce VFIO symbols renaming for export
Shreyansh Jain [Mon, 13 Feb 2017 12:01:48 +0000 (17:31 +0530)]
doc: announce VFIO symbols renaming for export

Some vfio symbols need to be exported outside librte_eal.
For that, they need to be renamed to rte_* naming convention.

Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
7 years agodoc: announce API changes to implement the bus model
Thomas Monjalon [Mon, 13 Feb 2017 16:20:34 +0000 (17:20 +0100)]
doc: announce API changes to implement the bus model

The new bus model has been proposed in 17.02 without being used.
The big rework should happen in 17.05.

Suggested-by: Shreyansh Jain <shreyansh.jain@nxp.com>
Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
Acked-by: Jan Blunck <jblunck@infradead.org>
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
7 years agodoc: announce ABI change for ring library
Bruce Richardson [Mon, 13 Feb 2017 17:38:30 +0000 (17:38 +0000)]
doc: announce ABI change for ring library

Document proposed changes for the rings code in the next release.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Acked-by: Olivier Matz <olivier.matz@6wind.com>
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
7 years agodoc: announce TILE-Gx removal
Thomas Monjalon [Mon, 13 Feb 2017 10:52:32 +0000 (11:52 +0100)]
doc: announce TILE-Gx removal

Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Acked-by: Olivier Matz <olivier.matz@6wind.com>
Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>
7 years agocfgfile: fix uninitialized variable on load error
Dmitriy Yakovlev [Tue, 7 Feb 2017 02:51:06 +0000 (05:51 +0300)]
cfgfile: fix uninitialized variable on load error

Uninitialized scalar variable.
Using uninitialized value cfg->sections[curr_section]->num_entries
when calling rte_cfgfile_close.
And memory in variables cfg->sections[curr_section],
sect->entries[curr_entry] maybe not equal NULL.
We must decrement counters curr_section, curr_entry when failed to realloc.

Fixes: eaafbad419bf ("cfgfile: library to interpret config files")

Signed-off-by: Dmitriy Yakovlev <bombermag@gmail.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
7 years agodoc: fix images of virtio-user tutorials
Jianfeng Tan [Tue, 14 Feb 2017 11:55:34 +0000 (11:55 +0000)]
doc: fix images of virtio-user tutorials

The images by below two commits are very unclear. Fix it.

Fixes: 50665deebda ("doc: add guide to use virtio-user for container networking")
Fixes: 0ba3870e755 ("doc: add guide to use virtio-user as exceptional path")

Suggested-by: Thomas Monjalon <thomas.monjalon@6wind.com>
Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
7 years agodoc: introduce tested platforms as combinations
Thomas Monjalon [Tue, 14 Feb 2017 13:57:37 +0000 (14:57 +0100)]
doc: introduce tested platforms as combinations

Add some text and rearrange lists to make sure it is clear that the
tested platforms listed in the release notes are some combinations
of the items in each group.

Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
7 years agodoc: add EAL bus support in release notes
Shreyansh Jain [Mon, 13 Feb 2017 11:29:48 +0000 (16:59 +0530)]
doc: add EAL bus support in release notes

Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
7 years agodoc: add tested Intel platforms in the release notes
Yulong Pei [Tue, 14 Feb 2017 04:14:14 +0000 (12:14 +0800)]
doc: add tested Intel platforms in the release notes

Add tested Intel platforms with Intel NICs to the release note.

Signed-off-by: Yulong Pei <yulong.pei@intel.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
7 years agodoc: update release notes for mlx5
Nelio Laranjeiro [Thu, 9 Feb 2017 08:32:01 +0000 (09:32 +0100)]
doc: update release notes for mlx5

Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
7 years agodoc: update release notes for mlx4
Nelio Laranjeiro [Thu, 9 Feb 2017 08:32:00 +0000 (09:32 +0100)]
doc: update release notes for mlx4

Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
7 years agodoc: merge test sections in release notes
Nelio Laranjeiro [Thu, 9 Feb 2017 08:31:59 +0000 (09:31 +0100)]
doc: merge test sections in release notes

These sections do not provide the exact tests that were done nor whether
specific NICs are supported by all platforms.

Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
7 years agovfio: fix maximum number of interrupt for MSI-X
Qi Zhang [Thu, 9 Feb 2017 19:59:43 +0000 (14:59 -0500)]
vfio: fix maximum number of interrupt for MSI-X

The max number of interrupt request is possible
be changed after rte_intr_callback_register, so
in get_max_intr, we need to check if necessary to
update the max_intr.

Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
7 years agoethdev: fix typo in UDP tunnel API description
Andrew Rybchenko [Mon, 13 Feb 2017 10:32:23 +0000 (10:32 +0000)]
ethdev: fix typo in UDP tunnel API description

Fixes: 1cbe755fef47 ("ethdev: rename UDP tunnel port functions")

Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
7 years agodoc: add distributor library API change notice
David Hunt [Mon, 6 Feb 2017 08:08:29 +0000 (08:08 +0000)]
doc: add distributor library API change notice

Given that the packet distributor library improvements (1) will
not be in 17.02, I plan on doing some consolidation of the
API for burst operation for 17.05, merging the two api's into
one, with options for single or burst operation.

(1) http://dpdk.org/dev/patchwork/patch/19911/

Signed-off-by: David Hunt <david.hunt@intel.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
7 years agodoc: remove deprecation notice for bus abstraction
Shreyansh Jain [Mon, 13 Feb 2017 11:55:44 +0000 (17:25 +0530)]
doc: remove deprecation notice for bus abstraction

Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
7 years agodoc: postpone ABI changes to 17.05
Olivier Matz [Mon, 13 Feb 2017 11:05:26 +0000 (12:05 +0100)]
doc: postpone ABI changes to 17.05

Postpone the ABI changes for mempool and mbuf that were planned
for 17.02 to 17.05.

Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
7 years agodoc: remove announce of Tx preparation
Thomas Monjalon [Mon, 13 Feb 2017 10:54:34 +0000 (11:54 +0100)]
doc: remove announce of Tx preparation

The feature is part of 17.02, so the ABI changes notice can be removed.

Fixes: 4fb7e803eb1a ("ethdev: add Tx preparation")

Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
7 years agoversion: 17.02-rc3
Thomas Monjalon [Fri, 10 Feb 2017 16:15:32 +0000 (17:15 +0100)]
version: 17.02-rc3

Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
7 years agodoc: clarify multi-buffer crypto library version support
Pablo de Lara [Fri, 10 Feb 2017 12:33:42 +0000 (12:33 +0000)]
doc: clarify multi-buffer crypto library version support

AES-NI MB PMD uses external Multi-Buffer library,
which is hosted in github, but the version was not specified
in the documentation.

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Acked-by: Deepak Kumar Jain <deepak.k.jain@intel.com>
7 years agocrypto/scheduler: fix session backup
Fan Zhang [Thu, 9 Feb 2017 18:46:21 +0000 (18:46 +0000)]
crypto/scheduler: fix session backup

Fixes the missed session backup during enqueue.

Fixes: 100e4f7e44ab ("crypto/scheduler: add round-robin mode")

Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
7 years agocrypto/scheduler: fix initialization
Fan Zhang [Thu, 9 Feb 2017 18:49:59 +0000 (18:49 +0000)]
crypto/scheduler: fix initialization

Fixes the wrong slave initialization issue on start-up

Fixes: 100e4f7e44ab ("crypto/scheduler: add round-robin mode")

Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
7 years agoapp/crypto-perf: fix null dereference
Slawomir Mrozowicz [Fri, 10 Feb 2017 14:22:30 +0000 (15:22 +0100)]
app/crypto-perf: fix null dereference

Dereferencing a pointer that might be null key_token when calling strstr.
Check if the pointer is null before.

Coverity issue: 141071
Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application")

Signed-off-by: Slawomir Mrozowicz <slawomirx.mrozowicz@intel.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
7 years agoapp/crypto-perf: fix size of expression
Jacek Piasecki [Fri, 10 Feb 2017 13:26:15 +0000 (14:26 +0100)]
app/crypto-perf: fix size of expression

This commit fixes problem of passing a pointer to sizeof() function.
Now the size of enabled_cdevs structure is passed by RTE_CRYPTO_MAX_DEVS.

Coverity issue: 141068
Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application")

Signed-off-by: Jacek Piasecki <jacekx.piasecki@intel.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
7 years agoapp/crypto-perf: fix crash for wireless algorithms
Slawomir Mrozowicz [Thu, 9 Feb 2017 13:57:29 +0000 (14:57 +0100)]
app/crypto-perf: fix crash for wireless algorithms

This commit fixes segmentation fault that happens when
using KASUMI, SNOW3G or ZUC authentication algorithms,
as they need authentication keys and was not being set.
It also set value of authentication key to cipher key
when using GMAC algorithm.

Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application")

Signed-off-by: Slawomir Mrozowicz <slawomirx.mrozowicz@intel.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
7 years agoapp/crypto-perf: fix uninitialized variable
Aleksander Gajewski [Fri, 10 Feb 2017 09:22:32 +0000 (10:22 +0100)]
app/crypto-perf: fix uninitialized variable

This commit ixes problem with uninitialized nb_cryptodevs variable by
initialize it with 0 value. Program could jump to err label
without running cperf_initialize_cryptodev() function. Also assign 0
value to nb_cryptodevs after cperf_initialize_cryptodev() when value is
negative.

Coverity issue: 141073
Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application")

Signed-off-by: Aleksander Gajewski <aleksanderx.gajewski@intel.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
7 years agoexamples/l2fwd-crypto: fix padding
Pablo de Lara [Thu, 9 Feb 2017 12:27:45 +0000 (12:27 +0000)]
examples/l2fwd-crypto: fix padding

L2fwd-crypto app was padding an incoming buffer,
to be aligned with the algorithm block size, in all cases.
This was not the right approach, as padding is only necessary
when using block cipher algorithms, such as AES-CBC.
In case of using a stream cipher algorithm, such as SNOW3G UEA2,
there is no need to include padding and increase the buffer size.

Fixes: 387259bd6c67 ("examples/l2fwd-crypto: add sample application")

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
7 years agoexamples/l2fwd-crypto: fix overflow
Pablo de Lara [Tue, 7 Feb 2017 14:17:25 +0000 (14:17 +0000)]
examples/l2fwd-crypto: fix overflow

This commit fixes an array overflow when number of crypto devices
is higher than 32.

Fixes: 387259bd6c67 ("examples/l2fwd-crypto: add sample application")

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
7 years agoapp/crypto-perf: fix big parameter passed by value
Jacek Piasecki [Wed, 8 Feb 2017 16:04:40 +0000 (17:04 +0100)]
app/crypto-perf: fix big parameter passed by value

Structure opts and structure test_vec are now passed by  pointer to
the cperf_check_test_vector.

Coverity issue: 141072
Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application")

Signed-off-by: Jacek Piasecki <jacekx.piasecki@intel.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
7 years agodrivers/crypto: fix different auth/cipher keys
Pablo de Lara [Tue, 7 Feb 2017 22:49:58 +0000 (22:49 +0000)]
drivers/crypto: fix different auth/cipher keys

When ciphering and authenticating in the same operation
(cipher-then-auth or auth-then-cipher),
the cipher key and authentication key were set with the same
key, in SNOW3G, KASUMI and ZUC PMDs.
They were using the key of the first transform structure,
instead of using the keys of the two different transform
structures.

This is not a big issue, since usually, the same key is
used for ciphering and authentication, but keys may be different.

Fixes: 3aafc423cf4d ("snow3g: add driver for SNOW 3G library")
Fixes: 2773c86d061a ("crypto/kasumi: add driver for KASUMI library")
Fixes: cf7685d68f00 ("crypto/zuc: add driver for ZUC library")
Cc: stable@dpdk.org
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Acked-by: Deepak Kumar Jain <deepak.k.jain@intel.com>
7 years agodoc: add limitations section to cryptoperf guide
Fiona Trahe [Tue, 7 Feb 2017 16:32:55 +0000 (16:32 +0000)]
doc: add limitations section to cryptoperf guide

Add limitations to use of the dpdk-test-crypto-perf
tool for hardware accelerator measurements

Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
Acked-by: Slawomir Mrozowicz <slawomirx.mrozowicz@intel.com>
7 years agoapp/crypto-perf: add options parsing check
Kuba Kozak [Tue, 7 Feb 2017 12:20:16 +0000 (13:20 +0100)]
app/crypto-perf: add options parsing check

Added total_ops value validation in parse_total_ops() function.

Coverity issue: 141070
Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application")

Signed-off-by: Kuba Kozak <kubax.kozak@intel.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
7 years agoapp/crypto-perf: fix string not null terminated
Aleksander Gajewski [Tue, 7 Feb 2017 09:20:18 +0000 (10:20 +0100)]
app/crypto-perf: fix string not null terminated

This commit fixes the case where the string buffer may not have
a null terminator if the source string's length is equal to the
buffer size.

Coverity issue: 141069
Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application")

Signed-off-by: Aleksander Gajewski <aleksanderx.gajewski@intel.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
7 years agocryptodev: fix crash when querying device by name
Slawomir Mrozowicz [Fri, 3 Feb 2017 15:55:02 +0000 (16:55 +0100)]
cryptodev: fix crash when querying device by name

This patch fixes a segmentation fault in function
rte_cryptodev_devices_get(), due to incorrect driver name path.
It reworks the function to use correct types and clean up
for visibility.

Coverity issue: 141067
Fixes: 38227c0e3ad2 ("cryptodev: retrieve device info")

Signed-off-by: Slawomir Mrozowicz <slawomirx.mrozowicz@intel.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
7 years agocrypto/aesni_mb: add missing digest length
Pablo de Lara [Fri, 27 Jan 2017 13:16:08 +0000 (13:16 +0000)]
crypto/aesni_mb: add missing digest length

AESNI MB now supports authentication only operations,
but the array containing all the possible digest lengths
was not updated to reflect the new algorithm NULL_HASH,
causing an "Out-of-bounds access".

Coverity issue: 140977
Fixes: 8772c3f713e2 ("crypto/aesni_mb: add single operation functionality")

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Acked-by: Declan Doherty <declan.doherty@intel.com>
7 years agonet/i40e: fix TC bandwidth definition
Wenzhuo Lu [Fri, 10 Feb 2017 05:25:53 +0000 (13:25 +0800)]
net/i40e: fix TC bandwidth definition

The range of TC bandwidth is 0 ~ 800, it's 16bits not 8bits.

Fixes: c8b9a3e3fe1b ("i40e: support DCB mode")
Cc: stable@dpdk.org
Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
7 years agonet/ixgbe: fix VLAN mask TCI in flow rule parser
Wei Zhao [Fri, 10 Feb 2017 01:37:58 +0000 (09:37 +0800)]
net/ixgbe: fix VLAN mask TCI in flow rule parser

Use vlan_mask->tci as big endian since this is how rte flow defines it.

Fixes: 11777435c727 ("net/ixgbe: parse flow director filter")
Fixes: 37ed39b4e67d ("net/ixgbe: add TCI mask check for flow director")

Signed-off-by: Wei Zhao <wei.zhao1@intel.com>