dpdk.git
5 years agodoc: announce parameter change of a service API function
Nikhil Rao [Tue, 22 Jan 2019 05:44:26 +0000 (11:14 +0530)]
doc: announce parameter change of a service API function

rte_service_attr_get() is passed a uint32_t * to retrieve
an attribute value, this will be changed to uin64_t * as per
patch posted at http://patchwork.dpdk.org/patch/49968/

Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
Acked-by: Kevin Traynor <ktraynor@redhat.com>
Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
Acked-by: David Marchand <david.marchand@redhat.com>
5 years agodoc: announce meson version upgrade
Bruce Richardson [Wed, 16 Jan 2019 11:37:13 +0000 (11:37 +0000)]
doc: announce meson version upgrade

Add a notice in the deprecation section of the release notes to call out
the fact that the minimum supported meson version for DPDK will change
from 19.05 onwards.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Luca Boccassi <bluca@debian.org>
Acked-by: Timothy Redaelli <tredaelli@redhat.com>
Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
Acked-by: Thomas Monjalon <thomas@monjalon.net>
5 years agodoc: remove note about meson being experimental
Bruce Richardson [Wed, 30 Jan 2019 16:43:44 +0000 (16:43 +0000)]
doc: remove note about meson being experimental

At this stage, meson builds are widely supported for DPDK, and so
the build system should be no longer called out as experimental.
NOTE: this does not imply it's the primary build system, just that
it's safe to use for day-to-day work and for packaging if so
desired.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
5 years agodoc: clarify libnuma requirement for NUMA systems
Anatoly Burakov [Thu, 31 Jan 2019 17:05:51 +0000 (17:05 +0000)]
doc: clarify libnuma requirement for NUMA systems

Since 18.05, libnuma is pretty much required on Linux when using
non-legacy mode, because without it, we cannot know where our
hugepages are located [1].

In legacy mode, libnuma is not required because we can still sort
pages by sockets, as we use pagemap lookup method to figure out
socket ID's for pages.

So, document libnuma as required for NUMA systems and non-legacy
mode.

[1] https://mails.dpdk.org/archives/dev/2018-December/120490.html

Fixes: 6b42f75632f0 ("eal: enable non-legacy memory mode")
Cc: stable@dpdk.org
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
Acked-by: Kevin Traynor <ktraynor@redhat.com>
5 years agomaintainers: resign from maintainership of link bonding
Declan Doherty [Mon, 28 Jan 2019 12:57:19 +0000 (12:57 +0000)]
maintainers: resign from maintainership of link bonding

I've been unable to dedicate enough time to actively help in the
maintainership of the link bonding PMD, and as Chas is now actively
maintaining this PMD, I'm removing my name against it in the
MAINTAINERS file.

Signed-off-by: Declan Doherty <declan.doherty@intel.com>
5 years agodoc: improve Mellanox bifurcated model description
Thomas Monjalon [Wed, 30 Jan 2019 11:20:20 +0000 (12:20 +0100)]
doc: improve Mellanox bifurcated model description

In the howto guide about flow bifurcation, the Mellanox case
(which does not require specific details) was missing in the landscape.

In the Linux drivers guide, it was not clear that the flow bifurcation
is performed in the NIC hardware.

References to flow isolated mode are also inserted in those contexts.

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Shahaf Shuler <shahafs@mellanox.com>
5 years agodoc: add references to flow isolated mode in NICs guide
Thomas Monjalon [Wed, 30 Jan 2019 11:20:19 +0000 (12:20 +0100)]
doc: add references to flow isolated mode in NICs guide

Some drivers (mlx, mvpp2, sfc) support the flow isolated mode,
but the feature was not advertised.
A reference to the feature description is added for each driver.

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Shahaf Shuler <shahafs@mellanox.com>
5 years agodoc: remove useless anchor for flow API guide
Thomas Monjalon [Wed, 30 Jan 2019 11:20:18 +0000 (12:20 +0100)]
doc: remove useless anchor for flow API guide

A doc page (.rst file) can be referenced with :doc: syntax
instead of :ref: to .. anchor.

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Shahaf Shuler <shahafs@mellanox.com>
5 years agodoc: add release notes for mlx5
Yongseok Koh [Wed, 30 Jan 2019 07:53:21 +0000 (23:53 -0800)]
doc: add release notes for mlx5

Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
Acked-by: Shahaf Shuler <shahafs@mellanox.com>
5 years agodoc: add Mellanox EN support in mlx5 guide
Yongseok Koh [Wed, 30 Jan 2019 07:53:20 +0000 (23:53 -0800)]
doc: add Mellanox EN support in mlx5 guide

Mellanox EN package is supported along with Mellanox OFED. Mellanox EN is
distriubuted for Ethernet users.

Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
Acked-by: Shahaf Shuler <shahafs@mellanox.com>
5 years agodoc: add mlx5 note for Bluefield build configuration
Yongseok Koh [Wed, 30 Jan 2019 07:53:19 +0000 (23:53 -0800)]
doc: add mlx5 note for Bluefield build configuration

Fixes: d14e4e976f65 ("config: add Mellanox BlueField armv8 SoC")
Cc: stable@dpdk.org
Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
Acked-by: Shahaf Shuler <shahafs@mellanox.com>
5 years agonet/mlx5: fix build for armv8
Viacheslav Ovsiienko [Mon, 28 Jan 2019 14:22:14 +0000 (14:22 +0000)]
net/mlx5: fix build for armv8

Added <rte_cycles.h> inclusion, was not included on some
building setups (armv8).

Fixes: 71ab2d64723c ("net/mlx5: fix VXLAN port registration race condition")
Cc: stable@dpdk.org
Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
Acked-by: Shahaf Shuler <shahafs@mellanox.com>
5 years agoversion: 19.02-rc4
Thomas Monjalon [Mon, 28 Jan 2019 01:36:47 +0000 (02:36 +0100)]
version: 19.02-rc4

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
5 years agodoc: add tested platforms with Mellanox NICs
Raslan Darawsheh [Thu, 24 Jan 2019 12:23:16 +0000 (12:23 +0000)]
doc: add tested platforms with Mellanox NICs

Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
5 years agodoc: add tested Intel platforms with Intel NICs
Lijuan Tu [Fri, 18 Jan 2019 15:15:01 +0000 (23:15 +0800)]
doc: add tested Intel platforms with Intel NICs

Add tested Intel platforms with Intel NICs to v19.02 release note.

Signed-off-by: Lijuan Tu <lijuan.tu@intel.com>
Acked-by: Marko Kovacevic <marko.kovacevic@intel.com>
5 years agodoc: add dependency for PDF in contributing guide
Rami Rosen [Sun, 20 Jan 2019 18:29:47 +0000 (20:29 +0200)]
doc: add dependency for PDF in contributing guide

There is a missing depenency for building docs with "make doc-guides-pdf".
This causes it to break with "make[3]: latexmk: Command not found". This
was observed and reported in https://bugs.dpdk.org/show_bug.cgi?id=182
This patch fixes this issue by adding the latexmk package dependency in
sub-section 4.3.1 of the contributing guide ("Dependencies").

Bugzilla ID: 182
Cc: stable@dpdk.org
Signed-off-by: Rami Rosen <ramirose@gmail.com>
5 years agobuild: mention -march in pkg-config description
Luca Boccassi [Thu, 10 Jan 2019 17:28:06 +0000 (17:28 +0000)]
build: mention -march in pkg-config description

Applications need to at least match DPDK's -march option to build
successfully due to some static inline functions in the public headers.

This might cause problems, especially in distributions, so add a note
in the pkg-config description.

Fixes: a25a650be5f0 ("build: add infrastructure for meson and ninja builds")
Cc: stable@dpdk.org
Signed-off-by: Luca Boccassi <bluca@debian.org>
Reviewed-by: Gavin Hu <gavin.hu@arm.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
5 years agousertools: make telemetry script executable
Bruce Richardson [Tue, 22 Jan 2019 16:27:32 +0000 (16:27 +0000)]
usertools: make telemetry script executable

Add #! line to the top of the script and mark it as executable so it can
be run directly rather than having to pass it to python interpreter.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
5 years agolpm: remove recursively included header file
Congwen Zhang [Thu, 10 Jan 2019 01:32:22 +0000 (20:32 -0500)]
lpm: remove recursively included header file

includes itself: rte_lpm.h -> rte_lpm_sse.h -> rte_lpm.h
includes itself: rte_lpm.h -> rte_lpm_neon.h -> rte_lpm.h

Signed-off-by: Congwen Zhang <zhang.congwen@zte.com.cn>
5 years agombuf: fix struct initialization with C++
Ed Czeck [Thu, 24 Jan 2019 14:36:37 +0000 (09:36 -0500)]
mbuf: fix struct initialization with C++

g++ reports "error: missing initializer for member"

Fixes: 5d3f72100904 ("mbuf: implement generic format for sched field")

Signed-off-by: Ed Czeck <ed.czeck@atomicrules.com>
5 years agocrypto/qat: fix digest in wireless auth case
Fiona Trahe [Fri, 25 Jan 2019 16:59:00 +0000 (16:59 +0000)]
crypto/qat: fix digest in wireless auth case

When operation calls for auth (digest generation), followed by
encryption of both data plus digest, the digest-in-buffer
flag must be set for QAT.

Fixes: 39e0bee48e81 ("crypto/qat: rework request builder for performance")
Cc: stable@dpdk.org
Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
Acked-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
5 years agodoc: add instructions for WC in ENAv2
Rafal Kozik [Fri, 25 Jan 2019 08:10:28 +0000 (09:10 +0100)]
doc: add instructions for WC in ENAv2

ENAv2 hardware provides Low Latency Queue v2 (LLQv2). It needs kernel
PCI driver to support write combining (WC). This patch add information
how to use it with igb_uio and vfio-pci drivers.

Signed-off-by: Rafal Kozik <rk@semihalf.com>
Acked-by: Michal Krawczyk <mk@semihalf.com>
5 years agodoc: update release notes for ENA PMD
Rafal Kozik [Fri, 25 Jan 2019 08:10:27 +0000 (09:10 +0100)]
doc: update release notes for ENA PMD

Add changes in ENA PMD to DPDK v19.02 release notes.

Signed-off-by: Michal Krawczyk <mk@semihalf.com>
Signed-off-by: Rafal Kozik <rk@semihalf.com>
5 years agonet/ena: fix errno to positive value
Michal Krawczyk [Fri, 25 Jan 2019 08:10:26 +0000 (09:10 +0100)]
net/ena: fix errno to positive value

The rte_errno shouldn't have assigned negative error codes, so it has
to be fixed.

Fixes: b3fc5a1ae10d ("net/ena: add Tx preparation")
Cc: stable@dpdk.org
Signed-off-by: Michal Krawczyk <mk@semihalf.com>
5 years agonet/ena: fix dev init with multi-process
Michal Krawczyk [Fri, 25 Jan 2019 08:10:25 +0000 (09:10 +0100)]
net/ena: fix dev init with multi-process

The check for proc type in eth_ena_dev_init() should appear before
modyfing adapter structure.

Calling memset on ena_adapter from secondary process context, was
erasing all structure information, and it was causing the crash of the
main process.

Fixes: 1173fca25af9 ("ena: add polling-mode driver")
Cc: stable@dpdk.org
Signed-off-by: Michal Krawczyk <mk@semihalf.com>
5 years agonet/ena: remove lcore constraint from max queue number
Michal Krawczyk [Fri, 25 Jan 2019 08:10:24 +0000 (09:10 +0100)]
net/ena: remove lcore constraint from max queue number

The number of queues was limited by number of lcores in the recent ENAv2
patch. However, some apps like symmetric_mp, are configuring multiple
queues although there is only single lcore used.

To prevent failure in that case, the lcore number constraint was
removed.

Fixes: ea93d37eb49d ("net/ena: add HW queues depth setup")

Signed-off-by: Michal Krawczyk <mk@semihalf.com>
5 years agonet/mlx5: fix VXLAN without decap action for E-Switch
Viacheslav Ovsiienko [Fri, 25 Jan 2019 15:29:35 +0000 (15:29 +0000)]
net/mlx5: fix VXLAN without decap action for E-Switch

There is an intention to support VXLAN tunnel match without
hardware offloaded decapsulation, just to redirect ingress
tunnelled frame untouched. This small fix allows to specify
Flows with VXLAN VNI pattern and with or without following
decapsulation action.

Fixes: 251e8d02cf37 ("net/mlx5: add VXLAN to flow translate routine")
Cc: stable@dpdk.org
Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
Acked-by: Shahaf Shuler <shahafs@mellanox.com>
5 years agonet/sfc: fix port ID log
Ivan Malov [Thu, 24 Jan 2019 15:20:16 +0000 (15:20 +0000)]
net/sfc: fix port ID log

Log port ID as 16-bit unsigned integer.

Fixes: f8244c6399d9 ("ethdev: increase port id range")
Cc: stable@dpdk.org
Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
5 years agonet/i40e: fix statistics
Chenmin Sun [Wed, 23 Jan 2019 13:30:03 +0000 (21:30 +0800)]
net/i40e: fix statistics

1. Fix the lldp stop condition check - for firmware
versions 6.01(for X710)/3.33(for X722) or later we need stop the lldp
2. deferred stats reset in dev_init to avoid some noise be counted.
3. Document known issue for tx bytes decreasing due to link status change

Fixes: 044846f071cc ("net/i40e: stop LLDP before setting local LLDP MIB")
Cc: stable@dpdk.org
Signed-off-by: Chenmin Sun <chenmin.sun@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
5 years agonet/mlx5: fix VXLAN port registration race condition
Viacheslav Ovsiienko [Wed, 23 Jan 2019 07:51:18 +0000 (07:51 +0000)]
net/mlx5: fix VXLAN port registration race condition

E-Switch VXLAN tunneling rules require virtual VXLAN network
devices be created. These devices are managed by MLX5 PMD and
created/deleted dynamically.

Kernel creates the VXLAN devices and registers VXLAN UDP ports
to be hardware offloaded within the NIC kernel drivers. The
registration process is being performed into context of working
kernel thread and the race conditions might happen.

The VXLAN device is created and success code is returned to calling
application, but the UDP port registration process is not completed
yet and the next applied rule might be rejected by the driver with
ENOSUP code. This patch adds some timeout for new created devices,
allowing port registration process to be completed. The waiting
is performed once after device been created and first rule is being
applied.

Fixes: 95a464cecc21 ("net/mlx5: add E-switch VXLAN tunnel devices management")
Cc: stable@dpdk.org
Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
Acked-by: Shahaf Shuler <shahafs@mellanox.com>
5 years agonet/mlx5: fix TC rule handle assignment
Viacheslav Ovsiienko [Tue, 22 Jan 2019 12:05:46 +0000 (12:05 +0000)]
net/mlx5: fix TC rule handle assignment

When tc rule is created via Netlink message application
can provide the unique rule value which can be accepted
by the kernel. Than rule is managed with this assigned
handle. It was found that kernel can reject the proposed
handle and assign its own handle value, the rule control
is lost, because application uses its initially prorosed
rule handle and knows nothing about handle been repleced.

The kernel can assign handle automatically, the application
can get the assigned handle value by specifying NLM_F_ECHO
flag in Netlink message when rule is being created. The
kernel sends back the full descriptor of rule and handle
can be retrieved from and stored by application for further
rule management.

Fixes: 57123c00c1b8 ("net/mlx5: add Linux TC flower driver for E-Switch flow")
Cc: stable@dpdk.org
Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
Acked-by: Shahaf Shuler <shahafs@mellanox.com>
5 years agonet/mlx5: block RSS action without Rx queue
Dekel Peled [Tue, 22 Jan 2019 08:22:24 +0000 (10:22 +0200)]
net/mlx5: block RSS action without Rx queue

This patch modifies function mlx5_flow_validate_action_rss(), to
prevent the setting of rule with rss action, but without specifying
any queues.
For example:
flow create 0 ingress pattern end actions rss queues end / end

Signed-off-by: Dekel Peled <dekelp@mellanox.com>
Acked-by: Shahaf Shuler <shahafs@mellanox.com>
5 years agonet/mlx5: allow port start with zero Rx queue
Dekel Peled [Tue, 22 Jan 2019 08:21:55 +0000 (10:21 +0200)]
net/mlx5: allow port start with zero Rx queue

During port start, function mlx5_ctrl_flow_vlan() is called to create
default ingress flow rules.
For specific use-cases, a port can be used for Tx only.
In such case, number of Rx queues can be set to 0 to save resources,
hence the default ingress rules are irrelevant.

This patch modifies function mlx5_ctrl_flow_vlan() to avoid the
creation of the default ingress rules when number of Rx queues is 0.
It also includes update of validation functions for relevant actions,
mlx5_flow_validate_action_queue() and mlx5_flow_validate_action_rss(),
to prevent creation of flow rules with these actions when number of Rx
queues is 0.

Signed-off-by: Dekel Peled <dekelp@mellanox.com>
Acked-by: Shahaf Shuler <shahafs@mellanox.com>
5 years agonet/virtio-user: fix used ring in cvq handling
Tiwei Bie [Tue, 22 Jan 2019 17:01:43 +0000 (01:01 +0800)]
net/virtio-user: fix used ring in cvq handling

When updating used ring, the id in used element should be the
index of the first desc in the desc chain.

Fixes: f9b9d1a55775 ("net/virtio-user: add multiple queues in device emulation")
Cc: stable@dpdk.org
Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
5 years agonet/virtio: use virtio barrier in packed ring
Tiwei Bie [Tue, 22 Jan 2019 17:01:42 +0000 (01:01 +0800)]
net/virtio: use virtio barrier in packed ring

Always use the virtio variants which support the platform
memory ordering.

Fixes: 9230ab8d7913 ("net/virtio: support platform memory ordering")

Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
Acked-by: Ilya Maximets <i.maximets@samsung.com>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
5 years agonet/virtio-user: fix control VQ
Tiwei Bie [Tue, 22 Jan 2019 17:01:41 +0000 (01:01 +0800)]
net/virtio-user: fix control VQ

This patch fixed below issues in the packed ring based control
vq support in virtio user:

1. The idx_hdr should be used_idx instead of the id in the desc;
2. We just need to write out a single used descriptor for each
   descriptor list;
3. The avail/used bits should be initialized to 0;

Meanwhile, make the function name consistent with other parts.

Fixes: 48a4464029a7 ("net/virtio-user: support control VQ for packed")

Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
5 years agonet/virtio: fix control VQ
Tiwei Bie [Tue, 22 Jan 2019 17:01:40 +0000 (01:01 +0800)]
net/virtio: fix control VQ

This patch mainly fixed below issues in the packed ring based
control vq support in virtio driver:

1. When parsing the used descriptors, we have to track the
   number of descs that we need to skip;
2. vq->vq_free_cnt was decreased twice for a same desc;

Meanwhile, make the function name consistent with other parts.

Fixes: ec194c2f1895 ("net/virtio: support packed queue in send command")
Fixes: a4270ea4ff79 ("net/virtio: check head desc with correct wrap counter")

Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
5 years agoapp/testpmd: fix Tx metadata show command
Dekel Peled [Tue, 22 Jan 2019 15:16:43 +0000 (17:16 +0200)]
app/testpmd: fix Tx metadata show command

Function cmd_config_tx_metadata_specific_parsed() takes input value,
applies rte_cpu_to_be_32() on it, and stores it for Tx use.
Function cmd_show_tx_metadata_parsed() displays the stored value as is.

This patch modifies function cmd_show_tx_metadata_parsed(), to apply
rte_be_to_cpu_32() on the stored value before displaying it.

Fixes: c18feafa193c ("app/testpmd: support metadata as flow rule item")
Cc: stable@dpdk.org
Signed-off-by: Dekel Peled <dekelp@mellanox.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
5 years agonet/sfc: fix crash in EF10 TSO if no payload
Igor Romanov [Wed, 23 Jan 2019 13:08:55 +0000 (13:08 +0000)]
net/sfc: fix crash in EF10 TSO if no payload

Fixes: 6bc985e41155 ("net/sfc: support TSO in EF10 Tx datapath")
Cc: stable@dpdk.org
Signed-off-by: Igor Romanov <igor.romanov@oktetlabs.ru>
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
5 years agonet/ice: fix link speed
Wenzhuo Lu [Wed, 23 Jan 2019 05:30:29 +0000 (13:30 +0800)]
net/ice: fix link speed

Fix the issue that the link speed is unknown.

Fixes: 690175ee51bf ("net/ice: support getting device information")
Fixes: cf911d90e366 ("net/ice: support link update")

Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
5 years agonet/ice: support promiscuous mode
Wenzhuo Lu [Wed, 23 Jan 2019 02:37:01 +0000 (10:37 +0800)]
net/ice: support promiscuous mode

Enable the APIs for unicast and multicast promiscuous
mode setting.

Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
5 years agonet/mlx4: fix creation of flow rule w/o ETH spec
Dekel Peled [Thu, 17 Jan 2019 12:12:19 +0000 (14:12 +0200)]
net/mlx4: fix creation of flow rule w/o ETH spec

The original commit enabled the creation of flow rule with empty
ETH address and with specific VLAN.
It works fine on PF, but such flow rule is still rejected on VF due
to kernel limitation, which blocks MAC address of all zeroes.

This patch complements the original commit.
It sets byte 0 of MAC address to 0xFF.

Fixes: c0d239263156 ("net/mlx4: support flow w/o ETH spec and with VLAN")

Signed-off-by: Dekel Peled <dekelp@mellanox.com>
Acked-by: Shahaf Shuler <shahafs@mellanox.com>
5 years agovhost: fix access for indirect descriptors
Tiwei Bie [Mon, 21 Jan 2019 08:12:18 +0000 (16:12 +0800)]
vhost: fix access for indirect descriptors

Fix a possible out of bound access which may happen when handling
indirect descs in split ring.

Fixes: 1be4ebb1c464 ("vhost: support indirect descriptor in mergeable Rx")
Cc: stable@dpdk.org
Reported-by: Haiyue Wang <haiyue.wang@intel.com>
Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
5 years agonet/i40e: fix queue region DCB configure
Wei Zhao [Tue, 22 Jan 2019 08:11:03 +0000 (16:11 +0800)]
net/i40e: fix queue region DCB configure

DCB is not necessary to be configured if no user priority of
queue region is requested.

Unexpected configuration of DCB will cause unexpected behavior, like
FDIR does not work on those queues, but could cause more issues.

Fixes: 7cbecc2f7424 ("net/i40e: support queue region set and flush")
Cc: stable@dpdk.org
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
Tested-by: Yuan Peng <yuan.peng@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
5 years agotest: check zero socket memory as valid
Ilya Maximets [Fri, 25 Jan 2019 07:55:58 +0000 (10:55 +0300)]
test: check zero socket memory as valid

Dynamic memory mode allowes zero socket-mem because all the
required memory could be allocated on demand.

Fixes: 0a703f0f36c1 ("eal/linux: fix parsing zero socket memory and limits")
Cc: stable@dpdk.org
Reported-by: Shuai Zhu <shuaix.zhu@intel.com>
Signed-off-by: Ilya Maximets <i.maximets@samsung.com>
Reviewed-by: David Marchand <david.marchand@redhat.com>
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
5 years agoeal/linux: fix parsing zero socket memory and limits
Ilya Maximets [Tue, 22 Jan 2019 16:27:14 +0000 (19:27 +0300)]
eal/linux: fix parsing zero socket memory and limits

Modern memory mode allowes to not reserve any memory by the
'--socket-mem' option. i.e. it could be possible to specify
zero preallocated memory like '--socket-mem 0'.
Also, it should be possible to configure unlimited memory
allocations by '--socket-limit 0'.

Both cases are impossible now and blocks starting the DPDK
application:

    ./dpdk-app --socket-limit 0 <...>
    EAL: invalid parameters for --socket-limit
    EAL: Invalid 'command line' arguments.
    Unable to initialize DPDK: Invalid argument

Fixes: 6b42f75632f0 ("eal: enable non-legacy memory mode")
Cc: stable@dpdk.org
Signed-off-by: Ilya Maximets <i.maximets@samsung.com>
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
5 years agovfio: fix error message
Alejandro Lucero [Wed, 23 Jan 2019 10:00:48 +0000 (10:00 +0000)]
vfio: fix error message

The message refers to uio driver.

Fixes: ff0b67d1c868 ("vfio: DMA mapping")
Cc: stable@dpdk.org
Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
5 years agokni: fix build for igb_ndo_bridge_setlink in Linux 5.0
Ferruh Yigit [Tue, 22 Jan 2019 15:44:29 +0000 (15:44 +0000)]
kni: fix build for igb_ndo_bridge_setlink in Linux 5.0

Build error seen with Linux kernel 5.0 and
when CONFIG_RTE_KNI_KMOD_ETHTOOL is enabled.

build error:
.../build/build/kernel/linux/kni/igb_main.c:2348:24:
  error: initialization of
  â€˜int (*)(struct net_device *, struct nlmsghdr *, u16,
   struct netlink_ext_ack *)’
  {aka â€˜int (*)(struct net_device *, struct nlmsghdr *,
   short unsigned int,  struct netlink_ext_ack *)’}
  from incompatible pointer type
  â€˜int (*)(struct net_device *, struct nlmsghdr *, u16)’
  {aka â€˜int (*)(struct net_device *, struct nlmsghdr *,
   short unsigned int)’}
  [-Werror=incompatible-pointer-types]
  .ndo_bridge_setlink = igb_ndo_bridge_setlink,
                        ^~~~~~~~~~~~~~~~~~~~~~
.../build/build/kernel/linux/kni/igb_main.c:2348:24:
  note: (near initialization for â€˜igb_netdev_ops.ndo_bridge_setlink’)

igb_ndo_bridge_setlink() is changed in Linux kernel version 5.0
and now requires a new parameter, 'struct netlink_ext_ack *extack'.
Fixed by adding a new parameter with a kernel version check.

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
5 years agokni: fix build for dev_open in Linux 5.0
Ferruh Yigit [Tue, 22 Jan 2019 15:44:28 +0000 (15:44 +0000)]
kni: fix build for dev_open in Linux 5.0

Build error seen with Linux kernel 5.0 and
when CONFIG_RTE_KNI_KMOD_ETHTOOL is enabled.

build error:
.../build/build/kernel/linux/kni/ixgbe_ethtool.c:1746:4:
  error: too few arguments to function â€˜dev_open’
    dev_open(netdev);
    ^~~~~~~~
In file included from .../build/kernel/linux/kni/ixgbe_ethtool.c:18:
.../linux/linux/include/linux/netdevice.h:2620:5: note: declared here
 int dev_open(struct net_device *dev, struct netlink_ext_ack *extack);
     ^~~~~~~~

.../build/build/kernel/linux/kni/igb_ethtool.c:1812:4:
  error: too few arguments to function â€˜dev_open’
    dev_open(netdev);
    ^~~~~~~~
In file included from .../build/build/kernel/linux/kni/igb_ethtool.c:15:
.../linux/linux/include/linux/netdevice.h:2620:5: note: declared here
 int dev_open(struct net_device *dev, struct netlink_ext_ack *extack);
     ^~~~~~~~

dev_open() is changed in Linux kernel version 5.0 and now requires
a new parameter, 'struct netlink_ext_ack *extack'.
Fixed by defining dev_open as macro when kernel version >= 5.0

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
5 years agoexamples/fips_validation: fix physical address
Fan Zhang [Fri, 18 Jan 2019 09:15:57 +0000 (09:15 +0000)]
examples/fips_validation: fix physical address

This patch fixes the missed digest and aad data physical
addresses filling to crypto operations in fips_validation
sample application.

Fixes: 41d561cbdd24 ("examples/fips_validation: add power on self test")

Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
Acked-by: Marko Kovacevic <marko.kovacevic@intel.com>
5 years agocrypto/aesni_mb: fix build with custom dependency path
Fan Zhang [Mon, 21 Jan 2019 15:56:11 +0000 (15:56 +0000)]
crypto/aesni_mb: fix build with custom dependency path

This patch fixes the inflexible compile issue AESNI-MB PMD.
Originally the compile of the PMD will fail if IPSec_MB is
not installed in default location.

Fixes: c68d7aa354f6 ("crypto/aesni_mb: use architecture independent macros")

Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Tested-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
5 years agogso: fix VxLAN/GRE tunnel checks
Andrew Rybchenko [Mon, 21 Jan 2019 06:42:38 +0000 (06:42 +0000)]
gso: fix VxLAN/GRE tunnel checks

Tunnel type is an enum in PKT_TX_TUNNEL_MASK bits.
As the result, for example, IPIP or MPLSinUDP tunnel packets may be
incorrectly treated internally as VXLAN.

Fixes: b058d92ea95d ("gso: support VxLAN GSO")
Fixes: 70e737e448c7 ("gso: support GRE GSO")
Cc: stable@dpdk.org
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
Acked-by: Jiayu Hu <jiayu.hu@intel.com>
5 years agoethdev: fix errno to have positive value
Andrew Rybchenko [Mon, 21 Jan 2019 16:18:35 +0000 (16:18 +0000)]
ethdev: fix errno to have positive value

rte_errno should be set to positive value from errno.h plus
few RTE-specific values.

Fixes: 4fb7e803eb1a ("ethdev: add Tx preparation")
Fixes: 439a90b5f2a7 ("ethdev: reorder inline functions")
Cc: stable@dpdk.org
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
5 years agovfio: allow secondary process to query IOMMU type
Anatoly Burakov [Fri, 18 Jan 2019 10:24:41 +0000 (10:24 +0000)]
vfio: allow secondary process to query IOMMU type

It is only possible to know IOMMU type of a given VFIO container
by attempting to initialize it. Since secondary process never
attempts to set up VFIO container itself (because they're shared
between primary and secondary), it never knows which IOMMU type
the container is using, and never sets up the appropriate config
structures. This results in inability to perform DMA mappings in
secondary process.

Fix this by allowing secondary process to query IOMMU type of
primary's default container at device initialization.

Note that this fix is assuming we're only interested in default
container.

Bugzilla ID: 174
Fixes: 6bcb7c95fe14 ("vfio: share default container in multi-process")
Cc: stable@dpdk.org
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
5 years agoversion: 19.02-rc3
Thomas Monjalon [Sun, 20 Jan 2019 21:39:20 +0000 (22:39 +0100)]
version: 19.02-rc3

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
5 years agotest/metrics: fix a negative case
Harman Kalra [Mon, 10 Dec 2018 08:39:15 +0000 (08:39 +0000)]
test/metrics: fix a negative case

Negative test case for passing invalid count size to
rte_metrics_update_values() will pass if count value
is any value greater than 1 because set size wrt to
key id 1 is 1 and passing 0 as no of values to be
updated will not hit the ERANGE check.

Fixes: cd3804242901 ("test/metrics: add unit tests for metrics library")
Cc: stable@dpdk.org
Signed-off-by: Harman Kalra <hkalra@marvell.com>
Acked-by: Remy Horton <remy.horton@intel.com>
5 years agodoc: update qat compression guide
Tomasz Jozwiak [Mon, 14 Jan 2019 15:11:21 +0000 (16:11 +0100)]
doc: update qat compression guide

Added limitations description for the QAT compression PMD.
Updated intermediate buffers description in qat.rst file.

Signed-off-by: Tomasz Jozwiak <tomaszx.jozwiak@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
5 years agodoc: add GCM AAD limitation in qat guide
Fiona Trahe [Thu, 17 Jan 2019 18:23:19 +0000 (18:23 +0000)]
doc: add GCM AAD limitation in qat guide

Add limitation that AAD buffer must be padded with zeroes
in GCM case.

Fixes: d4f44265a1d7 ("doc: add limitation of AAD size to QAT guide")
Cc: stable@dpdk.org
Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
Acked-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
5 years agodoc: add intel_pstate in power management
David Hunt [Tue, 15 Jan 2019 14:17:00 +0000 (14:17 +0000)]
doc: add intel_pstate in power management

With the addition of the patchset to allow auto-detection and use
of the intel_pstate kernel driver instead of the acpi-cpufreq kernel
driver, we need to reflect this in the documentation.

Now, instead of telling the user to disable intel_pstate in all cases,
it is now an optional step, should the user want to use acpi-cpufreq.

Signed-off-by: David Hunt <david.hunt@intel.com>
Acked-by: Marko Kovacevic <marko.kovacevic@intel.com>
5 years agodoc: fix references in power management guide
David Hunt [Fri, 18 Jan 2019 09:34:24 +0000 (09:34 +0000)]
doc: fix references in power management guide

In the References section in the Power Management overview,
both links pointed to the same l3fwd-power app. Fix the links
so that one points to l3fwd-power, and the other points to
the vm_power_manager sample app.

Signed-off-by: David Hunt <david.hunt@intel.com>
Acked-by: Marko Kovacevic <marko.kovacevic@intel.com>
5 years agodoc: update recommended BIOS settings in Linux guide
David Hunt [Tue, 15 Jan 2019 15:19:59 +0000 (15:19 +0000)]
doc: update recommended BIOS settings in Linux guide

Update recommended BIOS settings for performance to be more appropriate
for a wider variety of applications, and allow users to select the most
appropriate settings for their use case, e.g. some users may wish to
have Turbo Boost enabled.

Signed-off-by: David Hunt <david.hunt@intel.com>
Acked-by: Marko Kovacevic <marko.kovacevic@intel.com>
5 years agodoc: remove file listings
David Marchand [Fri, 18 Jan 2019 15:31:00 +0000 (16:31 +0100)]
doc: remove file listings

No need to keep those file listings, they are very likely to become
outdated.

Signed-off-by: David Marchand <david.marchand@redhat.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Acked-by: Marko Kovacevic <marko.kovacevic@intel.com>
5 years agodoc: increase minimal supported Linux version
Thomas Monjalon [Wed, 16 Jan 2019 11:45:35 +0000 (12:45 +0100)]
doc: increase minimal supported Linux version

Update the Linux user guide to restrict the supported kernels
to reasonnably recent enough versions.

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
5 years agotest: reorder test cases in meson
Hari Kumar Vemula [Fri, 18 Jan 2019 17:40:44 +0000 (17:40 +0000)]
test: reorder test cases in meson

Categorize testcases into suites:
- test cases that runs quickly
- performance test cases
- test cases that depend on specific drivers
- logging or dump related test cases

Signed-off-by: Hari Kumar Vemula <hari.kumarx.vemula@intel.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
5 years agonet/qede: remove prefetch in Tx path
Shahed Shaikh [Fri, 18 Jan 2019 10:29:30 +0000 (02:29 -0800)]
net/qede: remove prefetch in Tx path

Incorrect placement of prefetch in Tx path is causing
a performance drop of around ~2% on AMD platform.

Fixes: 2ea6f76aff40 ("qede: add core driver")
Cc: stable@dpdk.org
Signed-off-by: Shahed Shaikh <shshaikh@marvell.com>
Acked-by: Rasesh Mody <rmody@marvell.com>
5 years agonet/qede: fix performance bottleneck in Rx path
Shahed Shaikh [Fri, 18 Jan 2019 10:29:29 +0000 (02:29 -0800)]
net/qede: fix performance bottleneck in Rx path

Allocating replacement buffer per received packet is expensive.
Instead, process received packets first and allocate
replacement buffers in bulk later.

This improves performance by ~25% in terms of PPS on AMD
platforms.

Fixes: 2ea6f76aff40 ("qede: add core driver")
Cc: stable@dpdk.org
Signed-off-by: Shahed Shaikh <shshaikh@marvell.com>
Acked-by: Rasesh Mody <rmody@marvell.com>
5 years agoraw/ifpga: fix memory leak
Andy Pei [Fri, 18 Jan 2019 11:14:33 +0000 (11:14 +0000)]
raw/ifpga: fix memory leak

When ifpga_rawdev_create() allocate memory for a new rawdev,
the original code allocate redundant memory for adapter,
which is a member of the rawdev. What is actually necessary is
the adapter to be initialized, not memory allocated.

Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver")
Cc: stable@dpdk.org
Signed-off-by: Andy Pei <andy.pei@intel.com>
Acked-by: Tianfei Zhang <tianfei.zhang@intel.com>
Acked-by: Rosen Xu <rosen.xu@intel.com>
5 years agobus/ifpga: fix AFU probe failure handler
Andy Pei [Fri, 18 Jan 2019 11:12:33 +0000 (11:12 +0000)]
bus/ifpga: fix AFU probe failure handler

In the original code, when an AFU device probe a driver,
if the first driver in the driver list does not support
this device or some error happens, bus probe returns an error.

With this patch, a device will try to match driver in the driver
list one by one until an appropriate driver is found.

If some error happens, the error is returned. If the current driver
does not support the device, just try the next driver in the list.

If all the drivers in the list are tried and no driver matches,
0 is returned. Otherwise, the error code is returned.

Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library")
Cc: stable@dpdk.org
Signed-off-by: Andy Pei <andy.pei@intel.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Acked-by: Rosen Xu <rosen.xu@intel.com>
5 years agobus/ifpga: fix forcing optional devargs
Andy Pei [Fri, 18 Jan 2019 11:07:01 +0000 (11:07 +0000)]
bus/ifpga: fix forcing optional devargs

Original driver requires users to input "afu_bts" args.
But driver can also work without an explicit "afu_bts" args.

Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library")
Cc: stable@dpdk.org
Signed-off-by: Andy Pei <andy.pei@intel.com>
Acked-by: Rosen Xu <rosen.xu@intel.com>
5 years agobus/ifpga: fix build for cpp applications
Andy Pei [Fri, 18 Jan 2019 11:09:33 +0000 (11:09 +0000)]
bus/ifpga: fix build for cpp applications

Brackets unmatch when __cplusplus defined.

Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library")
Cc: stable@dpdk.org
Signed-off-by: Andy Pei <andy.pei@intel.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
5 years agocompress/isal: fix build with old library version
Lee Daly [Thu, 17 Jan 2019 21:10:45 +0000 (21:10 +0000)]
compress/isal: fix build with old library version

This patch removes an unnecessary flag which was breaking the
build with older versions of the ISA-L library (v2.23 and older)
and replace with a more appropriate flag which is present
in older versions of library.

Fixes: bd03d3f1e4f1 ("compress/isal: enable checksum support")

Signed-off-by: Lee Daly <lee.daly@intel.com>
Tested-by: Harry van Haaren <harry.van.haaren@intel.com>
5 years agoefd: fix tail queue leak
Hari Kumar Vemula [Fri, 18 Jan 2019 07:40:42 +0000 (07:40 +0000)]
efd: fix tail queue leak

In rte_efd_create() allocated memory for tail queue entry but
not freed.
Added freeing the tail queue entry.

Fixes: 56b6ef874f80 ("efd: new Elastic Flow Distributor library")
Cc: stable@dpdk.org
Signed-off-by: Hari Kumar Vemula <hari.kumarx.vemula@intel.com>
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Acked-by: Reshma Pattan <reshma.pattan@intel.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
5 years agodoc: update recommended versions for i40e
Lijuan Tu [Fri, 18 Jan 2019 15:25:24 +0000 (23:25 +0800)]
doc: update recommended versions for i40e

add recommended DPDK/kernel driver/firmware version matching list for
i40e for 19.02

Signed-off-by: Lijuan Tu <lijuan.tu@intel.com>
5 years agoethdev: report error on ring name truncation
Nithin Dabilpuram [Thu, 17 Jan 2019 14:13:54 +0000 (14:13 +0000)]
ethdev: report error on ring name truncation

Currently this api doesn't report error if name is
truncated and so user is not sure about uniqueness
of name. This change reports error to help user.

Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
Acked-by: Thomas Monjalon <thomas@monjalon.net>
5 years agodoc: add missing loopback option in testpmd guide
Rami Rosen [Thu, 17 Jan 2019 11:39:26 +0000 (13:39 +0200)]
doc: add missing loopback option in testpmd guide

This patch adds a missing topology "loop" mode for port-topology
option in testpmd guide. The testpmd "loop" option
(PORT_TOPOLOGY_LOOP)  was added to testpmd parameter
port-topology back in 2014, but it seems that it was never added
to the testpmd guide. This patch adds it in the testpmd guide.

Fixes: 3e2006d6186c ("app/testpmd: add loopback topology")
Cc: stable@dpdk.org
Signed-off-by: Rami Rosen <ramirose@gmail.com>
Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
5 years agodoc: fix ifc naming
Rami Rosen [Thu, 17 Jan 2019 14:50:31 +0000 (16:50 +0200)]
doc: fix ifc naming

This patch fixes an error in ifc NIC document; a previous patch
changed the semantics to use CONFIG_RTE_LIBRTE_IFC_PMD
instead of CONFIG_RTE_LIBRTE_IFCVF_VDPA_PMD,
but the ifc NIC doc file remained with the old name.

Fixes: 4b614e9504a1 ("net/ifc: make driver name consistent")
Cc: stable@dpdk.org
Signed-off-by: Rami Rosen <ramirose@gmail.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
5 years agonet/sfc: fix Rx packets counter
Andrew Rybchenko [Thu, 17 Jan 2019 06:17:32 +0000 (06:17 +0000)]
net/sfc: fix Rx packets counter

Errors, missed and pauses should not be included in delivered
good Rx packets reported by ipackets.

Fixes: 1caab2f1e684 ("net/sfc: add basic statistics")
Cc: stable@dpdk.org
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
5 years agoexamples/vhost_crypto: fix session private mempool
Fan Zhang [Tue, 15 Jan 2019 10:38:08 +0000 (10:38 +0000)]
examples/vhost_crypto: fix session private mempool

This patch fixes the incorrect session private mempool passing
to cryptodev.

Fixes: ac5e42daca19 ("vhost/crypto: use separate session mempools")

Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
5 years agoexamples/vhost: fix path allocation failure handling
Tiwei Bie [Tue, 15 Jan 2019 07:13:24 +0000 (15:13 +0800)]
examples/vhost: fix path allocation failure handling

Add the missing failure handling for path allocation,
as realloc() may fail.

Fixes: ad0eef4d2203 ("examples/vhost: support multiple socket files")
Cc: stable@dpdk.org
Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
5 years agovhost: fix memory leak on realloc failure
Tiwei Bie [Tue, 15 Jan 2019 07:13:23 +0000 (15:13 +0800)]
vhost: fix memory leak on realloc failure

When realloc() fails, the original block isn't freed.

Fixes: e246896178e6 ("vhost: get guest/host physical address mappings")
Cc: stable@dpdk.org
Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
5 years agovhost: remove unused function prototype
Xiaolong Ye [Tue, 15 Jan 2019 06:48:13 +0000 (14:48 +0800)]
vhost: remove unused function prototype

vhost_user_host_notifier_ctrl is not existed anymore, its statement in
header file should be removed accordingly.

Fixes: 43f34e35663f ("vhost: provide helper for host notifier ctrl")

Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>
5 years agovhost: configure vDPA device after set vring call message
Xiaolong Ye [Mon, 14 Jan 2019 07:34:24 +0000 (15:34 +0800)]
vhost: configure vDPA device after set vring call message

As qemu will only send VHOST_USER_SET_VRING_ENABLE message for guest
enabled vrings (only first queue pair will be enabled at initialized
stage), this will cause trouble for multiqueue case, vDPA's dev_conf
callback will get no chance be invoked. Decouple the dev_conf callback from
VHOST_USER_SET_VRING_ENABLE solves this issue.

Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
5 years agonet/ice/base: free flow profile entries
Qi Zhang [Wed, 16 Jan 2019 14:13:38 +0000 (22:13 +0800)]
net/ice/base: free flow profile entries

Free flow profile entries when free HW tables.

Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
Signed-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
5 years agonet/ice/base: add flow module
Qi Zhang [Wed, 16 Jan 2019 14:13:37 +0000 (22:13 +0800)]
net/ice/base: add flow module

Add the module that implemented flow abstraction that base on
flexible pipeline.

Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
Signed-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
5 years agonet/ice/base: add flexible pipeline module
Qi Zhang [Wed, 16 Jan 2019 14:13:36 +0000 (22:13 +0800)]
net/ice/base: add flexible pipeline module

The flexible pipeline module provide the infrastructure for ice's
flexible packet processing feature.

Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
Signed-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
5 years agonet/ice/base: add some helper macros
Qi Zhang [Wed, 16 Jan 2019 14:13:35 +0000 (22:13 +0800)]
net/ice/base: add some helper macros

Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
Signed-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
5 years agonet/ice/base: add package download related data structure
Qi Zhang [Wed, 16 Jan 2019 14:13:34 +0000 (22:13 +0800)]
net/ice/base: add package download related data structure

Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
Signed-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
5 years agonet/ice/base: support resource allocation
Qi Zhang [Wed, 16 Jan 2019 14:13:33 +0000 (22:13 +0800)]
net/ice/base: support resource allocation

Added API ice_alloc_hw_res and ice_free_hw_res.
Added resource type macro.

Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
Signed-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
5 years agonet/ice/base: clean up
Qi Zhang [Wed, 16 Jan 2019 14:13:32 +0000 (22:13 +0800)]
net/ice/base: clean up

Remove some unnecessary code.

Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
Signed-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
5 years agonet/sfc: fix datapath name references in logs
Ivan Malov [Wed, 16 Jan 2019 12:24:40 +0000 (12:24 +0000)]
net/sfc: fix datapath name references in logs

Rx and Tx datapath references were mixed up in a couple
of log statements and commentary blocks in the original
commit. Correct datapath name references in said places.

Fixes: f28ede500c2e ("net/sfc: support multi-process")
Cc: stable@dpdk.org
Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
5 years agonet/sfc: fix VF error/missed stats mapping
Andrew Rybchenko [Wed, 16 Jan 2019 09:43:23 +0000 (09:43 +0000)]
net/sfc: fix VF error/missed stats mapping

VADAPTER_RX_OVERFLOW means Rx statistics overflow, not a missed
packet because of overflow.

VADAPTER_RX_BAD_PACKETS accumulates a number of error conditions,
but mainly impossibility to deliver because of no descriptors
available, so it is better to classify it as imissed.

Fixes: 1caab2f1e684 ("net/sfc: add basic statistics")
Cc: stable@dpdk.org
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
5 years agonet/mlx5: fix deprecated library API for Rx padding
Yongseok Koh [Tue, 15 Jan 2019 17:38:59 +0000 (09:38 -0800)]
net/mlx5: fix deprecated library API for Rx padding

In rdma-core library IBV_WQ_FLAG_RX_END_PADDING is renamed to
IBV_WQ_FLAGS_PCI_WRITE_END_PADDING. Way to query the capability is also
changed.

Fixes: 43e9d9794cde ("net/mlx5: support upstream rdma-core")
Cc: stable@dpdk.org
Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
Reviewed-by: Erez Ferber <erezf@mellanox.com>
Acked-by: Shahaf Shuler <shahafs@mellanox.com>
5 years agonet/mlx5: fix Rx packet padding
Yongseok Koh [Tue, 15 Jan 2019 17:38:58 +0000 (09:38 -0800)]
net/mlx5: fix Rx packet padding

Rx packet padding is supposed to be set by an environment variable -
MLX5_PMD_ENABLE_PADDING, but it has been missing for some time by mistake.
Rather than using such a variable, a PMD parameter (rxq_pkt_pad_en) is
added instead.

Fixes: a1366b1a2be3 ("net/mlx5: add reference counter on DPDK Rx queues")
Cc: stable@dpdk.org
Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
Reviewed-by: Erez Ferber <erezf@mellanox.com>
Acked-by: Shahaf Shuler <shahafs@mellanox.com>
5 years agonet/i40e: support request any number of queues
Zhirun Yan [Tue, 15 Jan 2019 14:57:17 +0000 (14:57 +0000)]
net/i40e: support request any number of queues

Before this patch, VF must request a specific queues(1/2/4/8/16) with
DPDK PF. This patch align the number of requested queues to next power
of 2. So VF can request any number queues from 1 to 16.

Signed-off-by: Zhirun Yan <zhirun.yan@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
5 years agonet/i40e: fix VF overwrite PF RSS LUT for X722
Yanglong Wu [Tue, 15 Jan 2019 02:23:45 +0000 (10:23 +0800)]
net/i40e: fix VF overwrite PF RSS LUT for X722

i40e_aq_set_rss_lut should set register according
to the vsi->type. if not, VF may overwrite the rigister
of PF.
Note, only X722 is impacted, since flag I40E_FLAG_RSS_AQ_CAPABLE
is only enabled on X722.

Fixes: d0a349409bd7 ("i40e: support AQ based RSS config")
Cc: stable@dpdk.org
Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
5 years agotest/pdump: add unit test for pdump library
Naga Suresh Somarowthu [Mon, 8 Oct 2018 12:12:47 +0000 (13:12 +0100)]
test/pdump: add unit test for pdump library

Unit test cases are added for pdump library.
Primary process will act as server, forks a child secondary process.
Secondary process acts as client.
Server will do pdump init to serve any pdump client requests.
Server will create a vdev, send/receive packets continuously
in a separate thread.
Client will create virtual rings to receive the packet dump.
Client sends pdump enable/disable requests using either port/device id.
Packet flow direction can be tx/rx/tx&rx.
In Server, appropriate pdump callbacks are triggered,
when packets are transmitted/received.
Pdump packet is copied to client rings.

Signed-off-by: Naga Suresh Somarowthu <naga.sureshx.somarowthu@intel.com>
Reviewed-by: Reshma Pattan <reshma.pattan@intel.com>
5 years agotest/latency: add unit tests for latencystats library
Naga Suresh Somarowthu [Mon, 8 Oct 2018 12:12:46 +0000 (13:12 +0100)]
test/latency: add unit tests for latencystats library

Unit Test Cases added for latencystats library.

Signed-off-by: Naga Suresh Somarowthu <naga.sureshx.somarowthu@intel.com>
Reviewed-by: Reshma Pattan <reshma.pattan@intel.com>
5 years agotest/bitrate: add unit tests for bitrate library
Naga Suresh Somarowthu [Mon, 8 Oct 2018 12:12:45 +0000 (13:12 +0100)]
test/bitrate: add unit tests for bitrate library

Unit Test Cases for BitRate library.

Signed-off-by: Naga Suresh Somarowthu <naga.sureshx.somarowthu@intel.com>
Reviewed-by: Reshma Pattan <reshma.pattan@intel.com>
Reviewed-by: Remy Horton <remy.horton@intel.com>
5 years agotest: add helpers using ring PMD Rx/Tx
Naga Suresh Somarowthu [Mon, 8 Oct 2018 12:12:44 +0000 (13:12 +0100)]
test: add helpers using ring PMD Rx/Tx

Added ring pmd based packet rx/tx helper functions
for verifying Latency, Bitrate and pdump lib UTs.

Signed-off-by: Naga Suresh Somarowthu <naga.sureshx.somarowthu@intel.com>
Reviewed-by: Reshma Pattan <reshma.pattan@intel.com>
Reviewed-by: Anatoly Burakov <anatoly.burakov@intel.com>
5 years agotest/compress: add varied buffer input/outputs
Marko Kovacevic [Thu, 17 Jan 2019 10:19:12 +0000 (10:19 +0000)]
test/compress: add varied buffer input/outputs

Added unit test to check if a SGL buffer
was added as an input and a Linear Buffer
as output and vice versa so we can test if the
application would process the different buffers
properly.

Signed-off-by: Marko Kovacevic <marko.kovacevic@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
Acked-by: Lee Daly <lee.daly@intel.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>