Chris Metcalf [Sat, 18 Feb 2017 01:52:27 +0000 (20:52 -0500)]
net/mpipe: remove requirement for non-upstreamed headers
These headers are not part of the set that are upstreamed as part
of glibc or the kernel, and we only need a few defines from each.
The hardware is frozen so these values are not going to change
in any case.
Signed-off-by: Chris Metcalf <cmetcalf@mellanox.com>
Thomas Monjalon [Fri, 17 Feb 2017 15:55:40 +0000 (16:55 +0100)]
doc: add default values of install variables
The variables DESTDIR and prefix are used with "make install"
to copy the files in $DESTDIR$prefix.
Their default values will be shown when calling "make help".
Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com> Acked-by: John McNamara <john.mcnamara@intel.com>
Thomas Monjalon [Mon, 20 Feb 2017 16:04:14 +0000 (17:04 +0100)]
doc: highlight pointed column in NIC overview table
Every cells of a driver column are painted in yellow.
The trick is to generate some empty content as a big column
above and below the pointed cell.
The position: relative attribute is used for the highlight position
but it makes the border to disappear.
The overflow: hidden attribute is used to mask the generated content
outside of the table.
The class .wy-nav-content has a background which masks the highlighting.
Setting an opacity lower than 1, creates a new stack context and let
the column highlight to be shown.
The background of odd rows was grey and opaque. It is redefined with
a transparent alpha ratio in order to see highlighting on such rows.
Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com> Acked-by: John McNamara <john.mcnamara@intel.com>
David Hunt [Mon, 20 Feb 2017 04:08:33 +0000 (04:08 +0000)]
devtools: make checkpatch cleaner for renamed files
When a file is renamed, a normal diff will include all the code of
the renamed file, and checkpatch will find warnings and errors,
even though it's just a rename.
This change will result in a 'rename' line in the diff, resulting
in a much cleaner checkpatches result.
Signed-off-by: David Hunt <david.hunt@intel.com> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Maxime Coquelin [Fri, 17 Feb 2017 08:31:42 +0000 (09:31 +0100)]
maintainers: claim responsibility for vhost and virtio
Add myself as co-maintainer for vhost/virtio drivers
and vhost-user library.
Suggested-by: Yuanhan Liu <yuanhan.liu@linux.intel.com> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com> Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com> Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
Harry van Haaren [Tue, 14 Feb 2017 11:50:15 +0000 (11:50 +0000)]
doc: add description of review tags
This commit details what is meant by the various email
tags that the DPDK community use regularly. The descriptions
state what each tag means, drawing from the kernel's understanding[1],
and the discussion on the DPDK mailing list[2].
Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com> Acked-by: John McNamara <john.mcnamara@intel.com>
[1]
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-and-cc
Ferruh Yigit [Thu, 17 Nov 2016 13:27:21 +0000 (13:27 +0000)]
doc: announce KNI vhost removal
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com> Acked-by: John McNamara <john.mcnamara@intel.com> Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com> Acked-by: Bruce Richardson <bruce.richardson@intel.com> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Yuanhan Liu [Mon, 23 Jan 2017 13:04:42 +0000 (21:04 +0800)]
doc: announce API changes for vhost
I made a vhost ABI/API refactoring at v16.04, meant to avoid such issue
forever. Well, apparently, I lied.
People are looking for more vhost-user options now days, other than
vhost-user net only. For example, SPDK (Storage Performance Development
Kit) are looking for chance of vhost-user SCSI and vhost-user block.
Apparently, they also need a vhost-user backend, while DPDK already
has a (mature enough) backend, they don't want to implement it again
from scratch. They want to leverage the one DPDK provides.
However, the last refactoring hasn't done that right, at least it's
not friendly for extending vhost-user to add more devices support.
For example, different virtio devices has its own feature set, while
APIs like rte_vhost_feature_disable(feature_mask) have no option to
tell the device type. Thus, a more proper API should look like:
Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com> Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com> Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com> Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>
doc: announce move of ethdev bypass function to ixgbe API
In 17.05, nine rte_eth_dev_* functions for bypass control,
and implemented only in ixgbe, will be removed from ethdev,
renamed and moved to the ixgbe PMD-specific API.
Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com> Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com> Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
Thomas Monjalon [Mon, 13 Feb 2017 10:52:32 +0000 (11:52 +0100)]
doc: announce TILE-Gx removal
Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com> Acked-by: Bruce Richardson <bruce.richardson@intel.com> Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com> Acked-by: Olivier Matz <olivier.matz@6wind.com> Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Uninitialized scalar variable.
Using uninitialized value cfg->sections[curr_section]->num_entries
when calling rte_cfgfile_close.
And memory in variables cfg->sections[curr_section],
sect->entries[curr_entry] maybe not equal NULL.
We must decrement counters curr_section, curr_entry when failed to realloc.
Jianfeng Tan [Tue, 14 Feb 2017 11:55:34 +0000 (11:55 +0000)]
doc: fix images of virtio-user tutorials
The images by below two commits are very unclear. Fix it.
Fixes: 50665deebda ("doc: add guide to use virtio-user for container networking") Fixes: 0ba3870e755 ("doc: add guide to use virtio-user as exceptional path") Suggested-by: Thomas Monjalon <thomas.monjalon@6wind.com> Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com> Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com> Acked-by: John McNamara <john.mcnamara@intel.com>
Thomas Monjalon [Tue, 14 Feb 2017 13:57:37 +0000 (14:57 +0100)]
doc: introduce tested platforms as combinations
Add some text and rearrange lists to make sure it is clear that the
tested platforms listed in the release notes are some combinations
of the items in each group.
Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com> Acked-by: John McNamara <john.mcnamara@intel.com>
Qi Zhang [Thu, 9 Feb 2017 19:59:43 +0000 (14:59 -0500)]
vfio: fix maximum number of interrupt for MSI-X
The max number of interrupt request is possible
be changed after rte_intr_callback_register, so
in get_max_intr, we need to check if necessary to
update the max_intr.
David Hunt [Mon, 6 Feb 2017 08:08:29 +0000 (08:08 +0000)]
doc: add distributor library API change notice
Given that the packet distributor library improvements (1) will
not be in 17.02, I plan on doing some consolidation of the
API for burst operation for 17.05, merging the two api's into
one, with options for single or burst operation.
(1) http://dpdk.org/dev/patchwork/patch/19911/
Signed-off-by: David Hunt <david.hunt@intel.com> Acked-by: Bruce Richardson <bruce.richardson@intel.com> Acked-by: Harry van Haaren <harry.van.haaren@intel.com> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Fan Zhang [Thu, 9 Feb 2017 18:46:21 +0000 (18:46 +0000)]
crypto/scheduler: fix session backup
Fixes the missed session backup during enqueue.
Fixes: 100e4f7e44ab ("crypto/scheduler: add round-robin mode") Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Fan Zhang [Thu, 9 Feb 2017 18:49:59 +0000 (18:49 +0000)]
crypto/scheduler: fix initialization
Fixes the wrong slave initialization issue on start-up
Fixes: 100e4f7e44ab ("crypto/scheduler: add round-robin mode") Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Jacek Piasecki [Fri, 10 Feb 2017 13:26:15 +0000 (14:26 +0100)]
app/crypto-perf: fix size of expression
This commit fixes problem of passing a pointer to sizeof() function.
Now the size of enabled_cdevs structure is passed by RTE_CRYPTO_MAX_DEVS.
Coverity issue: 141068 Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application") Signed-off-by: Jacek Piasecki <jacekx.piasecki@intel.com> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
app/crypto-perf: fix crash for wireless algorithms
This commit fixes segmentation fault that happens when
using KASUMI, SNOW3G or ZUC authentication algorithms,
as they need authentication keys and was not being set.
It also set value of authentication key to cipher key
when using GMAC algorithm.
Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application") Signed-off-by: Slawomir Mrozowicz <slawomirx.mrozowicz@intel.com> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
This commit ixes problem with uninitialized nb_cryptodevs variable by
initialize it with 0 value. Program could jump to err label
without running cperf_initialize_cryptodev() function. Also assign 0
value to nb_cryptodevs after cperf_initialize_cryptodev() when value is
negative.
Coverity issue: 141073 Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application") Signed-off-by: Aleksander Gajewski <aleksanderx.gajewski@intel.com> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Pablo de Lara [Thu, 9 Feb 2017 12:27:45 +0000 (12:27 +0000)]
examples/l2fwd-crypto: fix padding
L2fwd-crypto app was padding an incoming buffer,
to be aligned with the algorithm block size, in all cases.
This was not the right approach, as padding is only necessary
when using block cipher algorithms, such as AES-CBC.
In case of using a stream cipher algorithm, such as SNOW3G UEA2,
there is no need to include padding and increase the buffer size.
Fixes: 387259bd6c67 ("examples/l2fwd-crypto: add sample application") Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com> Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
Pablo de Lara [Tue, 7 Feb 2017 14:17:25 +0000 (14:17 +0000)]
examples/l2fwd-crypto: fix overflow
This commit fixes an array overflow when number of crypto devices
is higher than 32.
Fixes: 387259bd6c67 ("examples/l2fwd-crypto: add sample application") Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com> Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
Jacek Piasecki [Wed, 8 Feb 2017 16:04:40 +0000 (17:04 +0100)]
app/crypto-perf: fix big parameter passed by value
Structure opts and structure test_vec are now passed by pointer to
the cperf_check_test_vector.
Coverity issue: 141072 Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application") Signed-off-by: Jacek Piasecki <jacekx.piasecki@intel.com> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Pablo de Lara [Tue, 7 Feb 2017 22:49:58 +0000 (22:49 +0000)]
drivers/crypto: fix different auth/cipher keys
When ciphering and authenticating in the same operation
(cipher-then-auth or auth-then-cipher),
the cipher key and authentication key were set with the same
key, in SNOW3G, KASUMI and ZUC PMDs.
They were using the key of the first transform structure,
instead of using the keys of the two different transform
structures.
This is not a big issue, since usually, the same key is
used for ciphering and authentication, but keys may be different.
Fixes: 3aafc423cf4d ("snow3g: add driver for SNOW 3G library") Fixes: 2773c86d061a ("crypto/kasumi: add driver for KASUMI library") Fixes: cf7685d68f00 ("crypto/zuc: add driver for ZUC library") Cc: stable@dpdk.org Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com> Acked-by: Deepak Kumar Jain <deepak.k.jain@intel.com>
Kuba Kozak [Tue, 7 Feb 2017 12:20:16 +0000 (13:20 +0100)]
app/crypto-perf: add options parsing check
Added total_ops value validation in parse_total_ops() function.
Coverity issue: 141070 Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application") Signed-off-by: Kuba Kozak <kubax.kozak@intel.com> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
This commit fixes the case where the string buffer may not have
a null terminator if the source string's length is equal to the
buffer size.
Coverity issue: 141069 Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application") Signed-off-by: Aleksander Gajewski <aleksanderx.gajewski@intel.com> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
This patch fixes a segmentation fault in function
rte_cryptodev_devices_get(), due to incorrect driver name path.
It reworks the function to use correct types and clean up
for visibility.
Coverity issue: 141067 Fixes: 38227c0e3ad2 ("cryptodev: retrieve device info") Signed-off-by: Slawomir Mrozowicz <slawomirx.mrozowicz@intel.com> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Pablo de Lara [Fri, 27 Jan 2017 13:16:08 +0000 (13:16 +0000)]
crypto/aesni_mb: add missing digest length
AESNI MB now supports authentication only operations,
but the array containing all the possible digest lengths
was not updated to reflect the new algorithm NULL_HASH,
causing an "Out-of-bounds access".
Coverity issue: 140977 Fixes: 8772c3f713e2 ("crypto/aesni_mb: add single operation functionality") Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com> Acked-by: Declan Doherty <declan.doherty@intel.com>
Shahaf Shuler [Thu, 9 Feb 2017 12:29:54 +0000 (14:29 +0200)]
net/mlx5: fix link status query
Trying to query the link status through the new ETHTOOL_GLINKSETTINGS
ioctl available since Linux 4.5 was always failing due to a kernel bug
fixed since version 4.9.
This commit also addresses a common issue where the headers version used
at compile time differs from that of the kernel on the target system, by
always defining missing symbols and moving the kernel version check at run
time.
Fixes: 188408719888 ("net/mlx5: fix support for newer link speeds") CC: stable@dpdk.org Signed-off-by: Shahaf Shuler <shahafs@mellanox.com> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Jianbo Liu [Thu, 9 Feb 2017 04:05:26 +0000 (12:05 +0800)]
net/ixgbe: fix received packets number for ARM NEON
Vector PMD will check 4 descs in one time, but the statuses are not
consistent because the memory allocated for RX descriptors is cacheable
huagepage.
This patch is to calculate the number of received packets by scann DD bit
sequentially, and stops when meeting the first packet with DD bit unset.
Fixes: b20971b6cca0 ("net/ixgbe: implement vector driver for ARM") Cc: stable@dpdk.org Signed-off-by: Jianbo Liu <jianbo.liu@linaro.org>
Jianbo Liu [Thu, 9 Feb 2017 04:05:25 +0000 (12:05 +0800)]
net/ixgbe: fix received packets number for ARM
To get better performance, Rx bulk alloc recv function will scan 8 descs
in one time, but the statuses are not consistent on ARM platform because
the memory allocated for Rx descriptors is cacheable hugepages.
This patch is to calculate the number of received packets by scan DD bit
sequentially, and stops when meeting the first packet with DD bit unset.
Fixes: 7431041062b9 ("ixgbe: allow rx bulk alloc") Cc: stable@dpdk.org Signed-off-by: Jianbo Liu <jianbo.liu@linaro.org> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
John Daley [Thu, 9 Feb 2017 00:40:09 +0000 (16:40 -0800)]
net/enic: fix hardcoding of some flow director masks
Hard coded mask values were being used for several of the IPv4 and IPv6
fields. Use the values in the rte_eth_fdir_masks structure provided by the
caller.
Fixes: dfbd6a9cb504 ("net/enic: extend flow director support for 1300 series") Cc: stable@dpdk.org Signed-off-by: John Daley <johndale@cisco.com>
Jingjing Wu [Wed, 8 Feb 2017 05:05:50 +0000 (13:05 +0800)]
net/i40e: fix bitmask of supported Tx flags
PKT_TX_TUNNEL_MASK and PKT_TX_IEEE1588_TMST are missed in bitmask
of all supported packet Tx flags by i40e. It will cause packet preparing
fail when sending tunnel packets with Tx offload.
This patch fixes it.
Yongseok Koh [Thu, 2 Feb 2017 18:43:32 +0000 (10:43 -0800)]
net/mlx5: fix updating total length of multi-packet send
The total length field in descriptor of inlined multi-packet send must be
updated before closing a session. There's possibility of updating it
afterward. This bug might cause one packet out of MLX5_MPW_DSEG_MAX gets
silently dropped by HW and impact performance, especially lossless test.
Jeff Guo [Tue, 7 Feb 2017 03:52:19 +0000 (11:52 +0800)]
net/i40e: fix ethertype filter on X722
The GL_SWR_PRI_JOIN_MAP registers are effective on filters, changing
the register's default value will fail the ethertype filter.
The GL_SWR_PRI_JOIN_MAP values are different for each NIC, and current
X722 register values are wrong.
Fix X722 ethertype filter by setting registers to X722 default NVM
values.
Fixes: 92fbf2cbdff4 ("i40e: support X722 and its A0 hardware") Cc: stable@dpdk.org Signed-off-by: Jeff Guo <jia.guo@intel.com> Acked-by: Jingjing Wu <jingjing.wu@intel.com>
Jakub Palider [Mon, 6 Feb 2017 11:56:56 +0000 (12:56 +0100)]
net/ena: fix setting host attributes
The hardware may reject adding host_info in case support for
host_info is missing in the list of supported features. On the
other hand the list of supported features may contain support
for the host_info - typical bootstrap problem.
This patch solves it by removing check against support for
host_info attribute and improves error handling by reacting
only to host attribute write failure to the hardware.
Fixes: 99ecfbf845b3 ("ena: import communication layer") Cc: stable@dpdk.org Signed-off-by: Jakub Palider <jpa@semihalf.com>
Keith Wiles [Mon, 6 Feb 2017 19:40:37 +0000 (13:40 -0600)]
net/tap: move link down before close
Fixes: f457b472b1f2 ("net/tap: add link up and down operations") Signed-off-by: Keith Wiles <keith.wiles@intel.com> Acked-by: Pascal Mazon <pascal.mazon@6wind.com>
Wei Zhao [Fri, 3 Feb 2017 08:43:57 +0000 (16:43 +0800)]
net/ixgbe: add TCI mask check for flow director
Add more check on the tci mask of VLAN and VXLAN parser
in fdir filter rule pattern parser. If such check not added,
it maybe cause error in fdir configuration set check.
John Daley [Fri, 3 Feb 2017 01:18:40 +0000 (17:18 -0800)]
net/enic: fix memory leak with oversized Tx packets
If a packet send is attempted with a packet larger than the NIC
is capable of processing (9208) it will be dropped with no
completion descriptor returned or completion index update, which
will lead to an mbuf leak and eventual hang.
Drop and count oversized Tx packets in the Tx burst function and
dereference/free the mbuf without sending it to the NIC.
Since the maximum Rx and Tx packet sizes are different on enic
and are now both being used, make the define ENIC_DEFAULT_MAX_PKT_SIZE
be 2 defines, one for Rx and one for Tx.
Fixes: fefed3d1e62c ("enic: new driver") Cc: stable@dpdk.org Signed-off-by: John Daley <johndale@cisco.com>
git.droids-corp.org / dpdk.git / log